From 924597ba8b5def174aebdc96368545f51df1bee2 Mon Sep 17 00:00:00 2001 From: shess Date: Thu, 6 Aug 2015 17:10:52 -0700 Subject: [PATCH] [sql] Remove _HAS_EXCEPTIONS=0 from build info. AFAICT, this comes from the original Chrome check-in. AFAICT, it's either not useful, or is redundent WRT the common build files. BUG=none Review URL: https://codereview.chromium.org/1277763003 Cr-Commit-Position: refs/heads/master@{#342237} --- third_party/sqlite/BUILD.gn | 1 - third_party/sqlite/sqlite.gyp | 3 --- 2 files changed, 4 deletions(-) diff --git a/third_party/sqlite/BUILD.gn b/third_party/sqlite/BUILD.gn index 7f8328d062f3..afdea6ec1f60 100644 --- a/third_party/sqlite/BUILD.gn +++ b/third_party/sqlite/BUILD.gn @@ -22,7 +22,6 @@ source_set("sqlite") { "SQLITE_SECURE_DELETE", "SQLITE_SEPARATE_CACHE_POOLS", "THREADSAFE", - "_HAS_EXCEPTIONS=0", ] if (is_chromeos) { defines += [ diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp index 96c867d12a33..bb3a7f5526e0 100644 --- a/third_party/sqlite/sqlite.gyp +++ b/third_party/sqlite/sqlite.gyp @@ -28,9 +28,6 @@ # appropriately. Chromium doesn't configure SQLite for that, and would # prefer to control distribution to worker threads. 'SQLITE_MAX_WORKER_THREADS=0', - # TODO(shess): Figure out why this is here. Nobody references it - # directly. - '_HAS_EXCEPTIONS=0', # NOTE(shess): Some defines can affect the amalgamation. Those should be # added to google_generate_amalgamation.sh, and the amalgamation # re-generated. Usually this involves disabling features which include -- 2.11.4.GIT