From bd9087b7c5fc0eafab167e994d2f9c142bebb300 Mon Sep 17 00:00:00 2001 From: timurrrr Date: Fri, 30 Jan 2015 06:08:26 -0800 Subject: [PATCH] Disable ASan instrumentation of select sandbox code on Windows This patch allows sbox_unittests and sbox_integration_tests to pass under ASan/Win BUG=382867 NOTRY=true Review URL: https://codereview.chromium.org/891663004 Cr-Commit-Position: refs/heads/master@{#313912} --- build/common.gypi | 1 + tools/memory/asan/blacklist_win.txt | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 tools/memory/asan/blacklist_win.txt diff --git a/build/common.gypi b/build/common.gypi index 6c655bb3f36c..948dcece70dc 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -5597,6 +5597,7 @@ 'VCCLCompilerTool': { 'AdditionalOptions': [ '-fsanitize=address', + '-fsanitize-blacklist=<(PRODUCT_DIR)/../../tools/memory/asan/blacklist_win.txt', ], 'AdditionalIncludeDirectories': [ # MSVC needs to be able to find the sanitizer headers when diff --git a/tools/memory/asan/blacklist_win.txt b/tools/memory/asan/blacklist_win.txt new file mode 100644 index 000000000000..1c0326ce503c --- /dev/null +++ b/tools/memory/asan/blacklist_win.txt @@ -0,0 +1,26 @@ +# The rules in this file are only applied at compile time on Windows. +# Because the Chrome buildsystem does not automatically touch the files +# mentioned here, changing this file requires clobbering all ASan bots. +# +# Please think twice before you add or remove these rules. + +################################################################################ +# Sandbox executes some of its code before the ASan RTL gets initialized and +# maps shadow memory. As a result, instrmented code tries to access unavailable +# shadow memory and faults. +# Temporarily disable instrumentation of that code until we come up with +# a better long-term solution. See http://crbug.com/382867 for details. +fun:*TargetNtSetInformationThread@20 +fun:*TargetNtOpenThreadToken@20 +fun:*TargetNtOpenThreadTokenEx@24 +fun:*TargetNtMapViewOfSection@44 +fun:*AutoProtectMemory*sandbox* +fun:*EatResolverThunk*sandbox* +fun:*InterceptionAgent*sandbox* +fun:*PolicyBase*sandbox* +fun:*ResolverThunk*sandbox* +fun:*Target*SandboxFactory*sandbox* +src:*pe_image.h +src:*pe_image.cc +src:*resolver_32.cc +################################################################################ -- 2.11.4.GIT