From c20c4d903f17db15d5c4de452556eb0e34f30208 Mon Sep 17 00:00:00 2001 From: stevenjb Date: Mon, 21 Sep 2015 20:34:58 -0700 Subject: [PATCH] Elim cr-checkbox cr-checkbox doesn't have any behaviors that we are concerned about or specific styling so it can be simply removed for the reasons mentioned in the issue. BUG=532540 Review URL: https://codereview.chromium.org/1344303004 Cr-Commit-Position: refs/heads/master@{#350102} --- .../resources/settings/checkbox/checkbox.html | 6 +-- .../resources/settings/checkbox/checkbox.js | 4 ++ .../internet_page/internet_detail_page.css | 2 +- .../internet_page/internet_detail_page.html | 6 +-- .../settings/internet_page/network_ip_config.css | 2 +- .../settings/internet_page/network_ip_config.html | 6 +-- .../settings/internet_page/network_proxy.css | 2 +- .../settings/internet_page/network_proxy.html | 6 +-- .../settings/internet_page/network_siminfo.html | 6 +-- .../resources/settings/sync_page/sync_page.css | 4 +- .../resources/settings/sync_page/sync_page.html | 38 ++++++++-------- chrome/chrome_tests.gypi | 1 - .../webui/cr_elements/cr_elements_browsertest.js | 37 ---------------- .../checkbox_tests.js} | 48 ++++++++++---------- .../data/webui/settings/cr_settings_browsertest.js | 2 + .../cr_elements/v1_0/compiled_resources.gyp | 1 - .../v1_0/cr_checkbox/compiled_resources.gyp | 11 ----- .../cr_elements/v1_0/cr_checkbox/cr_checkbox.css | 7 --- .../cr_elements/v1_0/cr_checkbox/cr_checkbox.html | 14 ------ .../cr_elements/v1_0/cr_checkbox/cr_checkbox.js | 51 ---------------------- .../cr_elements/v1_0/cr_checkbox/demo.html | 13 ------ .../resources/cr_elements/v1_0/demo_element.html | 23 +++------- ui/webui/resources/cr_elements_resources.grdp | 9 ---- 23 files changed, 73 insertions(+), 226 deletions(-) delete mode 100644 chrome/test/data/webui/cr_elements/cr_elements_browsertest.js rename chrome/test/data/webui/{cr_elements/cr_checkbox_tests.js => settings/checkbox_tests.js} (60%) delete mode 100644 ui/webui/resources/cr_elements/v1_0/cr_checkbox/compiled_resources.gyp delete mode 100644 ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.css delete mode 100644 ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.html delete mode 100644 ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js delete mode 100644 ui/webui/resources/cr_elements/v1_0/cr_checkbox/demo.html diff --git a/chrome/browser/resources/settings/checkbox/checkbox.html b/chrome/browser/resources/settings/checkbox/checkbox.html index 15ef82ba4d3e..f1b3dac9476d 100644 --- a/chrome/browser/resources/settings/checkbox/checkbox.html +++ b/chrome/browser/resources/settings/checkbox/checkbox.html @@ -1,5 +1,5 @@ - + @@ -11,11 +11,11 @@
- {{label}} {{subLabel}} - +
diff --git a/chrome/browser/resources/settings/checkbox/checkbox.js b/chrome/browser/resources/settings/checkbox/checkbox.js index 49ebb3ab3fa8..834e856aab2f 100644 --- a/chrome/browser/resources/settings/checkbox/checkbox.js +++ b/chrome/browser/resources/settings/checkbox/checkbox.js @@ -36,13 +36,17 @@ Polymer({ checked: { type: Boolean, value: false, + notify: true, observer: 'checkedChanged_', + reflectToAttribute: true }, /** Disabled property for the element. */ disabled: { type: Boolean, value: false, + notify: true, + reflectToAttribute: true }, /** Checkbox label. */ diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.css b/chrome/browser/resources/settings/internet_page/internet_detail_page.css index a82a627a04dc..15a24f53472c 100644 --- a/chrome/browser/resources/settings/internet_page/internet_detail_page.css +++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.css @@ -57,7 +57,7 @@ max-width: 500px; } -cr-checkbox { +paper-checkbox { margin-bottom: 10px; } diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html index 29959fdecf9e..32e47c848381 100644 --- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html +++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html @@ -1,8 +1,8 @@ + - @@ -56,10 +56,10 @@ Prefer this network - Automatically connect to this network - + - + @@ -7,9 +7,9 @@