From c39790a99ebaa6c73671de3f6837e820dcc65a1f Mon Sep 17 00:00:00 2001 From: tfarina Date: Mon, 23 Feb 2015 17:34:34 -0800 Subject: [PATCH] Mark //testing/perf target testonly. That should prevent it from be used in production code. BUG=280157 R=brettw@chromium.org Review URL: https://codereview.chromium.org/948143003 Cr-Commit-Position: refs/heads/master@{#317726} --- chrome/browser/BUILD.gn | 3 --- chrome/chrome_browser.gypi | 2 -- testing/perf/BUILD.gn | 1 + 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn index 89a043f74649..63c659bffcf9 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn @@ -278,9 +278,6 @@ static_library("browser") { "//ui/surface", "//ui/web_dialogs", "//v8", - - ## TODO(tonyg): Remove this dependency (crbug.com/280157). - "//testing/perf", ] } else { # iOS sources += diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 28082ca13dcb..6f9d984b1fc2 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -3020,8 +3020,6 @@ '../net/net.gyp:net_with_v8', '../storage/storage_browser.gyp:storage', '../storage/storage_common.gyp:storage_common', - # TODO(tonyg): Remove this dependency (crbug.com/280157). - '../testing/perf/perf_test.gyp:*', '../third_party/expat/expat.gyp:expat', '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase', '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput', diff --git a/testing/perf/BUILD.gn b/testing/perf/BUILD.gn index ee6e1da1e334..949f15abf1e2 100644 --- a/testing/perf/BUILD.gn +++ b/testing/perf/BUILD.gn @@ -3,6 +3,7 @@ # found in the LICENSE file. source_set("perf") { + testonly = true sources = [ "perf_test.cc", "perf_test.h", -- 2.11.4.GIT