From f57c7a533182a27b7ad378744062e1ad2ee87c0c Mon Sep 17 00:00:00 2001 From: "wjmaclean@chromium.org" Date: Fri, 11 Jul 2014 23:45:33 +0000 Subject: [PATCH] Remove RenderViewObserver::ZoomLevelChanged. This pathway is obsolete, and is removed in this CL. BUG=392851 Review URL: https://codereview.chromium.org/388583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282738 0039d316-1c4b-4281-b951-d872f2087c98 --- components/autofill/content/renderer/autofill_agent.cc | 7 ------- components/autofill/content/renderer/autofill_agent.h | 1 - content/public/renderer/render_view_observer.h | 1 - content/renderer/render_view_impl.cc | 2 -- 4 files changed, 11 deletions(-) diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc index db3def1fd9cd..a9b5badfa19b 100644 --- a/components/autofill/content/renderer/autofill_agent.cc +++ b/components/autofill/content/renderer/autofill_agent.cc @@ -217,13 +217,6 @@ void AutofillAgent::WillSubmitForm(WebLocalFrame* frame, } } -void AutofillAgent::ZoomLevelChanged() { - // Any time the zoom level changes, the page's content moves, so any Autofill - // popups should be hidden. This is only needed for the new Autofill UI - // because WebKit already knows to hide the old UI when this occurs. - HidePopup(); -} - void AutofillAgent::FocusedNodeChanged(const WebNode& node) { if (password_generation_agent_ && password_generation_agent_->FocusedNodeHasChanged(node)) { diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h index 1ff747d284f1..aa3841348b6a 100644 --- a/components/autofill/content/renderer/autofill_agent.h +++ b/components/autofill/content/renderer/autofill_agent.h @@ -65,7 +65,6 @@ class AutofillAgent : public content::RenderViewObserver, virtual void FrameWillClose(blink::WebFrame* frame) OVERRIDE; virtual void WillSubmitForm(blink::WebLocalFrame* frame, const blink::WebFormElement& form) OVERRIDE; - virtual void ZoomLevelChanged() OVERRIDE; virtual void DidChangeScrollOffset(blink::WebLocalFrame* frame) OVERRIDE; virtual void FocusedNodeChanged(const blink::WebNode& node) OVERRIDE; virtual void OrientationChangeEvent() OVERRIDE; diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h index 2849bdd45d68..bf3d6395fe0f 100644 --- a/content/public/renderer/render_view_observer.h +++ b/content/public/renderer/render_view_observer.h @@ -79,7 +79,6 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener, blink::WebDataSource* ds) {} virtual void PrintPage(blink::WebLocalFrame* frame, bool user_initiated) {} virtual void FocusedNodeChanged(const blink::WebNode& node) {} - virtual void ZoomLevelChanged() {}; virtual void DidChangeScrollOffset(blink::WebLocalFrame* frame) {} virtual void DraggableRegionsChanged(blink::WebFrame* frame) {} virtual void DidCommitCompositorFrame() {} diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc index 2e661e9824a4..b7bd7920f58a 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc @@ -3939,8 +3939,6 @@ void RenderViewImpl::zoomLimitsChanged(double minimum_level, void RenderViewImpl::zoomLevelChanged() { double zoom_level = webview()->zoomLevel(); - FOR_EACH_OBSERVER(RenderViewObserver, observers_, ZoomLevelChanged()); - // Do not send empty URLs to the browser when we are just setting the default // zoom level (from RendererPreferences) before the first navigation. if (!webview()->mainFrame()->document().url().isEmpty()) { -- 2.11.4.GIT