| commit | 1800ad549890ffc104fbb64befdf7b8734b39739 | |
| author | Tarun Tuli <taruntuli@google.com> | |
| Wed, 3 May 2023 17:58:24 +0000 (3 17:58 +0000) | ||
| committer | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | |
| Fri, 5 May 2023 05:13:43 +0000 (5 05:13 +0000) | ||
| tree | 82d04a332d429b4bf9825eb4c6b5586630d96b71 | treesnapshot (tar.gz zip) |
| parent | 9e2b29d87dc2e36bca753b6e09ac237a4a9367e5 | commitdiff |
mb/google/poppy/variant/nami - Move FPMCU IO setup back to ramstage
variant_board_sku() is missing dependences in order to work correctly
in romstage. Rather than more intrusive rework as its use is limited,
move the FPMCU early GPIO init back to ramstage. We still meet
sufficient power off time to fully power cycle the MCU.
BUG=b:245954151
TEST=Confirmed FPMCU is still functional on Nami and FP tests all pass
Signed-off-by: Tarun Tuli <taruntuli@google.com>
Change-Id: Ia428ec5aec1a0438e91bc48903bda043046b740e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74695
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
variant_board_sku() is missing dependences in order to work correctly
in romstage. Rather than more intrusive rework as its use is limited,
move the FPMCU early GPIO init back to ramstage. We still meet
sufficient power off time to fully power cycle the MCU.
BUG=b:245954151
TEST=Confirmed FPMCU is still functional on Nami and FP tests all pass
Signed-off-by: Tarun Tuli <taruntuli@google.com>
Change-Id: Ia428ec5aec1a0438e91bc48903bda043046b740e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74695
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
| src/mainboard/google/poppy/variants/nami/gpio.c | diffblobblamehistory |