| commit | 6397687940f899552c37e77c71d4fe4dd04825ad | |
| author | Angel Pons <th3fanbus@gmail.com> | |
| Wed, 2 Nov 2022 00:04:24 +0000 (2 01:04 +0100) | ||
| committer | Eric Lai <eric_lai@quanta.corp-partner.google.com> | |
| Thu, 3 Nov 2022 02:01:14 +0000 (3 02:01 +0000) | ||
| tree | 30193763a9bce0fc3fdac109ad33269e42895749 | treesnapshot (tar.gz zip) |
| parent | 5faaca09b8ea433a42a15408ec55074d7f9e143e | commitdiff |
nb/intel/gm45: Make polling loops more explicit
Replace `while (...);` with `do {} while (...);` so that it's easier to
distinguish polling loops from something else, like function calls. The
`{}` can be understood as "nothing", so that the construct is naturally
read as "do nothing while (...)".
Another reason to prefer this method is that Jenkins does not complain.
Change-Id: Ifbf3cf072f8b817b2fdeece4ef89bae0822bb6e6
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Replace `while (...);` with `do {} while (...);` so that it's easier to
distinguish polling loops from something else, like function calls. The
`{}` can be understood as "nothing", so that the construct is naturally
read as "do nothing while (...)".
Another reason to prefer this method is that Jenkins does not complain.
Change-Id: Ifbf3cf072f8b817b2fdeece4ef89bae0822bb6e6
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| src/northbridge/intel/gm45/pcie.c | diffblobblamehistory |