| commit | 937cac30abac48ab8c22b85aaedcf65bb2f244b0 | |
| author | Subrata Banik <subratabanik@google.com> | |
| Fri, 25 Oct 2024 08:35:37 +0000 (25 14:05 +0530) | ||
| committer | Subrata Banik <subratabanik@google.com> | |
| Sat, 26 Oct 2024 02:54:56 +0000 (26 02:54 +0000) | ||
| tree | 1f4c00cb1222c67b75926f22f354f47ee78091b8 | treesnapshot (tar.gz zip) |
| parent | 892257ec2187e84c1610d97367ca59270bcbadda | commitdiff |
mb/google/fatcat: Drop LOCK_CONFIG for GPP_D15 in early GPIO config
Ideally lock configuration is not applicable for early GPIO
configuration (like bootblock/romstage) and is only required for GPIO
PAD configuration by later statge (like ramstage).
The GPP_D15 pin was previously configured with LOCK_CONFIG in the
early bootblock GPIO configuration. This is not necessary and prevents
later boot stages from configuring this GPIO.
Change-Id: Ie0e648b750d7579def39ed95eab862dc3245499c
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84867
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Pranava Y N <pranavayn@google.com>
Reviewed-by: Cliff Huang <cliff.huang@intel.com>
Ideally lock configuration is not applicable for early GPIO
configuration (like bootblock/romstage) and is only required for GPIO
PAD configuration by later statge (like ramstage).
The GPP_D15 pin was previously configured with LOCK_CONFIG in the
early bootblock GPIO configuration. This is not necessary and prevents
later boot stages from configuring this GPIO.
Change-Id: Ie0e648b750d7579def39ed95eab862dc3245499c
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84867
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Pranava Y N <pranavayn@google.com>
Reviewed-by: Cliff Huang <cliff.huang@intel.com>
| src/mainboard/google/fatcat/variants/fatcat/gpio.c | diffblobblamehistory |