soc/intel: Correct return type of fsp_get_pch_reset_status()
commitc74de0dea765159e9d7b2f3541b389e95012e063
authorSubrata Banik <subratabanik@google.com>
Fri, 27 Sep 2024 10:03:14 +0000 (27 15:33 +0530)
committerFelix Held <felix-coreboot@felixheld.de>
Tue, 1 Oct 2024 21:34:49 +0000 (1 21:34 +0000)
tree7a50579c8b60a1472f149e7297a036c6f6685b2d
parent2ec9addc301151319cd73fe10b1e0acbccb8201b
soc/intel: Correct return type of fsp_get_pch_reset_status()

The `fsp_get_pch_reset_status()` function returns a FSP reset status
code. This change corrects its return type from `uint32_t` to
`efi_return_status_t` to ensure consistency with the FSP API and
prevent potential issues caused by type mismatch.

This correction is necessary for compatibility with both 32-bit and
64-bit FSP interfaces.  The change also updates all callers of this
function in the Meteor Lake and Panther Lake SoCs to use the correct
return type.

Includes `fsp/api.h` to provide the `efi_return_status_t` definition.

BUG=b:347669091
TEST=Verified global reset functionality on google/rex0 (32-bit) and
     google/rex64 (64-bit) platforms.

Change-Id: I0cdee541506bf424f50fd00833d5ee200a3a8a48
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84571
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
src/soc/intel/common/fsp_reset.c
src/soc/intel/common/reset.h
src/soc/intel/meteorlake/chip.c
src/soc/intel/pantherlake/chip.c