From 016cc4296e7040c60c741b186d6b3e87a688421c Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Thu, 22 Nov 2018 16:30:57 +0100 Subject: [PATCH] siemens/mc_apl1/variants/mc_apl*: Remove unneeded PTN read An additional read of PTN configuration data at the end of the ptn3460_init function is not necessary. Change-Id: I5f7f647242e94b1af13757d00e80ed9813d435d0 Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/c/29799 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Paul Menzel --- src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c | 6 ------ src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c | 6 ------ 2 files changed, 12 deletions(-) diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c index e95b75247b..060a35c0a8 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/ptn3460.c @@ -109,12 +109,6 @@ int ptn3460_init(const char *hwi_block) return (PTN_BUS_ERROR | status); } - /* Read PTN configuration data. */ - status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, - PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg)); - if (status) - return (PTN_BUS_ERROR | status); - return PTN_NO_ERROR; } diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c index 829af2a25b..01da624d29 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c @@ -110,12 +110,6 @@ int ptn3460_init(const char *hwi_block) return (PTN_BUS_ERROR | status); } - /* Read PTN configuration data. */ - status = i2c_read_bytes(PTN_I2C_CONTROLLER, PTN_SLAVE_ADR, - PTN_CONFIG_OFF, (uint8_t *)&cfg, sizeof(cfg)); - if (status) - return (PTN_BUS_ERROR | status); - return PTN_NO_ERROR; } -- 2.11.4.GIT