| commit | 92f90bcd969c1d57b7df16433016b3c2d53784aa | |
| author | Jeremy Compostella <jeremy.compostella@intel.com> | |
| Tue, 29 Oct 2024 04:05:31 +0000 (28 21:05 -0700) | ||
| committer | Subrata Banik <subratabanik@google.com> | |
| Tue, 19 Nov 2024 04:23:58 +0000 (19 04:23 +0000) | ||
| tree | e297323192ab6f091469067b27b54f54a5b3e97b | treesnapshot (tar.gz zip) |
| parent | 2fe032ff8e8616d60a87d420fd20d7a3c75be7fa | commitdiff |
drivers/wifi: Remove unnecessary data structure copy
The current design has the emit_wifi_sar_acpi_structures() function
load and unload the SAR binary. Since DSM and Bluetooth SAR data
structures are used outside this function, they are being copied into
data structure located in the calling function stack. This overhead is
unnecessary as loading and unloading the SAR binary could be done by
the calling function.
In addition, we are about to add several Bluetooth related data
structures which, under the current design, would require to add even
more data structure copy operations.
BUG=b:346600091
TEST=Wifi/Bluetooth SAR ACPI tables are identical before and after
this commit
Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e207
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84940
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
The current design has the emit_wifi_sar_acpi_structures() function
load and unload the SAR binary. Since DSM and Bluetooth SAR data
structures are used outside this function, they are being copied into
data structure located in the calling function stack. This overhead is
unnecessary as loading and unloading the SAR binary could be done by
the calling function.
In addition, we are about to add several Bluetooth related data
structures which, under the current design, would require to add even
more data structure copy operations.
BUG=b:346600091
TEST=Wifi/Bluetooth SAR ACPI tables are identical before and after
this commit
Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e207
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84940
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
| src/drivers/wifi/generic/acpi.c | diffblobblamehistory |