1 2007-01-29 Jim Meyering <jim@meyering.net>
4 * src/ls.c (print_dir): Don't leak a "DIR"+fd upon failure to
5 determine dev/inode or upon detecting a symlink loop.
7 * src/ls.c: Rename three global variables.
8 (cwd_file): Rename from 'files'.
9 (cwd_n_alloc): Rename from 'nfiles'.
10 (cwd_n_used): Rename from 'files_index'.
12 Shave 8 bytes off the size of "struct fileinfo".
13 * src/ls.c (fileinfo): Put all members of type "bool" together.
15 2007-01-28 Paul Eggert <eggert@cs.ucla.edu>
17 Modify "ls" to sort its data faster, using the new gnulib mpsort
18 module rather than qsort. This is particularly a win in
19 environments where strcoll is slow, since mpsort typically calls
20 strcoll less often than qsort does.
21 * bootstrap.conf (gnulib_modules): Add mpsort.
22 * src/ls.c: Include mpsort.h.
23 (sorted_file, sorted_file_alloc): New vars, for a new vector of
24 pointers to the file info, for speed.
25 (clear_files, extract_dirs_from_files, sort_files, print_current_files):
26 (print_many_per_line, print_horizontal, print_with_commas):
27 (calculate_columns): Set and use new vector.
28 (initialize_ordering_vector): New function.
30 2007-01-26 Paul Eggert <eggert@cs.ucla.edu>
32 Adjust to today's change to gnulib, which added a module for
33 string.h to replace the little include files like strcase.h.
34 * src/dircolors.c: Don't include strcase.h.
35 * src/system.h: Don't include mempcpy.h, memrchr.h, stpcpy.h, strpbrk.h.
37 2007-01-26 Jim Meyering <jim@meyering.net>
39 * src/dd.c (advance_input_after_read_error): Change diagnostic to
40 say "invalid file offset" rather than "screwy file offset".
42 * .x-sc_cast_of_argument_to_free: Remove this file.
43 * Makefile.am (EXTRA_DIST): Likewise.
45 2007-01-25 Dan Hipschman <dsh@linux.ucla.edu>
47 * src/sort.c (create_temp): Remove superfluous access-X_OK
48 check. find_in_path does this for us.
50 2007-01-24 Jim Meyering <jim@meyering.net>
52 Remove usually-skipped test.
53 * tests/cp/open-perm-race: Remove this file. It is subsumed
55 * tests/cp/Makefile.am (TESTS): Remove open-perm-race.
56 * tests/sort/Makefile.am: Regenerate.
58 Pass "make distcheck" again.
59 * src/sort.c (usage): Split a diagnostic that had grown to be
60 longer than the C89 maximum of 509 bytes.
61 * .x-sc_cast_of_argument_to_free: New file. Allow a cast in sort.c.
62 FIXME: this is just temporary, while we wait to remove the offending
64 * Makefile.am (EXTRA_DIST): Add .x-sc_cast_of_argument_to_free.
65 * Makefile.maint (sc_cast_of_argument_to_free): Use the
66 canonical, $$($(CVS_LIST_EXCEPT)).
67 * m4/.gitignore, m4/.cvsignore, lib/.gitignore, lib/.cvsignore: Update.
69 2007-01-24 Paul Eggert <eggert@cs.ucla.edu>
71 * NEWS: New option sort -C, proposed by XCU ERN 127, which looks
72 like it will be approved. Also add --check=quiet, --check=silent
73 as long aliases, and --check=diagnose-first as an alias for -c.
74 * doc/coreutils.texi (sort invocation): Document this.
75 Also, mention that sort -c can take at most one file.
76 * src/sort.c: Implement this.
78 (usage): Document the change.
79 (CHECK_OPTION): New constant.
80 (long_options): --check now takes an optional argument, and is now
81 treated differently from 'c'.
82 (check_args, check_types): New constant arrays.
83 (check): New arg CHECKONLY, which suppresses diagnostic if -C.
84 (main): Parse the new options.
85 * tests/sort/Test.pm (02d, 02d, incompat5, incompat6):
88 2007-01-24 Jim Meyering <jim@meyering.net>
91 * tests/misc/sort-compress: Use $abs_top_builddir, not $top_builddir.
92 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Likewise.
94 Don't depend on "which".
95 * tests/misc/sort-compress (SORT): Use $abs_builddir, now which.
96 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Export top_builddir.
98 2007-01-24 Dan Hipschman <dsh@linux.ucla.edu>
100 Test sort compression.
101 * tests/misc/Makefile.am: Add the test.
102 * tests/misc/sort-compress: New file containing the tests.
104 2007-01-24 Jim Meyering <jim@meyering.net>
106 * NEWS: sort temp file compression: tweak wording.
107 * src/sort.c (struct sortfile) [name]: Declare member to be const.
109 2007-01-21 Jim Meyering <jim@meyering.net>
111 * src/sort.c (MAX_FORK_RETRIES_COMPRESS, MAX_FORK_RETRIES_DECOMPRESS):
112 In pipe_fork callers, use these named constants, not "2" and "8".
113 (proctab, nprocs): Declare to be "static".
114 (pipe_fork) [lint]: Initialize local, pid,
115 to avoid unwarranted may-be-used-uninitialized warning.
116 (create_temp): Use the active voice. Describe parameters, too.
118 2007-01-21 James Youngman <jay@gnu.org>
120 Centralize all the uses of sigprocmask(). Don't restore an invalid
122 * src/sort.c (enter_cs, leave_cs): New functions for protecting
123 code sequences against signal delivery.
124 * (exit_cleanup): Use enter_cs and leave_cs instead of
125 calling sigprocmask directly.
126 (create_temp_file, pipe_fork, zaptemp): Likewise
128 2007-01-21 Dan Hipschman <dsh@linux.ucla.edu>
130 Add compression of temp files to sort.
131 * NEWS: Mention this.
132 * bootstrap.conf: Import findprog.
133 * configure.ac: Add AC_FUNC_FORK.
134 * doc/coreutils.texi: Document GNUSORT_COMPRESSOR environment
136 * src/sort.c (compress_program): New global, holds the name of the
137 external compression program.
138 (struct sortfile): New type used by mergepfs and friends instead
139 of filenames to hold PIDs of compressor processes.
140 (proctab): New global, holds compressor PIDs on which to wait.
141 (enum procstate, struct procnode): New types used by proctab.
142 (proctab_hasher, proctab_comparator): New functions for proctab.
143 (nprocs): New global, number of forked but unreaped children.
144 (reap, reap_some): New function, wait for/cleanup forked processes.
145 (register_proc, update_proc, wait_proc): New functions for adding,
146 modifying and removing proctab entries.
147 (create_temp_file): Change parameter type to pointer to file
148 descriptor, and return type to pointer to struct tempnode.
149 (dup2_or_die): New function used in create_temp and open_temp.
150 (pipe_fork): New function, creates a pipe and child process.
151 (create_temp): Creates a temp file and possibly a compression
152 program to which we filter output.
153 (open_temp): Opens a compressed temp file and creates a
154 decompression process through which to filter the input.
155 (mergefps): Change FILES parameter type to struct sortfile array
156 and update access accordingly. Use open_temp and reap_some.
157 (avoid_trashing_input, merge): Change FILES parameter like
158 mergefps and call create_temp instead of create_temp_file.
159 (sort): Call create_temp instead of create_temp_file.
161 (avoid_trashing_input, merge, sort, main): Adapt to mergefps.
163 2007-01-20 Jim Meyering <jim@meyering.net>
165 * tests/misc/pwd-long: Work properly even when run from the
166 wrong one of two or more bind-mounted sibling directories.
167 Suggestion from Mike Stone in <http://bugs.debian.org/380552>.
169 2007-01-20 Paul Eggert <eggert@cs.ucla.edu>
171 Standardize on list of signals when an app catches signals.
172 * src/csplit.c (main): Also catch SIGALRM, SIGPIPE, SIGPOLL,
173 SIGPROF, SIGVTALRM, SIGXCPU, SIGXFSZ.
174 * src/ls.c (main): Likewise (except SIGPIPE was already caught).
175 Note that ls.c is special, as it also catches SIGTSTP.
176 * src/sort.c (main): Likewise. Also catch SIGQUIT. More details in
177 <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/9510>.
179 2007-01-19 Dan Hipschman <dsh@linux.ucla.edu>
180 and Paul Eggert <eggert@cs.ucla.edu>
182 * src/sort.c (cleanup): Clear temphead at the end.
183 (exit_cleanup): New function.
184 (main): Don't invoke atexit until we're ready.
185 Invoke it with exit_cleanup, not with cleanup and close_stdout,
186 to avoid a race condition with cleanup and signal handling. More
187 details: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/9508
189 2007-01-18 Jim Meyering <jim@meyering.net>
191 * src/c99-to-c89.diff: Adjust remove.c offsets.
193 2007-01-17 Jim Meyering <jim@meyering.net>
195 Make "rm --interactive=never ..." never prompt.
196 * NEWS: Mention this.
197 * src/remove.h (enum rm_interactive): New ternary type.
198 (struct rm_options) [interactive]: Use it, here -- rather than bool.
199 * src/remove.c (prompt): Reflect type change.
200 * src/mv.c (rm_option_init): Initialize to RMI_NEVER now.
201 * src/rm.c (main): Add a FIXME comment for '-d' option.
202 Adapt to type change of rm_options.interactive.
204 * tests/rm/i-never: New file. Test for the above fix.
205 * tests/rm/Makefile.am (TESTS): Add i-never.
207 2007-01-15 Jim Meyering <jim@meyering.net>
209 * bootstrap (gnulib_tool): When adding to .cvsignore and .gitignore,
210 emit foo.h, for each foo_.h. This yields one false-positive, fts.h,
211 but that's ok, since fts_.h will eventually be renamed.
213 * src/remove.c (remove_dir): Don't use errno in diagnostic.
214 Root-only test failure reported by Alex van Hout and Jon Grosshart in
215 <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/9415/focus=9415>.
217 * bootstrap.conf (avoided_gnulib_modules): Fix my typo:
218 s/--avoid=canonicalize-lgpl/--avoid=canonicalize-gpl/
220 2007-01-14 Bruno Haible <bruno@clisp.org>
222 Enable use of gnulib's new fchdir module.
223 * bootstrap.conf (avoided_gnulib_modules): Avoid canonicalize-lgpl,
224 since we use canonicalize.
225 (gnulib_modules): Add fchdir.
226 * m4/jm-macros.m4 (coreutils_MACROS): Remove fchdir-stub.
228 2007-01-13 Jim Meyering <jim@meyering.net>
230 * Transform all Makefile.am files so that when running "make check",
231 CU_TEST_NAME is set to the name of the test. This is so that when I
232 run valgrind-enabled (--log-file-qualifier=CU_TEST_NAME) "make check"
233 on the entire package it is more convenient to map a leak or error
234 found in a valgrind log file back to the offending test.
236 (echo tests/Makefile.am.in; find tests -name Makefile.am) \
237 |xargs perl -pi -e '/^(\s*)PATH=...VG_PATH_PREFIX/ and ' \
238 -e 'print $1,q|CU_TEST_NAME=`basename $(abs_srcdir)`,$$tst |,"\\\n"'
240 2007-01-11 Jim Meyering <jim@meyering.net>
242 Avoid a leak in expr's implementation of the ":" (match) operator.
243 * src/expr.c (docolon): Free the regexp buffer using regfree, rather
244 than doing it manually, being careful to set fastmap to NULL first.
245 Free any re_regs.start and .end members, if necessary.
247 * tests/misc/test-diag: Work also when libc's error function
248 reports the entire program name ("../../src/test"), rather than
249 just the final component.
251 2007-01-10 Jim Meyering <jim@meyering.net>
253 Don't use fts_statp uninitialized for "chown -RLh --preserve-root ...".
254 * src/chown-core.c (FTSENT_IS_DIRECTORY): New macro.
255 (change_file_owner): Perform the ROOT_DEV_INO_CHECK only for a
256 directory. Non-directory entries lack fts_statp data when using
257 the FTS_NOSTAT option.
259 2007-01-07 Jim Meyering <jim@meyering.net>
261 * tests/sample-test: Update copyright date to 2007.
262 * Makefile.maint (copyright-check): Also check the copyright date
263 in tests/sample-test.
265 2007-01-06 Jim Meyering <jim@meyering.net>
267 * tests/fmt/basic (pfx-only, pfx-of-pfx): New tests,
268 based on examples from G.P. Halkes in
269 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/9388>.
271 2007-01-06 G.P. Halkes <buscom@ghalkes.nl>
273 * src/fmt.c (copy_rest): Correct prefix handling.
274 Don't elide a line with the prefix followed by only white space.
275 (get_line): Move EOF-check to loop-termination condition.
276 * tests/fmt/basic (pfx-1): Adjust test to expect desired result.
277 (pfx-2): Remove test; its premise was contrary to the documentation.
279 2007-01-05 Jim Meyering <jim@meyering.net>
281 Avoid a used-uninitialized bug for invalid input, i.e., when the size
282 of the input, not counting newlines, is 1 % 4.
283 * gl/lib/base64.c (base64_decode): Don't hard-code inlen==4.
284 It may be smaller when flushing.
286 2007-01-05 Mike Frysinger <vapier@gentoo.org>
288 * src/dircolors.hin: Add a TERM directive for cons25.
290 2007-01-04 Jim Meyering <jim@meyering.net>
292 * Makefile.cfg (local-checks-to-skip): Skip strftime-check, in
293 case you don't have convenient access to glibc info documentation.
295 Use the release year, not the current year.
296 * src/groups.sh (version): Use a better name: @RELEASE_YEAR@.
297 * src/Makefile.am (RELEASE_YEAR): Define it.
299 Thanks to a prod from Eric Blake.
301 Ensure that "group --version" always prints the current year.
302 * src/groups.sh (version): Use @CURRENT_YEAR@, rather than 2006.
303 * src/Makefile.am (.sh): Also substitute for @CURRENT_YEAR@.
304 Suggestion from Eric Blake.
306 When decoding, always allow newlines in input, with almost no
308 * src/base64.c (do_decode): Initialize decode context.
309 Call base64_decode one more time, after all input is processed.
310 (usage): When decoding, newlines are always accepted.
312 * tests/misc/base64: Add a bunch of tests, for the above.
313 * gl/lib/base64.c: Include <string.h>.
314 (base64_decode_ctx_init, get_4, decode_4): New functions.
315 (base64_decode): Efficiently handle interspersed newlines.
316 (base64_decode_alloc): Update signature.
317 * gl/lib/base64.h (struct base64_decode_context): Define.
318 (base64_decode_ctx_init): Add prototype.
319 (base64_decode, base64_decode_alloc): Update prototypes.
321 * gl/lib/base64.c: Copied from gnulib.
322 * gl/lib/base64.h: Likewise.
324 2007-01-03 Jim Meyering <jim@meyering.net>
326 * THANKS: Add Evan Hunt.
328 2007-01-03 Bruno Haible <bruno@clisp.org>
330 Avoid spurious test failures on MacOS X 10.3.9, in a German locale.
331 * tests/chown/deref: Apply lang-default.
332 * tests/misc/split-a: Likewise.
333 * tests/mv/reply-no: Likewise.
335 * src/copy.c (copy_internal): Use mkfifo as a fallback if mknod fails.
338 2007-01-02 Paul Eggert <eggert@cs.ucla.edu>
340 Now, "ls -FRL" always follows symbolic links on Linux.
341 * NEWS: Mention this bug fix.
342 * src/ls.c (gobble_file): Fix bug reported by
343 Nobuyuki Tsuchimura in
344 http://lists.gnu.org/archive/html/bug-coreutils/2006-12/msg00152.html
345 where "ls -FRL" didn't follow a symbolic link in some cases on Linux.
346 * tests/ls/follow-slink: Add a test for this case.
348 2007-01-01 Jim Meyering <jim@meyering.net>
350 * tests/rm/fail-eperm: Revert last change. The PATH=... setting
351 is not honored at least on HP-UX 11.23 systems.
352 Instead, simply transform the actual output diagnostic.
353 Test failure reported by Bob Proulx.
355 2006-12-30 Jim Meyering <jim@meyering.net>
357 * bootstrap (gnulib_extra_files): Remove announce-gen.
358 * bootstrap.conf (gnulib_modules): Add it here instead, now that
361 * tests/misc/base64: Factor a long, repetitive string.
363 * src/c99-to-c89.diff: Adjust remove.c offsets.
365 Clean up after the change of 2006-12-28.
366 * src/remove.c (AD_pop_and_chdir): Change **DIRP parameter to *DIRP,
367 now that this function never modifies the pointer. Adjust comments
368 and code accordingly.
369 (remove_dir): Set "dirp" to NULL right after AD_pop_and_chdir call,
370 now that AD_pop_and_chdir no longer does that.
372 * tests/rm/fail-eperm: Avoid spurious differences (the error function
373 from latest glibc no longer prints the full program_name): so don't
374 invoke rm via ../../src/rm. Instead, invoke it via "PATH=../../src rm".
376 * tests/mv/acl (skip): Skip this test also if the destination
377 directory, which is on a different file system, lacks ACL support.
379 * src/copy.c (copy_reg): Rewrite a comment that was rendered
380 inaccurate by the 2006-10-18 change.
382 2006-12-28 Jim Meyering <jim@meyering.net>
384 When moving "up" the hierarchy, be careful to remove a just-emptied
385 directory before opening ".", to avoid trouble with file system
386 implementations that cache readdir results at opendir-time.
387 * src/remove.c (AD_pop_and_chdir): Add a file descriptor parameter.
388 Don't update **DIRP. Don't call fdopendir here.
389 (remove_dir): Call fdopendir here instead.
390 Report and patch from Mikulas Patocka:
391 <http://lists.gnu.org/archive/html/bug-coreutils/2006-12/msg00170.html>
393 2006-12-27 Jim Meyering <jim@meyering.net>
395 * src/tail.c (usage): Mention +N for --bytes and --lines.
396 Suggestion from Evan Hunt.
398 2006-12-26 Jim Meyering <jim@meyering.net>
400 * configure.ac: Require autoconf-2.61 and automake-1.10.
401 Without the former (even with autoconf-2.60), "make distcheck"
402 would fail (without the 2006-09-26 autoconf AC_CHECK_DECL fix),
403 due to an inttypes.h generated with CFLAGS including -pedantic.
404 With the old decl check, @HAVE_DECL_STRTOUMAX@ would be 0.
406 * Makefile.maint (VC-tag): Define, so as to gpg-sign each release
407 tag, using the release version number as the message.
408 (vc-dist): Use $(VC-tag), rather than "$(VC) tag".
410 2006-12-21 Paul Eggert <eggert@cs.ucla.edu>
412 * NEWS: dd bs= operands now silently override later ibs= and obs=,
414 * src/dd.c (scanargs): Implement it.
415 * tests/dd/misc (outbytes): Test it.
416 * doc/coreutils.texi (dd invocation): Specify that bs=N
417 overrides later ibs and obs, undoing part of the
418 previous change. (The behavior was wrong.)
420 2006-12-20 Jim Meyering <jim@meyering.net>
422 "rm -rf /etc/motd" (run by non-root) now prints a diagnostic.
423 * src/remove.c (remove_entry): Handle EACCES for a non-directory, too.
424 Don't let a non-directory get by with errno == EPERM, either.
425 Check the file type directly (using cached stat value), rather
426 than trying to guess it from errno values.
427 Karl Berry reported that a cross-partition "mv /etc/issue ~"
428 failed with the um,... suboptimal diagnostic,
429 "mv: cannot remove `/etc/issue': Not a directory".
430 * tests/rm/Makefile.am (TESTS): Add fail-eacces.
431 * tests/rm/fail-eacces: New file.
432 * NEWS: Mention that both mv and rm are affected.
434 "cut -f 2- A B" no longer triggers a double-free bug
435 * src/cut.c (cut_fields): Set file-scoped global to NULL after
436 freeing it. This avoids a double-free (and core dump on some systems)
437 for this usage: "echo 1>a; echo 2>b; cut -f2- a b". Reported by
438 James Hunt in <http://bugzilla.redhat.com/220312>.
439 * NEWS: List this bug fix.
440 * THANKS: Mention him.
441 * tests/misc/cut: New file.
442 * tests/misc/Makefile.am (TESTS): Add cut.
444 2006-12-15 Jim Meyering <jim@meyering.net>
446 * tests/cp/open-perm-race: Correct the gdb-existence check.
447 Don't run either subsequent gdb command in a sub-shell.
448 Reported by Thomas Schwinge.
449 * THANKS: bring up to date.
451 2006-12-14 Paul Eggert <eggert@cs.ucla.edu>
453 Make sure cp -p isn't too generous with file permissions.
454 * tests/cp/Makefile.am (TESTS): Add file-perm-race.
455 * tests/cp/file-perm-race: New file.
457 Ensure cp -pR --parents isn't too generous with parent permissions.
458 * tests/cp/Makefile.am (TESTS): Add parent-perm-race.
459 * tests/cp/parent-perm-race: New file.
461 2006-12-14 Jim Meyering <jim@meyering.net>
463 * tests/chgrp/default-no-deref: Don't assume that files are created
464 with the primary group by default. That's not true in a directory
465 with the set-GID bit set.
467 Don't hang when there's no input tty.
468 * tests/cp/open-perm-race: Skip this test if there is no
469 controlling input `terminal'.
471 Test for a hard-to-detect race fix, using gdb.
472 * tests/cp/open-perm-race: New file, to test for the
473 cp --preserve=ownership fix of 2006-12-06.
475 * tests/cp/Makefile.am (TESTS_ENVIRONMENT): Define abs_top_builddir.
476 (TESTS): Add open-perm-race.
478 * src/chgrp.c (main): Don't prohibit -RLh, aka -RL with --no-dereference.
479 * src/chown.c (main): Likewise.
480 * src/chown-core.c (change_file_owner): Add to a comment.
481 * tests/chown/preserve-root: Add tests.
483 * NEWS: --preserve-root now works with chgrp, chmod, and chown.
484 * src/chmod.c (process_file): Do honor the --preserve-root option.
485 * src/chown-core.c (change_file_owner): Likewise, but here, also
486 handle the case in which a traversal would go "through" a symlink
487 to root. Reported by Matthew M. Boedicker
488 * tests/chown/preserve-root: Test for the above.
489 * tests/chown/Makefile.am (TESTS): Add preserve-root.
491 * NEWS: Mention the chmod fix induced by the 2006-12-11 change
492 to gnulib's m4/openat.m4.
494 2006-12-13 Andreas Schwab <schwab@suse.de>
496 Don't fail if mv/acl test succeeds.
497 * tests/mv/acl (skip): Check for acl support in the file system.
498 * tests/mv/Makefile.am (XFAIL_TESTS): Remove.
499 (TESTS_ENVIRONMENT): Pass CONFIG_HEADER.
501 2006-12-13 Paul Eggert <eggert@cs.ucla.edu>
503 Remove some arbitrary restrictions on size fields, so that
504 commands like "sort -k 18446744073709551616" no longer fail merely
505 because 18446744073709551616 doesn't fit in uintmax_t. The trick
506 is that these fields can all be treated as effectively infinity;
507 their exact values don't matter, since no internal buffer can be
509 * src/join.c (string_to_join_field): Verify that SIZE_MAX <=
510 ULONG_MAX if the code assumes this. Silently truncate too-large
511 values to SIZE_MAX, as the remaining code will do the right thing
513 * src/sort.c (parse_field_count): Likewise.
514 * src/uniq.c (size_opt, main): Likewise.
515 * tests/join/Test.pm (bigfield): New test.
516 * tests/sort/Test.pm (bigfield): New test.
517 * tests/uniq/Test.pm (121): New test.
519 2006-12-13 Jim Meyering <jim@meyering.net>
521 * tests/chgrp/default-no-deref: New test.
522 * tests/chgrp/Makefile.am (TESTS): Add default-no-deref.
524 2006-12-12 Jim Meyering <jim@meyering.net>
526 * src/system.h (SETVBUF): Remove definition, now that the
527 autoconf macro, AC_FUNC_SETVBUF_REVERSED, does nothing.
528 * src/tee.c (tee_files): s/SETVBUF/setvbuf/.
529 * src/od.c (open_next_file): Likewise.
531 2006-12-09 Jim Meyering <jim@meyering.net>
533 * man/Makefile.am (.x.1): Make help2man use $(PACKAGE_STRING) as the
534 "source". I.e. "GNU coreutils 6.7".
536 * NEWS: With the change from "-pre" to "-dirty" suffix, also change
537 from NEXT_VER-pre to CUR_VER-dirty. So, this is 6.7-dirty.
538 * configure.ac (AC_INIT): s/6.8-dirty/6.7-dirty/.
540 * tests/uniq/Test.pm (test_vector): Skip the pipe-reading test
541 whenever uniq is expected to fail. This should catch the other case
542 [test #112] in which uniq emits "cat: write error: Broken pipe" on
545 2006-12-08 Jim Meyering <jim@meyering.net>
547 Include bootstrap tool version info in the announcement form.
548 * Makefile.maint (gnulib_snapshot_date): Define.
549 (announcement): Use two new announce-gen options,
550 --bootstrap-tools and --gnulib-snapshot-date.
551 * Makefile.cfg (gnulib_dir): Set.
553 Post-release version change.
554 * NEWS: Add a line for 6.8-dirty.
555 * configure.ac (AC_INIT): Set new version string.
557 2006-12-07 Jim Meyering jim@meyering.net
560 * NEWS: Record release date. Remove '-pre' suffix.
561 * configure.ac (AC_INIT): Remove version string suffix.
563 2006-12-07 Jim Meyering <jim@meyering.net>
565 Make the output of "make check" more reproducible.
566 * tests/touch/empty-file: Use envvar-check, so "make check" doesn't
567 evoke diagnostics like this when COLUMNS=0 in the environment:
568 ls: ignoring invalid width in environment variable COLUMNS: 0
569 * tests/touch/no-rights: Likewise.
570 * tests/help-version: Likewise.
571 * tests/uniq/Test.pm: Don't perform the pipe-reading version of test
572 118, since it emits "cat: write error: Broken pipe" on some systems.
574 2006-12-06 Paul Eggert <eggert@cs.ucla.edu>
576 * NEWS: Document the cp -p fix for special bits.
577 * src/copy.c (set_owner): Now returns a three-way result, so
578 that the caller can clear the special bits. All callers changed.
579 (copy_reg): Don't set the special bits if chown failed.
580 (copy_internal): Likewise.
581 * tests/cp/special-bits: Test this fix.
583 2006-12-06 Paul Eggert <eggert@cs.ucla.edu>
585 * NEWS: Document the cp --preserve=ownership fix.
586 * m4/jm-macros.m4 (coreutils_MACROS): Check for fchmod.
587 * src/copy.c (fchmod_or_lchmod): New function.
588 (copy_reg): New arg OMITTED_PERMISSIONS. All uses changed.
589 Omit confusing and unused ", dst_mode" arg to 'open' without O_CREAT.
590 When creating a file, use O_EXCL, so we're more likely to detect
591 funny business by other processes. At the end, if permissions
592 were omitted, chmod them back in.
593 (copy_internal): If the ownership might change, omit some permissions
594 at first, then restore them after chowning the file.
595 * src/cp.c (make_dir_parents_private): Likewise.
596 * src/copy.c (cached_umask): New function.
597 * src/copy.h (cached_umask): New decl.
599 2006-12-06 Jim Meyering <jim@meyering.net>
601 Make the output of "make check" more reproducible.
602 * tests/misc/date-sec: Don't emit any diagnostic about sleeping.
604 2006-12-03 Paul Eggert <eggert@cs.ucla.edu>
606 * src/install.c (install_file_in_file): Preserve time stamps
607 before changing owner or file mode bits, for consistency with
608 other coreutils programs.
610 2006-12-03 Jim Meyering <jim@meyering.net>
612 * tests/misc/date-sec: Output a fixed string.
614 * NEWS: du --one-file-system (-x) would skip subdirectories of any
615 directory listed as second or subsequent command line argument.
616 * tests/du/one-file-system: New file. Test for today's fts.c fix.
617 * tests/du/Makefile.am (TESTS): Add one-file-system.
618 Reported by Mike Frysinger.
620 2006-12-02 Jim Meyering <jim@meyering.net>
622 * tests/du/basic: Generate 4KB file simply using printf, rather than
623 seq+head. This avoids a spurious "Broken pipe" diagnostic from seq.
625 2006-11-28 Jim Meyering <jim@meyering.net>
627 * tests/mv/no-target-dir: Detect a buggy rename syscall. If found,
628 skip this test. This happens at least on ia64 linux-2.4.19 w/ext3.
629 Reported by Matthew Woehlke.
631 * tests/mv/dir2dir: Also accept EBUSY.
632 Reported by Matthew Woehlke.
634 2006-11-27 Jim Meyering <jim@meyering.net>
636 * Makefile.maint (patch-check): Rewrite to diagnose failure.
637 * src/c99-to-c89.diff: Adjust shred.c offsets.
639 2006-11-26 Paul Eggert <eggert@cs.ucla.edu>
641 Improve the check for departures from C89, and fix the departures
643 * Makefile.maint (my-distcheck): Also check for C89 compatibility
644 as best we can with GCC.
645 * src/stat.c (PRINTF_OPTION): Omit comma before } in enum
646 declaration; C89 doesn't allow this.
647 * src/dcgen: Don't generate string literals longer than
648 what C89 requires support for.
649 * src/cut.c (usage): Don't use string literals longer than
650 what C89 requires support for.
651 * src/date.c (usage): Likewise.
652 * src/dd.c (usage): Likewise.
653 * src/du.c (usage): Likewise.
654 * src/ls.c (usage): Likewise.
655 * src/od.c (usage): Likewise.
656 * src/readlink.c (usage): Likewise.
657 * src/seq.c (usage): Likewise.
658 * src/shred.c (usage): Likewise.
660 2006-11-26 Mike Frysinger <vapier@gentoo.org>
662 Recognize new archive, audio and image formats.
663 Give audio files a separate color.
664 * src/dircolors.hin: Add comments for common .sh and .csh scripts.
665 Add .bz2, .tbz2, .tz, .rar, .ace, .zoo, .cpio, .7z, .rz as archive
666 suffixes. Add .mng, .pcx, .m2v, .mkv, .ogm, .mp4, .m4v, .mp4v, .vob,
667 .qt, .nuv, .wmv, .asf, .rm, .rmvb, .flc, .yuv as image formats.
668 Add .aac, .au, .mid, .midi, .mka, .ra as audio suffixes. Change
669 audio color to 00;36 to differentiate from image/video color.
671 2006-11-26 Jim Meyering <jim@meyering.net>
673 * Makefile.maint (patch-check): Compile patched sources with
674 CFLAGS='-Wdeclaration-after-statement -Werror', to ensure that
675 no violations remain.
677 * src/c99-to-c89.diff: Remove 3 bogus hunks.
679 * src/remove.c (fd_to_subdirp): Remove unused parameter, ds.
682 * src/c99-to-c89.diff: Adjust for changes in rm.c and in remove.c.
684 * src/rm.c (main): Remove unnecessary (assuming C99) braces.
686 2006-11-26 Paul Eggert <eggert@cs.ucla.edu>
688 Port parts of the code to C89 to minimize the need for c99-to-c89.diff,
689 while trying to retain the readability of C99 as much as possible.
690 * src/remove.c (rm_1): Remove decl of local, fd_cwd.
691 Replace each of two uses with literal AT_FDCWD.
692 (cache_stat_init): Return its argument, for convenience.
693 Update the caller in remove_dir.
694 (AD_pop_and_chdir): Return prev_dir rather than storing through
695 a pointer argument. All uses changed.
696 (AD_ensure_initialized): New function.
697 (AD_mark_helper): Use it, to avoid the need for declaration
699 (rm): Move cycle_check_init call into callee...
701 Use an else clause in place of a "continue" statement.
702 (close_preserve_errno): Remove.
703 (fd_to_subdirp): Rewrite to avoid the need for decl after statement.
705 2006-11-25 Jim Meyering <jim@meyering.net>
707 * Makefile.am (EXTRA_DIST): Remove announce-gen from here, too.
709 2006-11-24 Theodoros V. Kalamatianos <thkala@softlab.ece.ntua.gr> (tiny change)
711 * tests/du/inacc-dest: Skip this test when running as root.
713 2006-11-23 Jim Meyering <jim@meyering.net>
715 * announce-gen: Remove file. It's moving to gnulib.
716 * bootstrap: Pull it from gnulib/build-aux instead.
717 * Makefile.maint (announcement): Reflect move to ./build-aux.
719 * tests/du/deref-args: Use "printf %65536s x" to create a 64KB file,
720 rather than a pipeline that would sometimes evoke a diagnostic
721 like "seq: write error: Broken pipe".
723 * tests/help-version: Suppress dd transfer rate output.
725 * configure.ac (AC_INIT): Bump to 6.7-pre, not 6.6-pre.
727 2006-11-22 Jim Meyering <jim@meyering.net>
729 * announce-gen (print_news_deltas): Fix silly, but harmless typo:
730 change "(:?..." to "(?:..." in regexps.
732 Post-release version change.
733 * NEWS: Add a line for 6.7-pre.
734 * configure.ac (AC_INIT): Bump to 6.7 and add "-pre" suffix.
737 * NEWS: Record release date. Remove "-pre" suffix.
738 * configure.ac (AC_INIT): Remove "-pre" suffix from version string.
740 * announce-gen: Remove unused --release-archive-directory option.
741 (print_news_deltas): Accept new adjective, "Noteworthy", in addition
743 Match version numbers in NEWS using tighter regular expressions.
744 (main): Require the --gpg-key-id=ID option.
745 * Makefile.maint (announcement): Don't use now-removed
746 --release-archive-directory=... option.
748 * NEWS: Mention the three noteworthy changes, all fixed via gnulib.
750 2006-11-21 Jim Meyering <jim@meyering.net>
752 * tests/rm/one-file-system: Upon setup failure (e.g., mount failure),
753 skip the test rather than failing. Reported by Michael Deutschmann.
755 * tests/rm/fail-eperm: Use the "(exit N); exit N" idiom,
756 rather than just "exit N".
758 Arrange for "make check-root" to run the new root-only test.
759 * tests/Makefile.am (t7): New target, to run tests/ls/nameless-uid.
762 2006-11-20 Jim Meyering <jim@meyering.net>
764 Add a root-only test for today's lib/idcache.c fix.
765 * tests/ls/nameless-uid: New file.
766 * tests/ls/Makefile.am (TESTS): Add nameless-uid.
767 (TESTS_ENVIRONMENT): Add PERL to the list.
769 2006-11-19 Jim Meyering <jim@meyering.net>
771 * tests/tail-2/assert-2: Mark as a very-expensive test, because I
772 find the 7-second sleep annoyingly long. Besides, this test is
773 probably far too specific and timing sensitive ever to trigger again.
774 * tests/tail-2/assert: Likewise.
776 Post-release version change.
777 * NEWS: Add a line for 6.6-pre.
778 * configure.ac (AC_INIT): Bump to 6.6 and add "-pre" suffix.
781 * NEWS: Record release date. Remove "-cvs" suffix.
782 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
784 2006-11-18 Jim Meyering <jim@meyering.net>
786 "ln --backup f f" produces a misleading diagnostic:
787 ln: creating hard link `f' => `f': No such file or directory
788 * src/ln.c (do_link): Give a better diagnostic in this unusual case.
789 (do_link): Rename local: s/lstat_ok/dest_lstat_ok/.
790 * tests/ln/Makefile.am (TESTS): Add hard-backup.
791 * tests/ln/hard-backup: New test for the above.
792 * NEWS: Mention this fix.
794 2006-11-16 Paul Eggert <eggert@cs.ucla.edu>
796 * bootstrap.conf (gnulib_modules): Add sys_stat, since we use it
798 * lib/.cvsignore, lib/.gitignore: Add root-dev-ino.c, root-dev-ino.h.
799 * m4/.cvsignore, m4/.gitignore: Add root-dev-ino.m4.
800 * src/ls.c (DIRED_FPUTS_LITERAL, PUSH_CURRENT_DIRED_POS):
801 Omit unnecessary parenthesization of args.
802 * src/od.c (EQUAL_BLOCKS): Likewise.
803 * src/system.h (STREQ, ASSIGN_STRDUPA): Likewise.
805 2006-11-16 Jim Meyering <jim@meyering.net>
807 * tests/tail-2/append-only: If chattr +a fails, exit 77 (to tell
808 automake we're skipping this test), and give a diagnostic to tell
809 the user the same thing. Reported by Mike Grayson.
811 2006-11-16 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
813 * man/Makefile.am (dist_man_MANS): Replace all optional manpages
814 with `$(MAN)', computed at configure time; also, list them ...
815 (optional_mans): ... in this new variable.
816 (max_aux, EXTRA_DIST): Ensure that we distribute all manpages.
818 2006-11-16 Jim Meyering <jim@meyering.net>
820 Help valgrind see that there is no leak in dd.c.
821 * src/dd.c (dd_copy): Declare real_buf and real_obuf to be static,
822 so we need not free them at all. This is easier than freeing
823 both buffers at each of the early "return"s.
825 * src/csplit.c (load_buffer): Plug an inconsequential leak.
827 2006-11-15 Jim Meyering <jim@meyering.net>
829 * .x-po-check: Exclude gl/ files. Otherwise, po-check would
830 complain that some of gl/lib/*.[ch] are not listed in POTFILES.in.
832 2006-11-14 Jim Meyering <jim@meyering.net>
834 * gl/m4/root-dev-ino.m4: Now that this is part of a real "module",
835 remove the now-unnecessary use of AC_LIBSOURCES.
837 Adapt to new version of gnulib-tool.
838 * gl/modules/root-dev-ino: New file.
839 * lib/root-dev-ino.c, lib/root-dev-ino.h: Move these files ...
840 * gl/lib/root-dev-ino.c, gl/lib/root-dev-ino.h: ... to here.
841 * m4/root-dev-ino.m4: Move this file ...
842 * gl/m4/root-dev-ino.m4: ... to here.
844 * bootstrap.conf (gnulib_modules): Add root-dev-ino.
846 2006-11-13 Jim Meyering <jim@meyering.net>
848 * src/sort.c (insertkey): Use xmemdup, rather than xmalloc+assignment.
851 Plug another technically-unimportant leak in sort.
852 * src/sort.c (main): Don't allocate memory for each new key here.
853 (insertkey): Allocate memory for each key here, instead.
854 (key_init): Rename from new_key. Don't allocate.
856 * src/sort.c (main): Plug a tiny memory leak.
857 Move declaration of local "minus" down to be nearer point of use.
859 2006-11-12 Jim Meyering <jim@meyering.net>
861 du would exit early, when encountering an inaccessible directory
862 Reported by Mike Frysinger, in
863 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/8831
864 * tests/du/inacc-dest: New test, based on an example from Mike Frysinger.
865 * tests/chgrp/no-x: Remove the "fts_read failed: ..."
866 diagnostic from the expected output when using native fdopendir.
867 * tests/chmod/no-x: Likewise.
868 * tests/du/no-x: Likewise.
869 * NEWS: Mention this bug fix.
870 * tests/du/Makefile.am (TESTS): Add inacc-dest.
872 * Makefile.maint (sc_cast_of_x_alloc_return_value): Add an exclusion
875 Avoid false-positive when testing via valgrind.
876 * tests/mv/atomic: Grep strace output for a more specific pattern
877 than just "unlink", since that got a false positive when testing
878 under valgrind: unlink("/tmp/valgrind_proc_9657_cmdline_A51E9991") = 0
879 * tests/mv/Makefile.am (TESTS_ENVIRONMENT): Define EGREP.
881 2006-10-28 Jim Meyering <jim@meyering.net>
883 * Makefile.maint (patch-check): Make it easier to regenerate
884 the src/c99-to-c89.diff file. E.g., I do this:
885 make patch-check REGEN_PATCH=1; ediff src/c99-to-c89.diff new-diff
887 * src/c99-to-c89.diff: Update to reflect new offsets in rm.c.
889 2006-10-26 Jim Meyering <jim@meyering.net>
891 * src/system.h (ftello): Add a compile-time check for the highly
892 unlikely condition of off_t narrower than long int, rather than
893 handling it at run time. Based on a patch from Paul Eggert.
895 2006-10-25 Paul Eggert <eggert@cs.ucla.edu>
897 * tests/chmod/c-option: When double-quoting part of a word, prefer
898 to double-quote the whole word. This is a bit easier to read (at
899 least for me), and in some cases it avoids a shell bug with Tru64
900 4.0 sh reported by Nelson H. F. Beebe. For example, instead of
901 "$abs_srcdir"/../setgid-check we now write
902 "$abs_srcdir/../setgid-check".
903 * tests/cp/cp-parents: Likewise.
904 * tests/du/inaccessible-cwd: Likewise.
905 * tests/du/long-from-unreadable: Likewise.
906 * tests/install/basic-1: Likewise.
907 * tests/install/trap: Likewise.
908 * tests/misc/close-stdout: Likewise.
909 * tests/mkdir/concurrent-1: Likewise.
910 * tests/mkdir/p-1: Likewise.
911 * tests/mkdir/p-3: Likewise.
912 * tests/mkdir/parents: Likewise.
913 * tests/mkdir/perm: Likewise.
914 * tests/readlink/can-e: Likewise.
915 * tests/readlink/can-f: Likewise.
916 * tests/readlink/can-m: Likewise.
917 * tests/rm/inaccessible: Likewise.
918 * tests/rm/unread3: Likewise.
919 * tests/touch/no-create-missing: Likewise.
921 * lib/.cvsignore: Add uinttostr.c.
923 2006-10-25 Jim Meyering <jim@meyering.net>
925 Portability to Tru64 V4.0.
926 * src/system.h (ftello) [!HAVE_FSEEKO && !defined ftello]:
927 Define inline replacement function.
928 This (along with a yesterday's fix for autoconf's
929 _AC_SYS_LARGEFILE_MACRO_VALUE macro) makes it so coreutils
930 now builds once more on Tru64 V4.0. Reported by Nelson Beebe.
932 2006-10-25 Bruno Haible <bruno@clisp.org>
934 * src/cat.c (infile): Add "const" to declaration.
935 * src/csplit.c (prefix): Likewise.
936 * src/printf.c (cfcc_msg): Likewise.
937 * src/tail.c (valid_file_spec): Likewise.
938 * src/cut.c (cut_file): Likewise, for a parameter.
939 * src/expr.c (str_value): Likewise.
940 * src/fold.c (fold_file): Likewise.
941 * src/pr.c (init_header): Likewise.
942 * src/dircolors.c (dc_parse_stream): Likewise, for a local.
943 * src/tr.c (make_printable_str): Likewise.
944 * src/nl.c (body_type, header_type, footer_type, current_type):
945 (separator_str, build_type_arg, nl_file): Likewise, for many.
946 * src/paste.c (main): Don't assign a read-only string to 'optarg'.
947 * src/tac.c (separator, tac_seekable, copy_to_temp): Likewise.
949 2006-10-25 Jim Meyering <jim@meyering.net>
951 * tests/sample-test: Update copyright year list to include only
952 the current year, since this is what I'll want in any new test.
954 2006-10-24 Jim Meyering <jim@meyering.net>
956 * src/c99-to-c89.diff: Update to reflect new offsets.
958 * NEWS: new feature: rm accepts new option: --one-file-system
959 Suggested by Steve McIntyre in <http://bugs.debian.org/392925>.
960 * src/remove.h (struct rm_options) [one_file_system]: New member.
961 * src/rm.c (rm_option_init): Initialize it.
962 (usage): Document the option.
963 * src/mv.c (rm_option_init): Likewise.
964 * src/remove.c (remove_dir): With --one-file-system and --recursive,
965 for each directory command line argument, do not affect a file system
966 different from that of the starting directory. And give a diagnostic.
967 * src/rm.c (ONE_FILE_SYSTEM): New enum.
968 (main): Handle new option.
969 * tests/rm/one-file-system: Test the above.
970 * tests/rm/Makefile.am (TESTS): Add one-file-system.
971 * tests/Makefile.am (check-root): Add the rm/one-file-system
973 (EXTRA_DIST): Add other-fs-tmpdir.
975 * tests/mv/setup: Removed. Renamed to...
976 * tests/other-fs-tmpdir: ...this new file.
977 * tests/mv/Makefile.am (EXTRA_DIST): Remove setup.
978 * tests/mv/acl: Reflect renaming: use ../other-fs-tmpdir.
979 * tests/mv/backup-is-src: Likewise.
980 * tests/mv/hard-link-1: Likewise.
981 * tests/mv/leak-fd: Likewise.
982 * tests/mv/mv-special-1: Likewise.
983 * tests/mv/part-fail: Likewise.
984 * tests/mv/part-hardlink: Likewise.
985 * tests/mv/part-rename: Likewise.
986 * tests/mv/part-symlink: Likewise.
987 * tests/mv/partition-perm: Likewise.
988 * tests/mv/to-symlink: Likewise.
989 * tests/mv/into-self-2: Likewise.
991 Don't let a failure in one test stop "make -k" from running the others.
992 * tests/Makefile.am (t1 t2 t3 t4 t5): New targets.
993 (check-root): Depend on them, rather than executing the five
994 commands in a single rule. Reported by Greg Schafer.
996 2006-10-23 Bob Proulx <bob@proulx.com> (tiny change)
998 * Makefile.maint (alpha beta major): Use a better log message for
999 the automatic commit of .prev-version.
1001 2006-10-23 Jim Meyering <jim@meyering.net>
1003 * tests/misc/pwd-long: Undo last change, since it made Perl invoke
1004 pwd via a shell. Instead, ensure that the absolute name of the
1005 pwd binary consists solely of reasonable characters.
1006 Whoops. Don't exec the perl script. Otherwise, the sh-trap-based
1007 clean-up code isn't run.
1009 * NEWS: Add a line for 6.5-cvs.
1010 * configure.ac (AC_INIT): Bump to 6.5 and add "-cvs" suffix.
1012 2006-10-22 Jim Meyering <jim@meyering.net>
1016 * NEWS: Record the 6.4 release date.
1017 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
1019 * Makefile.maint: Complete the adaptation to function with a working
1020 directory that is using git (rather than cvs) for version control.
1022 2006-10-22 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
1024 * tests/chmod/c-option: Double-quote instances of `$abs_srcdir'.
1025 * tests/cp/cp-parents: Likewise.
1026 * tests/mkdir/parents: Likewise.
1027 * tests/mkdir/perm: Likewise.
1029 * tests/sample-test: Quote variables containing absolute build
1030 tree paths. In the cleanup trap, make sure `cd' succeeds before
1031 `chmod'ing and `rm'ing the temporary files.
1032 * tests/chgrp/basic: Likewise.
1033 * tests/chgrp/deref: Likewise.
1034 * tests/chgrp/no-x: Likewise.
1035 * tests/chgrp/posix-H: Likewise.
1036 * tests/chgrp/recurse: Likewise.
1037 * tests/chmod/c-option: Likewise.
1038 * tests/chmod/equal-x: Likewise.
1039 * tests/chmod/equals: Likewise.
1040 * tests/chmod/inaccessible: Likewise.
1041 * tests/chmod/no-x: Likewise.
1042 * tests/chmod/octal: Likewise.
1043 * tests/chmod/setgid: Likewise.
1044 * tests/chmod/umask-x: Likewise.
1045 * tests/chmod/usage: Likewise.
1046 * tests/chown/basic: Likewise.
1047 * tests/chown/deref: Likewise.
1048 * tests/chown/separator: Likewise.
1049 * tests/cp/acl: Likewise.
1050 * tests/cp/backup-1: Likewise.
1051 * tests/cp/backup-dir: Likewise.
1052 * tests/cp/backup-is-src: Likewise.
1053 * tests/cp/cp-HL: Likewise.
1054 * tests/cp/cp-deref: Likewise.
1055 * tests/cp/cp-i: Likewise.
1056 * tests/cp/cp-mv-backup: Likewise.
1057 * tests/cp/cp-parents: Likewise.
1058 * tests/cp/deref-slink: Likewise.
1059 * tests/cp/dir-rm-dest: Likewise.
1060 * tests/cp/dir-slash: Likewise.
1061 * tests/cp/dir-vs-file: Likewise.
1062 * tests/cp/fail-perm: Likewise.
1063 * tests/cp/into-self: Likewise.
1064 * tests/cp/link: Likewise.
1065 * tests/cp/link-no-deref: Likewise.
1066 * tests/cp/link-preserve: Likewise.
1067 * tests/cp/no-deref-link1: Likewise.
1068 * tests/cp/no-deref-link2: Likewise.
1069 * tests/cp/no-deref-link3: Likewise.
1070 * tests/cp/perm: Likewise.
1071 * tests/cp/preserve-2: Likewise.
1072 * tests/cp/r-vs-symlink: Likewise.
1073 * tests/cp/same-file: Likewise.
1074 * tests/cp/slink-2-slink: Likewise.
1075 * tests/cp/sparse: Likewise.
1076 * tests/cp/special-bits: Likewise.
1077 * tests/cp/src-base-dot: Likewise.
1078 * tests/cp/symlink-slash: Likewise.
1079 * tests/dd/not-rewound: Likewise.
1080 * tests/dd/skip-seek2: Likewise.
1081 * tests/dd/unblock-sync: Likewise.
1082 * tests/du/2g: Likewise.
1083 * tests/du/8gb: Likewise.
1084 * tests/du/basic: Likewise.
1085 * tests/du/deref: Likewise.
1086 * tests/du/deref-args: Likewise.
1087 * tests/du/exclude: Likewise.
1088 * tests/du/fd-leak: Likewise.
1089 * tests/du/hard-link: Likewise.
1090 * tests/du/inaccessible-cwd: Likewise.
1091 * tests/du/long-from-unreadable: Likewise.
1092 * tests/du/long-sloop: Likewise.
1093 * tests/du/no-deref: Likewise.
1094 * tests/du/no-x: Likewise.
1095 * tests/du/restore-wd: Likewise.
1096 * tests/du/slash: Likewise.
1097 * tests/du/slink: Likewise.
1098 * tests/du/trailing-slash: Likewise.
1099 * tests/du/two-args: Likewise.
1100 * tests/fmt/long-line: Likewise.
1101 * tests/install/basic-1: Likewise.
1102 * tests/install/create-leading: Likewise.
1103 * tests/install/d-slashdot: Likewise.
1104 * tests/install/trap: Likewise.
1105 * tests/ln/misc: Likewise.
1106 * tests/ln/target-1: Likewise.
1107 * tests/ls/color-dtype-dir: Likewise.
1108 * tests/ls/dangle: Likewise.
1109 * tests/ls/dired: Likewise.
1110 * tests/ls/file-type: Likewise.
1111 * tests/ls/follow-slink: Likewise.
1112 * tests/ls/infloop: Likewise.
1113 * tests/ls/inode: Likewise.
1114 * tests/ls/m-option: Likewise.
1115 * tests/ls/no-arg: Likewise.
1116 * tests/ls/recursive: Likewise.
1117 * tests/ls/rt-1: Likewise.
1118 * tests/ls/stat-dtype: Likewise.
1119 * tests/ls/stat-failed: Likewise.
1120 * tests/ls/stat-vs-dirent: Likewise.
1121 * tests/misc/cat-proc: Likewise.
1122 * tests/misc/close-stdout: Likewise.
1123 * tests/misc/csplit: Likewise.
1124 * tests/misc/date-sec: Likewise.
1125 * tests/misc/false-status: Likewise.
1126 * tests/misc/head-c: Likewise.
1127 * tests/misc/head-pos: Likewise.
1128 * tests/misc/mknod: Likewise.
1129 * tests/misc/nl: Likewise.
1130 * tests/misc/nohup: Likewise.
1131 * tests/misc/pathchk1: Likewise.
1132 * tests/misc/printf: Likewise.
1133 * tests/misc/printf-hex: Likewise.
1134 * tests/misc/pwd-long: Likewise.
1135 * tests/misc/shuf: Likewise.
1136 * tests/misc/sort-rand: Likewise.
1137 * tests/misc/split-a: Likewise.
1138 * tests/misc/split-fail: Likewise.
1139 * tests/misc/split-l: Likewise.
1140 * tests/misc/stat-fmt: Likewise.
1141 * tests/misc/tac-continue: Likewise.
1142 * tests/misc/wc-files0: Likewise.
1143 * tests/mkdir/concurrent-1: Likewise.
1144 * tests/mkdir/p-1: Likewise.
1145 * tests/mkdir/p-2: Likewise.
1146 * tests/mkdir/p-3: Likewise.
1147 * tests/mkdir/p-slashdot: Likewise.
1148 * tests/mkdir/p-thru-slink: Likewise.
1149 * tests/mkdir/p-v: Likewise.
1150 * tests/mkdir/parents: Likewise.
1151 * tests/mkdir/perm: Likewise.
1152 * tests/mkdir/t-slash: Likewise.
1153 * tests/mv/acl: Likewise.
1154 * tests/mv/atomic: Likewise.
1155 * tests/mv/backup-dir: Likewise.
1156 * tests/mv/childproof: Likewise.
1157 * tests/mv/diag: Likewise.
1158 * tests/mv/dir-file: Likewise.
1159 * tests/mv/dir2dir: Likewise.
1160 * tests/mv/dup-source: Likewise.
1161 * tests/mv/hard-2: Likewise.
1162 * tests/mv/hard-3: Likewise.
1163 * tests/mv/hard-4: Likewise.
1164 * tests/mv/hard-link-1: Likewise.
1165 * tests/mv/hard-verbose: Likewise.
1166 * tests/mv/i-2: Likewise.
1167 * tests/mv/i-3: Likewise.
1168 * tests/mv/i-4: Likewise.
1169 * tests/mv/i-5: Likewise.
1170 * tests/mv/i-link-no: Likewise.
1171 * tests/mv/into-self-4: Likewise.
1172 * tests/mv/leak-fd: Likewise.
1173 * tests/mv/mv-special-1: Likewise.
1174 * tests/mv/no-target-dir: Likewise.
1175 * tests/mv/part-fail: Likewise.
1176 * tests/mv/part-hardlink: Likewise.
1177 * tests/mv/part-rename: Likewise.
1178 * tests/mv/part-symlink: Likewise.
1179 * tests/mv/partition-perm: Likewise.
1180 * tests/mv/perm-1: Likewise.
1181 * tests/mv/reply-no: Likewise.
1182 * tests/mv/trailing-slash: Likewise.
1183 * tests/mv/update: Likewise.
1184 * tests/od/od-N: Likewise.
1185 * tests/od/x8: Likewise.
1186 * tests/readlink/can-e: Likewise.
1187 * tests/readlink/can-f: Likewise.
1188 * tests/readlink/can-m: Likewise.
1189 * tests/readlink/rl-1: Likewise.
1190 * tests/rm/cycle: Likewise.
1191 * tests/rm/dangling-symlink: Likewise.
1192 * tests/rm/deep-1: Likewise.
1193 * tests/rm/dir-no-w: Likewise.
1194 * tests/rm/dir-nonrecur: Likewise.
1195 * tests/rm/dot-rel: Likewise.
1196 * tests/rm/empty-inacc: Likewise.
1197 * tests/rm/f-1: Likewise.
1198 * tests/rm/fail-2eperm: Likewise.
1199 * tests/rm/hash: Likewise.
1200 * tests/rm/i-1: Likewise.
1201 * tests/rm/i-no-r: Likewise.
1202 * tests/rm/ignorable: Likewise.
1203 * tests/rm/inaccessible: Likewise.
1204 * tests/rm/interactive-always: Likewise.
1205 * tests/rm/interactive-once: Likewise.
1206 * tests/rm/ir-1: Likewise.
1207 * tests/rm/isatty: Likewise.
1208 * tests/rm/no-give-up: Likewise.
1209 * tests/rm/r-1: Likewise.
1210 * tests/rm/r-2: Likewise.
1211 * tests/rm/r-3: Likewise.
1212 * tests/rm/r-4: Likewise.
1213 * tests/rm/readdir-bug: Likewise.
1214 * tests/rm/rm1: Likewise.
1215 * tests/rm/rm2: Likewise.
1216 * tests/rm/rm3: Likewise.
1217 * tests/rm/rm4: Likewise.
1218 * tests/rm/rm5: Likewise.
1219 * tests/rm/sunos-1: Likewise.
1220 * tests/rm/unread2: Likewise.
1221 * tests/rm/unread3: Likewise.
1222 * tests/rmdir/fail-perm: Likewise.
1223 * tests/rmdir/t-slash: Likewise.
1224 * tests/shred/exact: Likewise.
1225 * tests/shred/remove: Likewise.
1226 * tests/sum/sysv: Likewise.
1227 * tests/tail-2/append-only: Likewise.
1228 * tests/tail-2/assert: Likewise.
1229 * tests/tail-2/assert-2: Likewise.
1230 * tests/tail-2/big-4gb: Likewise.
1231 * tests/tail-2/fflush: Likewise.
1232 * tests/tail-2/infloop-1: Likewise.
1233 * tests/tail-2/proc-ksyms: Likewise.
1234 * tests/tail-2/start-middle: Likewise.
1235 * tests/tail-2/tail-n0f: Likewise.
1236 * tests/tee/basic: Likewise.
1237 * tests/tee/dash: Likewise.
1238 * tests/touch/fail-diag: Likewise.
1239 * tests/touch/no-create-missing: Likewise.
1240 * tests/touch/not-owner: Likewise.
1241 * tests/touch/obsolescent: Likewise.
1242 * tests/touch/read-only: Likewise.
1243 * tests/touch/relative: Likewise.
1245 2006-10-21 Jim Meyering <jim@meyering.net>
1247 * NEWS: (cp --backup fix): Fix a typo.
1249 * .gitignore: Remove some references to files in subdirectories.
1250 * build-aux/.gitignore, doc/.gitignore, lib/.gitignore: New files.
1251 * m4/.gitignore, po/.gitignore, src/.gitignore: Likewise.
1253 * src/copy.c (copy_internal): Add a comment saying why we prefer
1256 Enable an fts optimization (call lstat only for directories,
1257 on some file system types) also with the --preserve-root option
1259 * src/chown-core.c (change_file_owner): Compare fts_statp-based
1260 dev/ino against root dev/ino only for directories.
1261 (chown_files): Don't let the root_dev_ino setting influence whether
1262 we use FTS_NOSTAT: fts always sets *fts_statp for a directory.
1264 2006-10-20 Jim Meyering <jim@meyering.net>
1266 * src/od.c (usage): Change description of default to use "-w16",
1267 not the now-invalid "-w 16" syntax. From Dan Jacobson.
1269 2006-10-19 Jim Meyering <jim@meyering.net>
1271 * bootstrap: Add names to each .gitignore file (if it exists)
1272 as well as to .cvsignore.
1274 * Makefile.maint (po-check): This rule didn't detect the new use
1275 of "gettext" (as opposed to the use of "_" everywhere else) in
1276 lib/xstrtol.h. Adjust the grep regexp so that now it does.
1278 2006-10-18 Paul Eggert <eggert@cs.ucla.edu>
1280 * src/copy.c (copy_reg): Rewrite slightly to avoid duplicate code
1281 when opening dst_name.
1282 (copy_reg, copy_internal): Use (SYSCALL != 0) rather than plain
1283 (SYSCALL) to test for failure in a system call.
1285 * src/copy.c (copy_internal): Use mknod rather than mkfifo to copy
1286 a fifo. This preserves the special mode bits on Solaris 10, which
1287 is compatible with what Solaris 10 cp -R does.
1289 * src/copy.c (copy_internal): Remove redundant and confusing local
1292 * src/copy.c (copy_internal): Don't pass mkdir a mode greater than
1293 7777. This matches historical 'cp' behavior and avoids some
1294 (though not all) implementation-defined behavior of mkdir.
1295 * src/cp.c (make_dir_parents_private): Likewise.
1296 * src/copy.c (copy_internal): Don't pass 'open' a mode greater
1297 than 777. This is required by POSIX. It doesn't make any difference
1298 in actual behavior on any host that I know of.
1300 2006-10-17 Jim Meyering <jim@meyering.net>
1302 * src/dd.c (usage): Use two spaces (not one) to separate the
1303 "fdatasync" option string from its description, so help2man formats
1304 the derived man page properly. Reported by Samuel Thibault
1305 in <http://bugs.debian.org/393649>.
1307 2006-10-16 Jim Meyering <jim@meyering.net>
1309 * .x-sc_trailing_blank: Remove names of files that are no longer
1312 2006-10-16 Paul Eggert <eggert@cs.ucla.edu>
1314 * src/groups.sh (version): Reword message to match the other programs.
1315 Problem reported by Eric Blake.
1317 2006-10-14 Jim Meyering <jim@meyering.net>
1319 * Makefile.maint (headers_with_interesting_macro_defs): Define.
1320 (.re-defmac, sc_always_defined_macros): New rules.
1322 * src/system.h (EXIT_FAILURE, EXIT_SUCCESS): Remove definitions.
1323 Instead, include "exit.h". This hereby retires the work-around for
1324 "Sony NEWS-OS Release 4.0C"'s bug due to "#define EXIT_FAILURE 0".
1326 * src/cksum.c (uint_fast32_t): Don't define.
1327 Instead, include <stdint.h>.
1329 * src/pinky.c (S_IWGRP): Don't define.
1330 It's already defined by "stat-macros.h" (included via system.h).
1332 * Makefile.cfg: Remove cruft that's now handled via bootstrap.
1333 * Makefile.maint: Likewise, remove these targets/rules/variables:
1334 (local_updates, update, cvs-update, wget_files, get-targets): Remove.
1335 (cvs_files, wget-update, automake_repo): Likewise.
1336 Move the comment about cvsu to build-aux/vc-list-files,
1337 where cvsu is actually used.
1339 * Makefile.maint (cvs-update): Use $(CVS), not "cvs".
1341 Work also when the working directory (with e.g. coreutils sources)
1342 is version controlled with git, rather than CVS.
1343 * bootstrap (CVS_only_file): Test for the existence of README-cvs,
1345 In messages and comments, say e.g., "checked-out sources",
1346 rather than "CVS sources".
1347 (version_controlled_file): New function. Work for git as well as
1348 for CVS. Don't use grep's -q option.
1349 (slurp): Call it here, in place of CVS-specific code.
1351 * NEWS: cp -r --backup dir1 dir2, would rename an existing dir1/dir2
1353 * src/copy.c (copy_internal): Although we do create a backup of each
1354 destination directory when in move mode, don't do that when copying.
1355 Reported by Peter Breitenlohner, in
1356 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/8616>.
1357 * tests/cp/backup-dir: New file. Test for the above.
1358 * tests/cp/Makefile.am (TESTS): Add backup-dir.
1360 2006-10-13 Jim Meyering <jim@meyering.net>
1362 More chown/chgrp dereferencing-related fixes.
1363 * src/chown-core.c (change_file_owner): Don't use fts_statp if
1364 we're dereferencing symlinks.
1365 Reverse conjuncts, so that we use dereference file_stats
1366 (aka ent->fts_statp) only *after* we've confirmed that
1367 chopt->affect_symlink_referent is true. Otherwise, we might
1368 use ent->fts_statp uninitialized.
1369 Don't turn on FTS_NOSTAT when dereferencing symlinks.
1370 * tests/chown/deref: Update the expected diagnostic, now that
1371 this test case (trying to use "chown --dereference ..." on a
1372 dangling symlink) takes a different code path.
1374 2006-10-13 Paul Eggert <eggert@cs.ucla.edu>
1376 Sync from Bison, as follows:
1378 2006-10-01 Paul Eggert <eggert@cs.ucla.edu>
1380 Fix problems with translating English-language diagnostics.
1381 * bootstrap: Fix bug introduced in recent bootstrap changes, with
1382 respect to bison-runtime pot generation. The YY_ stuff
1383 wasn't being captured.
1385 2006-10-13 Jim Meyering <jim@meyering.net>
1387 * src/chown-core.c (change_file_owner): Use fstatat, not stat,
1388 now that we're using fts_open with FTS_CWDFD.
1389 * tests/chgrp/posix-H: Add --preserve-root to an invocation of
1390 chgrp, to exercise the above fix.
1391 * NEWS: Mention the above.
1393 * src/du-tests: Clean up a little, though it's still not portable.
1395 * .vg-suppressions: Add 3 more for debian unstable.
1397 * tests/ls/Test.pm: Remove long-unused file.
1398 * Makefile.am (EXTRA_DIST): Add bootstrap.conf.
1399 Suggestions from Bruno Haible.
1401 2006-10-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
1403 * Makefile.am (THANKS-to-translators): Add missing $(srcdir).
1404 (MAINTAINERCLEANFILES): Add .kludge-stamp.
1405 * man/Makefile.am (MAINTAINERCLEANFILES): Typo $(dist_man_MANS)
1406 instead of $(man_MANS).
1408 2006-10-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
1410 * configure.ac: Avoid compiler warnings about default return
1411 type in function definitions and unused variables in tests.
1412 * src/who.c (print_user) [HAVE_UT_HOST]: hostlen is only needed
1413 if this is #defined.
1415 2006-10-12 Jim Meyering <jim@meyering.net>
1417 * configure.ac: Reflect s/gl_MACROS/coreutils_MACROS/ renaming.
1418 Call gl_INIT directly, rather than through the above.
1420 2006-10-11 Paul Eggert <eggert@cs.ucla.edu>
1422 * bootstrap (symlink_to_gnulib): Fix bug: the dot_dots shell
1423 variable was sometimes used without being initialized. This
1424 messed up the installation of the INSTALL file in some cases.
1426 2006-10-11 Jim Meyering <jim@meyering.net>
1428 * src/ls.c (usage): Correct description of -s, --size.
1429 It works even without -l. Suggestion from Karl Berry.
1431 2006-10-10 Paul Eggert <eggert@cs.ucla.edu>
1433 * src/ls.c (quote_name): Use initializer rather than memset to
1434 initialize an object to zero. This is easier to read and is less
1435 likely to introduce a runtime error due to a mixup. It causes
1436 gcc -W to issue a warning, but you can work around this by
1437 appending -Wno-missing-field-initializers.
1438 * src/pathchk.c (portable_chars_only): Likewise.
1439 * src/shred.c (main): Likewise.
1440 * src/stty.c (main): Likewise.
1441 * src/tr.c (card_of_complement): Likewise.
1442 * src/wc.c (wc): Likewise.
1444 2006-10-09 Paul Eggert <eggert@cs.ucla.edu>
1446 * src/sort.c (usage): Mention again that sort fields are origin 1.
1448 * NEWS: Fix typo: iso-8602 -> iso-8601. Problem reported by
1451 * bootstrap (usage, main program, symlink_to_gnulib): Add option
1452 --copy. Inspired by a suggestion from Bruno Haible.
1454 2006-10-09 Jim Meyering <jim@meyering.net>
1456 Avoid a compiler warning.
1457 * src/pathchk.c (portable_chars_only): Initialize variable of type
1458 mbstate_t via memset, rather than via '{0}'. Patch from Bruno Haible.
1460 2006-10-06 Paul Eggert <eggert@cs.ucla.edu>
1462 Fix bug reported today by Mike Frysinger: mkdir -pv is logging the
1463 wrong file name in some cases. Lars Wendler reported a bug in
1465 * src/install.c (make_ancestor): New arg COMPONENT.
1466 * src/mkdir.c (make_ancestor): Likewise.
1467 * tests/install/basic-1: Check for install -Dv bug.
1468 * tests/mkdir/Makefile.am (TESTS): Add p-v.
1469 * tests/mkdir/p-v: New file, to test this bug.
1471 2006-10-05 Paul Eggert <eggert@cs.ucla.edu>
1473 * src/chgrp.c: Don't include lchown.h; no longer needed.
1474 * src/chown.c: Likewise.
1476 * tests/ls/stat-dtype: Use a dynamic test to decide whether the
1477 current file system has useful d_type info.
1479 * src/dd.c (flags): noatime and nofollow now depend on
1480 HAVE_WORKING_O_NOATIME and HAVE_WORKING_O_NOFOLLOW, too.
1481 (usage): Output info about noatime and nofollow only if
1482 they are known to work.
1483 * src/remove.c (AD_push): Inspect HAVE_WORKING_O_NOFOLLOW rather
1484 than O_NOFOLLOW, when testing whether it's possible to avoid a
1485 race condition reliably.
1487 2006-10-05 Jim Meyering <jim@meyering.net>
1489 * src/c99-to-c89.diff: Update to reflect new offsets.
1491 * tests/install/basic-1: Skip the latter part of this test if the
1492 just-built dd binary is not readable. Otherwise, this test would fail
1493 when binaries were created as root. Reported by Bauke Jan Douma in
1494 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/8433>.
1496 2006-10-03 Paul Eggert <eggert@cs.ucla.edu>
1498 * src/system.h (ST_BLKSIZE): Ceiling at SIZE_MAX / 8 + 1, not at 4
1499 MiB, since XFS hosts can legitimately have large values of
1500 st_blksize. Problem reported by Tony Ernst in
1501 <http://savannah.gnu.org/bugs/?17903>.
1503 2006-10-04 Jim Meyering <jim@meyering.net>
1505 * src/remove.c (nonexistent_file_errno): Remove ENAMETOOLONG.
1506 Paul Eggert pointed out that the specified file may exist,
1507 in spite of such an errno value.
1508 * tests/rm/Makefile.am (TESTS): Remove ignore-name-too-long.
1509 * tests/rm/ignore-name-too-long: Remove file.
1510 * NEWS: Update here, too.
1512 2006-10-03 Jim Meyering <jim@meyering.net>
1514 * tests/rm/fail-eperm: Report failure also if rm is terminated by
1517 * src/c99-to-c89.diff: Convert two c99'isms -- one in remove.c
1518 and one in shred.c -- that were added before coreutils-6.3.
1519 Reported by Michael Deutschmann.
1521 * src/c99-to-c89.diff: Update to reflect new offsets.
1523 * src/remove.c (remove_entry): With -f, exit successfully in spite
1524 of a missing file under some very unusual conditions (with errno
1525 being any of ENOENT, ENOTDIR, ENAMETOOLONG).
1527 With --force (-f), rm no longer fails for ENOTDIR.
1528 * src/remove.c (ignorable_missing): New function.
1529 Use it everywhere, rather than open-coding the test.
1530 Andreas Schwab reported the ENOTDIR problem.
1531 (ignorable_missing): Similarly, don't fail for ENAMETOOLONG.
1533 * NEWS: Mention the bug fix.
1534 * tests/rm/ignorable: New file. Test for the ENOTDIR case.
1535 * tests/rm/ignore-name-too-long: New file. Test for ENAMETOOLONG.
1536 * tests/rm/Makefile.am (TESTS): Add the new file names.
1538 * bootstrap: Undo last change to this file, since now gnulib-tool
1539 sticks with the automake default in generating dependencies.
1541 * NEWS: Add a line for 6.4-cvs.
1542 * configure.ac (AC_INIT): Bump to 6.4 and add "-cvs" suffix.
1544 2006-09-30 Jim Meyering <jim@meyering.net>
1547 * NEWS: Record the 6.3 release date.
1548 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
1550 * NEWS: Mention Paul's Solaris 8 vs. 10 work-around.
1552 * src/c99-to-c89.diff: Update offsets.
1554 2006-09-29 Paul Eggert <eggert@cs.ucla.edu>
1556 * tests/rm/readdir-bug: Don't use $(...) in a shell script,
1557 as it doesn't work with Solaris /bin/sh.
1559 2006-09-29 Jim Meyering <jim@meyering.net>
1561 * NEWS: Mention Paul's fix (to gnulib's canon-host.c) for
1564 * tests/seq/basic [neg-2, eq-wid-2]: Comment out tests that
1565 use .1 as the increment. Actual output varies too much.
1566 [eq-wid-3]: New, commented out test.
1568 * src/shuf.c (read_input): Fix an off-by-one error that
1569 would cause an infloop for piped input of 8KB or more.
1570 * NEWS: Mention the fix.
1571 * tests/misc/shuf: Test for the above fix.
1573 Since any system may be affected by the Darwin readdir bug,
1574 perform the extra rewinddir unconditionally. The performance
1575 impact of rewinding a directory is negligible.
1576 * src/remove.c (NEED_REWIND): Define to use
1577 CONSECUTIVE_READDIR_UNLINK_THRESHOLD unconditionally.
1579 * tests/seq/basic: Use .11 as the upper bound, in case the ".1"
1580 increment translates to a slightly larger value.
1581 This corrects a test failure on FreeBSD 6.1 reported by Nelson Beebe.
1582 The final expected value wasn't being printed.
1584 Work around a readdir bug in Darwin 7.9.0 (MacOS X 10.3.9) on HFS+
1585 and NFS, whereby rm would not remove all files in a directory.
1586 * src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Reduce to 10.
1587 (NEED_REWIND): New macro, so that we incur the cost of the work-around
1588 rewinddir only on afflicted systems.
1589 * NEWS: Clarify and correct.
1590 * tests/rm/readdir-bug: New file. Test for the above fix.
1591 * tests/rm/Makefile.am (TESTS): Add it.
1592 Prompted by testing and analysis from Bruno Haible:
1593 http://lists.gnu.org/archive/html/bug-coreutils/2006-09/msg00326.html
1595 2006-09-28 Paul Eggert <eggert@cs.ucla.edu>
1597 * tests/rm/fail-eperm: Unset BASH_ENV, CDPATH, and ENV, too;
1598 suggested for Debian stable, which uses Perl 5.8.4.
1600 2006-09-28 Jim Meyering <jim@meyering.net>
1602 Automatically generated dependencies are important even
1603 when all of the sources in a directory come from gnulib.
1604 * bootstrap (gnulib_tool): Remove the "no-dependencies" automake
1605 option that gnulib-tool adds to what becomes our lib/gnulib.mk.
1607 * tests/rm/fail-eperm: Enable Perl's (-T) taint checking.
1608 Ensure that IFS is set properly and unset PATH.
1610 Work properly even when the name of the selected file starts with "-".
1611 Invoke rm via "../../src/rm", and adjust expected output.
1612 Prompted by a patch from Tim Waugh.
1614 * README-cvs: Add Bison to the list of required packages.
1616 2006-09-26 Jim Meyering <jim@meyering.net>
1618 * src/c99-to-c89.diff: Update offsets.
1620 * NEWS: rm works around a bug in Darwin 8.6.1 w/NFS that kept
1621 it from removing a directory containing 188 or more entries.
1622 * src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Decrease by
1623 20, go work around the buggy readdir on Darwin 8.6.1 with NFS.
1624 Reported by Matthew Woehlke.
1626 2006-09-26 Paul Eggert <eggert@cs.ucla.edu>
1628 * NEWS: "groups user" no longer outputs "user :"; you need at least
1629 two users. "groups" now processes options like --help more compatibly.
1630 * src/groups.sh: Implement the option-processing change.
1631 Handle user and group names with special characters more robustly.
1632 Report write errors instead of exiting silently with status 1.
1634 2006-09-26 Jim Meyering <jim@meyering.net>
1636 * README: Warn not to run autoreconf manually. Use bootstrap instead.
1638 * src/groups.sh: When invoked with 0 or 1 argument, just exec "id".
1639 Rewrite to avoid using temporary, $status.
1641 * NEWS: Mention the bug fix.
1642 * src/groups.sh: Don't hide a write failure.
1643 Reported by Iain Calder <ic56@rogers.com>.
1645 2006-09-25 Jim Meyering <jim@meyering.net>
1647 * src/chown.c (usage): Clarify --dereference description.
1648 * src/chgrp.c (usage): Likewise. Suggestion from Jamie McClelland.
1650 2006-09-24 Jim Meyering <jim@meyering.net>
1652 * NEWS: Mention these fixes.
1653 * src/copy.c (copy_reg): With --verbose (-v), print
1654 "removed `file_name'" just after unlinking a file.
1655 (copy_internal): Likewise, in three more places.
1656 Marc Lehman reported that "touch x; ln x y; mv -v x y" was silent.
1657 * tests/mv/hard-verbose: New file. Test for the above fix.
1658 * tests/mv/Makefile.am (TESTS): Add hard-verbose.
1660 * tests/help-version (sync_args): Don't call sync, since it spins up
1661 disks that I've deliberately caused to spin down (but not unmounted).
1663 * NEWS: Mention the improvement to sort.
1665 * tests/tail-2/proc-ksyms: Require that /proc/ksyms be readable
1666 as well as existing.
1668 * tests/ls/stat-dtype: Don't use tmpfs on linux-2.4 or older,
1669 since that predated addition of d_type support.
1671 2006-09-23 Jim Meyering <jim@meyering.net>
1673 * gl/modules/getloadavg.diff: New file. Work around the way the latest
1674 version of the getloadavg module interacts with our bootstrap script.
1675 * bootstrap (gnulib_tool_options): Add "--local-dir gl".
1676 * Makefile.am (EXTRA_DIST): Sort file names.
1677 Add bootstrap and gl/modules/getloadavg.diff
1679 2006-09-20 Paul Eggert <eggert@cs.ucla.edu>
1681 * bootstrap: Add support for --force.
1682 (usage): New function. Describe usage less tersely.
1683 (CVS_only_file): New var.
1685 * NEWS: Document fix for cp -i and mv -i.
1686 * src/copy.c (copy_internal): With -i, prompt even if the source
1687 is a directory and the destination is not. This is required by
1688 POSIX and gives the user a chance to bail out before failing.
1689 * tests/cp/Makefile.am (TESTS): Add cp-i.
1690 * tests/cp/cp-i: New file.
1691 * tests/mv/Makefile.am (TESTS): Add i-5.
1692 * tests/mv/i-5: New file.
1694 2006-09-20 Jim Meyering <jim@meyering.net>
1696 * NEWS: Mention the chmod bug fix.
1698 * tests/chmod/inaccessible: New test, specifically for this bug.
1699 Based on a test case from Paul Eggert.
1700 * tests/chmod/Makefile.am (TESTS): Add inaccessible.
1702 Fix the 2006-09-18 bug differently.
1703 * src/chmod.c: (process_file): Upon FTS_NS for a top-level file,
1704 tell fts_read to stat the file again, in case it has become
1705 accessible since the initial fts_open call.
1706 * src/chown-core.c (change_file_owner): Likewise.
1708 * src/chmod.c: Revert last change. There is a better way.
1709 * src/chown-core.c: Likewise.
1711 2006-09-19 Paul Eggert <eggert@cs.ucla.edu>
1713 * src/ln.c (target_directory_operand): Rewrite to avoid porting
1714 problem on Tandem reported by Matthew Woehlke in
1715 <https://savannah.gnu.org/bugs/?17172>.
1717 2006-09-18 Paul Eggert <eggert@cs.ucla.edu>
1719 Fix bug where chmod, chown, and chgrp did not process operands
1720 left-to-right in some cases.
1721 * src/chmod.c (wd_errno): New var.
1722 (chmod_file): New function, with most of the contents of the
1723 old prcess_file function.
1724 (process_files): Use it. This gives file names to fts one
1725 at a time, so that they are processed left-to-right as POSIX
1727 * src/chown-core.c (wd_errno, chown_files): Likewise.
1728 (chown_file): New function.
1729 * tests/install/basic-1: Redo test so as to not workaround
1730 the chmod bug, thereby testing for it.
1732 * src/shuf.c (main): Quote the entire range when reporting an
1733 invalid one, rather than just the part that contained the error.
1735 * tests/stty/row-col-1: Rewrite to avoid temporary file that is
1736 sometimes left behind if the test is skipped or interrupted.
1738 * bootstrap (symlink_to_gnulib): New function.
1739 (cp_mark_as_generated): Use it, to prefer symlinks-to-gnulib
1740 to copies-of-gnulib.
1741 (cp_mark_as_generated, slurp, gnulib_files):
1742 Avoid making a copy if it's the same as the old version.
1743 (gnulib_files): Add support for this variable (used by Bison).
1745 * tests/ls/stat-vs-dirent: Fix quoting problem in diagnostic
1746 indicating flaw in kernel. Reword to say that the flaw isn't
1747 serious for coreutils, since the flaw does affect ls -i.
1749 * tests/chgrp/basic: Fix bug in test case exposed by building on
1750 Solaris 8 in a setgid directory. The test case incorrectly
1751 assumed that 'symlink' would be in group $g1.
1753 2006-09-18 Jim Meyering <jim@meyering.net>
1755 * NEWS: Add a line for 6.3-cvs.
1756 * configure.ac (AC_INIT): Bump to 6.3 and add "-cvs" suffix.
1759 * NEWS: Record the 6.2 release date.
1760 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
1762 2006-09-17 Jim Meyering <jim@meyering.net>
1764 * tests/chgrp/basic: On an OpenBSD system, rather than failing
1765 due to a known problem, merely warn about it.
1766 Rewrite to avoid testing output of chgrp --verbose and chgrp -c.
1767 Instead, use stat to test file system for desired results, directly.
1768 * tests/chgrp/Makefile.am (TESTS_ENVIRONMENT): Set host_triplet.
1770 * tests/envvar-check: Add more variable names to the list of those
1771 that can affect these programs and tests: _POSIX2_VERSION, COLUMNS,
1772 QUOTING_STYLE, TABSIZE, TERM, TMPDIR.
1774 2006-09-16 Paul Eggert <eggert@cs.ucla.edu>
1776 * NEWS: Document that mkdir -p and install -d now fork on occasion.
1777 * bootstrap.conf (gnulib_modules): Add savewd.
1778 * src/install.c: Include savewd.h.
1779 (process_dir): New function.
1780 (main, install_file_in_file_parents): Use it, along with the new
1781 savewd module, to avoid some race conditions.
1782 * src/mkdir.c: Include savewd.h.
1783 (struct mkdir_options): New members make_ancestor_function, mode,
1785 (make_ancestor): Return 1 if the resulting directory is not readable.
1786 (process_dir): New function.
1787 (main): Use it, along with new savewd module, to avoid some
1788 race conditions. Fill in new slots of struct mkdir_options, so
1789 that callees get the values.
1790 * tests/install/basic-1: Test for coreutils 5.97 bug that was
1791 fixed in coreutils 6.0, and which should still be fixed with
1793 * tests/mkdir/p-3: Likewise.
1795 2006-09-15 Jim Meyering <jim@meyering.net>
1797 * bootstrap.conf (gnulib_modules): Add rename-dest-slash.
1798 The 2006-09-08 changes made it so "mv dir new-name/" would
1799 fail on NetBSD 1.6. This makes it work once again.
1801 2006-09-14 Jim Meyering <jim@meyering.net>
1803 * src/mv.c (main): Remove unnecessary (always-true) test for 2 <= n.
1804 Instead, since it's a little fragile, assert the condition.
1805 (target_directory_operand): Update comment to reflect latest change.
1807 2006-09-12 Paul Eggert <eggert@cs.ucla.edu>
1809 * src/who.c (print_user): Rewrite to avoid warning from
1810 GCC 4.1.1 with -Wall.
1812 2006-09-12 Jim Meyering <jim@meyering.net>
1814 * tests/mv/atomic: Check for specific strace output, rather than
1815 simply nonempty. RHEL AS 4 would fail this test due to strace
1816 generating "[ Process PID=14434 runs in 32 bit mode. ]".
1817 Reported by Nelson Beebe.
1819 2006-09-11 Jim Meyering <jim@meyering.net>
1821 * src/remove.c (remove_dir): Move new cache_stat_init call onto
1823 (rm_1): Move declaration of "st" and new cache_stat_init call
1824 "down" to nearer where they're used.
1825 * src/c99-to-c89.diff: Add another set of curly braces.
1827 2006-09-10 Paul Eggert <eggert@cs.ucla.edu>
1829 * src/expr.c (eval6): Fix buffer overrun, or bad performance, if
1830 substr's last operand is very large. Performance problem reported
1833 2006-09-09 Jim Meyering <jim@meyering.net>
1835 * Makefile.maint (sc_prohibit_jm_in_m4): Don't hang when there
1837 (sc_require_config_h): Skip this test if there are no version-
1838 controlled .c files.
1839 (sc_prohibit_assert_without_use): Likewise.
1841 2006-09-08 Jim Meyering <jim@meyering.net>
1843 * bootstrap: Export CVS_RSH separate from its assignment, to work
1844 even with Solaris 10's /bin/sh. Suggestion from Mark D. Baushke.
1846 2006-09-08 Paul Eggert <eggert@cs.ucla.edu>
1848 * NEWS: tail now ignores the -f option if POSIXLY_CORRECT is set,
1849 no file operand is given, and standard input is any FIFO.
1850 This is in response to Open Group XCU ERN 114.
1851 * src/tail.c (main): Likewise.
1853 2006-09-08 Jim Meyering <jim@meyering.net>
1855 mv and "cp -r" no longer fail when invoked with two arguments
1856 where the first one names a directory and the second name ends in
1857 a slash and doesn't exist. E.g., "mv dir B/", for nonexistent B,
1858 now succeeds, once more. This reverts part of the 2004-06-27
1860 * NEWS: Say the above.
1861 * src/mv.c (target_directory_operand): Don't require (here)
1862 that the target operand "look like" a directory. This change
1863 pushes the test down to the rename syscall level, where a
1864 "mv dir existing-non-dir/" will mistakenly succeed on older systems
1865 that ignore trailing slashes in the rename destination argument.
1866 * src/cp.c (target_directory_operand): Likewise, but for cp.
1867 * tests/mv/trailing-slash: Exercise the above fixes.
1868 * tests/cp/trailing-slash: New file.
1869 * tests/cp/Makefile.am (EXTRA_DIST): Add trailing-slash.
1871 * bootstrap: Use the previously unused variable, $src,
1872 to avoid repeating "$GNULIB_SRCDIR/$file".
1874 * bootstrap (cp_mark_as_generated): Don't use "local", to
1875 accommodate ancient "/bin/sh". Suggested by Ralf Wildenhues.
1876 Rename now-global "$src" and "$dst" to have cp_ prefix.
1877 Safer, and avoids confusion.
1879 * bootstrap (cp_mark_as_generated): New function.
1880 (slurp): Use it to prepend editor hints and a warning that
1881 the file we're copying is generated.
1882 Suggestion from Bruce Korb.
1883 (cp_mark_as_generated): Don't add C-style comments for .l or .y files.
1884 Fix last-minute typo.
1886 2006-09-07 Jim Meyering <jim@meyering.net>
1888 * bootstrap: Revert last change. There are less disruptive ways
1889 to mark these generated files as read-only.
1891 * src/c99-to-c89.diff: Update to have proper offsets.
1893 2006-09-06 Jim Meyering <jim@meyering.net>
1895 Ensure that some gnulib-tool-generated files are read-only.
1896 * bootstrap (slurp): Put the body of this function in a sub-shell,
1897 with "umask a-w" so that all new files are read-only. Remove each
1898 file before we write to it, in case it's read-only.
1899 Make po/Makevars and runtime-po/Makevars read-only, too.
1901 2006-09-05 Jim Meyering <jim@meyering.net>
1903 * tests/cp/acl: Skip this test when cp lacks ACL support.
1904 * tests/cp/Makefile.am (TESTS_ENVIRONMENT): Set $(CONFIG_HEADER).
1906 * src/c99-to-c89.diff (remove.c): Adapt one hunk to match the new
1907 context from change of 2006-09-02.
1909 2006-09-04 Jim Meyering <jim@meyering.net>
1911 * README-cvs: Fix typo in update command.
1913 2006-09-03 Jim Meyering <jim@meyering.net>
1915 * NEWS: Tweak the wording in the new change description so that
1916 no one can think this change causes e.g., `rm -fr foo../' to fail.
1918 * tests/rm/inaccessible: Adjust for movement of config.h to lib/.
1919 Use $CONFIG_HEADER, rather than hard-coding it.
1920 * tests/rm/Makefile.am (TESTS_ENVIRONMENT): Set $CONFIG_HEADER.
1922 2006-09-02 Paul Eggert <eggert@cs.ucla.edu>
1924 * NEWS: rm now rejects attempts to remove /, ./, and ../.
1925 * src/basename.c: Don't include dirname.h, since system.h does it now.
1926 * src/chmod.c: Likewise.
1927 * src/copy.c: Likewise.
1928 * src/cp.c: Likewise.
1929 * src/df.c: Likewise.
1930 * src/dircolors.c: Likewise.
1931 * src/dirname.c: Likewise.
1932 * src/du.c: Likewise.
1933 * src/install.c: Likewise.
1934 * src/ln.c: Likewise.
1935 * src/ls.c: Likewise.
1936 * src/mkdir.c: Likewise.
1937 * src/mv.c: Likewise.
1938 * src/remove.c: Likewise.
1939 * src/rm.c: Likewise.
1940 * src/rmdir.c: Likewise.
1941 * src/shred.c: Likewise.
1942 * src/split.c: Likewise.
1943 * src/su.c: Likewise.
1944 * src/system.h: Include "dirname.h", since dot_or_dotdot needs it
1946 (dot_or_dotdot): Succeed even if "." or ".." is followed by a
1948 * src/rm.c (usage, main): --preserve-root is now the default.
1949 * src/remove.h: Fix comment.
1950 * src/remove.c (cache_fstatat, cache_stat_init): New functions.
1951 (cache_statted, cache_stat_ok): New functions.
1952 (write_protected_non_symlink): Remove struct stat ** buf_p arg,
1953 which is no longer needed with the new functions. All callers
1955 (prompt, is_dir_lstat, remove_entry, remove_dir):
1956 New struct stat * arg. All callers changed.
1957 (write_protected_non_symlink, prompt, is_dir_lstat, remove_entry):
1958 (remove_cwd_entries, remove_dir, rm_1):
1959 Use and maintain the file status cache.
1960 (prompt, remove_entry): Omit the first "directory" in the diagnostic
1961 "Cannot remove directory `foo': is a directory". This causes "rm"
1962 to pass a test case that it would otherwise fail now that it
1963 "knows" more about its argument. I think the diagnostic is better
1964 without the first "directory" anyway.
1965 (prompt): Remove the no-longer-needed IS_DIR arg; all callers changed.
1966 (rm_1): Reject attempts to remove /, ./, or ../.
1967 * tests/rm/Makefile.am (TESTS): Add r-4.
1968 * tests/rm/r-4: New file.
1970 2006-09-01 Paul Eggert <eggert@cs.ucla.edu>
1972 * src/stat.c: Include <stddef.h>
1973 (alignof): New macro.
1974 (HAVE_STRUCT_STATXFS_F_FSID___VAL, HAVE_STRUCT_STATXFS_F_FSID_VAL):
1976 (STRUCT_STATXFS_F_FSID_IS_INTEGER): New macro.
1978 (print_statfs): If f_fsid isn't an integer, grab its words one
1979 at a time in little-endian order. This is a bit easier to configure
1980 and should avoid a compilation failure on MacOS reported by Bruno
1983 2006-08-29 Paul Eggert <eggert@cs.ucla.edu>
1985 * src/stat.c (HAVE_STRUCT_STATXFS_F_FSID_VAL, FSID_VAL): New macros, to
1986 work around a Mac OS X porting problem reported by Bruno Haible in
1987 <http://lists.gnu.org/archive/html/bug-coreutils/2006-08/msg00308.html>.
1988 (print_statfs): Use them.
1990 * bootstrap.conf (gnulib_modules): Add isapipe.
1991 * src/tail.c: Include isapipe.h.
1992 (IS_PIPE_LIKE_FILE_TYPE): Remove.
1993 (IS_TAILABLE_FILE_TYPE): Just list both FIFOs and sockets as
1994 tailable, since this seems to be portable.
1995 (main): Use isapipe, to fix a bug on MacOS X reported by Bruno Haible in
1996 <http://lists.gnu.org/archive/html/bug-coreutils/2006-08/msg00304.html>.
1998 * src/system.h (LOCALEDIR): Remove, since configmake.h now defines
2001 2006-08-28 Paul Eggert <eggert@cs.ucla.edu>
2003 * src/copy.c (copy_internal): Don't test whether macros like
2004 S_ISLNK are defined, since they're always defined now.
2005 * src/cp.c (main): Likewise.
2006 * src/ln.c (main): Likewise.
2007 * src/ls.c (get_link_name, make_link_name): Likewise.
2008 * src/mknod.c (main): Likewise.
2009 * src/mkfifo.c (usage): Likewise.
2010 * src/who.c (S_IWGRP): Likewise.
2012 Adjust to recent gnulib changes for the gnulib module.
2013 * bootstrap.conf (gnulib_modules): Add fcntl.
2014 * src/system.h (SEEK_SET, SEEK_CUR, SEEK_END): Remove. Other code
2015 is already assuming these macros are defined.
2016 (O_DIRECT, O_DIRECTORY, O_DSYNC, O_NDELAY, O_NOATIME, O_NONBLOCK):
2017 (O_NOCTTY, O_NOFOLLOW, O_NOLINKS, O_RSYNC, O_SYNC, O_BINARY, O_TEXT):
2018 Remove; the fcntl module now handles these.
2020 Adjust to recent gnulib changes for the inttypes module.
2021 * bootstrap.conf (gnulib_modules): Remove stdint; add inttypes.
2022 (excluded_files): Don't exclude m4/inttypes-h.m4 or m4/inttypes-pri.m4.
2024 * src/system.h: Don't bother to include <stdint.h>, since we can
2025 now assume inttypes.h does the equivalent of including stdint.h.
2027 2006-08-27 Jim Meyering <jim@meyering.net>
2029 * src/copy.c (copy_internal): Don't make a backup if the last
2030 component of the source name is "." or "..".
2031 Reported by Andreas Schwab in http://savannah.gnu.org/bugs/?17540.
2032 * NEWS: Mention this.
2033 * tests/cp/src-base-dot: New file. Test for the above fix.
2034 * tests/cp/Makefile.am (TESTS): Add src-base-dot.
2036 * src/system.h (DOT_OR_DOTDOT): Remove macro. Rewrite as a...
2037 (dot_or_dotdot): ...new static inline function.
2038 * src/remove.c (rm_1): Reflect this renaming.
2039 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
2041 * src/copy.c (copy_internal): Add comments.
2043 2006-08-26 Paul Eggert <eggert@cs.ucla.edu>
2045 * src/Makefile.am (AM_CPPFLAGS): Remove -I$(srcdir) and -I../lib,
2046 since Automake supplies them for us. It always did -I$(srcdir),
2047 and with the recent change to AC_CONFIG_HEADERS in configure.ac it
2048 is now also doing -I../lib.
2050 * bootstrap (get_translations): Skip this if WGET_COMMAND is empty.
2051 Fail if the first "echo" fails. Suppress diagnostics from "ls po/*.po"
2052 since there might not be any .po files.
2053 (WGET_COMMAND): Set to empty if wget doesn't
2054 seem to be available.
2056 2006-08-26 Jim Meyering <jim@meyering.net>
2058 This test was failing in some environments.
2059 * tests/ls/color-dtype-dir: Don't rely on eval "`dircolors -b`"
2060 to set LS_COLORS in the environment.
2061 * tests/envvar-check: Instead, ensure that LS_COLORS is not set.
2062 Reported by Bob Proulx.
2064 * src/c99-to-c89.diff: Remove hunk for copy.c; no longer needed.
2066 * Makefile.am (EXTRA_DIST): Remove these files here, too:
2067 .x-sc_no_if_have_config_h, .x-sc_prohibit_assert_without_use,
2068 .x-sc_two_space_separator_in_usage.
2070 Fix "mv --verbose --backup" so its output includes the
2071 " (backup: foo.~1~)" suffix also when backing up a directory.
2072 * NEWS: Report this bug fix.
2073 * src/copy.c (emit_verbose): New function, factored out of...
2074 (copy_internal): ...here. Use the new function.
2075 * tests/mv/backup-dir: Test for the above fix.
2076 * tests/mv/Makefile.am (TESTS): Add backup-dir.
2078 2006-08-25 Paul Eggert <eggert@cs.ucla.edu>
2080 * .x-sc_no_if_have_config_h: Remove; no longer needed.
2081 * .x-sc_prohibit_assert_without_use: Remove; it was empty.
2082 * .x-sc_two_space_separator_in_usage: Likewise.
2083 * Makefile.maint (sc_no_have_config_h): Renamed from
2084 sc_no_if_have_config_h, since it now checks that HAVE_CONFIG_H
2085 is absent everywhere.
2086 * bootstrap.conf (gnulib_modules): Add config-h.
2087 * src/shred.c: Include <config.h> unconditionally, since
2088 we now assume config.h exists.
2089 * src/dircolors.c: Likewise.
2091 2006-08-26 Jim Meyering <jim@meyering.net>
2093 "ls --color" would highlight other-writable and sticky directories
2094 no differently than regular directories on a file system with
2095 dirent.d_type support.
2096 * NEWS: Say the above.
2097 * src/ls.c (gobble_file): With --color, also stat the file when
2098 we know it is a directory.
2099 Derived from an anonymous one-line fix and bug report:
2100 <http://savannah.gnu.org/bugs/?15043>.
2101 * tests/ls/color-dtype-dir: New file. Test for the above fix.
2102 * tests/ls/Makefile.am (TESTS): Add color-dtype-dir.
2104 2006-08-25 Paul Eggert <eggert@cs.ucla.edu>
2106 * .cvsignore: Remove stamp-h1. Add coreutils-*, to ignore
2108 * bootstrap.conf: Add configmake, verify.
2109 * src/.cvsignore: Remove localedir.h.
2110 * src/Makefile.am (localedir, DISTCLEANFILES, localedir.h): Remove;
2111 subsumed by configmake.
2112 * src/system.h: Include configmake.h rather than localedir.h
2113 (LOCALEDIR): New macro.
2115 Rewrite to avoid some unnecessary casts, macros, literals.
2116 * src/shred.c (DEFAULT_PASSES, VERBOSE_UPDATE): Now constants,
2118 (SECTOR_SIZE, SECTOR_MASK): New constants.
2119 (fillpattern, dopass, do_wipefd, main): Remove unnecessary casts,
2120 and use the SECTOR_* constants when applicable. Check for size <
2121 0 rather than size == -1, since negative-size files are a sign of
2124 2006-08-25 Bruno Haible <bruno@clisp.org>
2126 * src/shred.c (dopass): Assume a continuable error if EIO even
2127 if the current position is not a multiple of 512.
2129 2006-08-24 Jim Meyering <jim@meyering.net>
2131 * src/stat.c (print_statfs): Fix typo: remove extra "sizeof".
2133 2006-08-23 Paul Eggert <eggert@cs.ucla.edu>
2135 * src/stat.c (HAVE_STRUCT_STATXFS_F_FSID___VAL): Define. This
2136 macro was being used without being defined.
2137 (SB_F_NAMEMAX): Remove cast.
2138 (f_fsid) [BeOS]: Likewise.
2139 (OUT_NAMEMAX): Renamed from NAMEMAX_FORMAT, with a new meaning.
2141 (out_string, out_int, out_uint, out_uint_o, out_uint_x): New
2143 (xstrcat): Remove. All uses changed to use the above functions.
2144 (print_statfs, print_stat): 2nd arg is now the prefix len, not the
2145 buffer len. All uses changed. Output '?', not '*', for unknown
2146 data or errors. Do not assume signed values can be interchanged
2147 with unsigned when printing.
2148 (print_statfs): For %i, print the fsid as a single int, not as a
2150 (print_it): Quote invalid format better.
2152 * NEWS: printf supports the I flag.
2153 * src/printf.c (print_formatted) [glibc 2.2 or later]: Likewise.
2155 2006-08-23 Bruno Haible <bruno@clisp.org>
2157 * src/stat.c (STRUCT_STATVFS, statfs, f_fsid, f_blocks, f_bfree) [BeOS]:
2158 (f_bavail, f_bsize, STATFS_FRSIZE, f_files, f_ffree) [BeOS]:
2159 (STATXFS_FILE_SYSTEM_TYPE_MEMBER_NAME) [BeOS]: Define.
2161 * src/ls.c (SA_RESTART): Fallback define.
2163 2006-08-23 Paul Eggert <eggert@cs.ucla.edu>
2165 * src/system.h (EDQUOT): Define if not already defined.
2166 Problem reported by Bruno Haible for BeOS.
2168 * .cvsignore: Remove config.h, config.hin, as they are now
2170 * configure.ac (AC_CONFIG_HEADERS): Move config.h and config.hin
2172 * src/Makefile.am (AM_CPPFLAGS): Remove '-I..'; no longer needed.
2174 * bootstrap (slurp): Define gl_LOCK_EARLY instead of gl_LOCK,
2175 to accommodate today's gnulib change.
2177 2006-08-23 Jim Meyering <jim@meyering.net>
2179 * NEWS: Mention the sweeping infrastructure changes.
2181 2006-08-22 Paul Eggert <eggert@cs.ucla.edu>
2183 * bootstrap.conf (gnulib_modules): Add gnupload.
2184 * Makefile.maint (emit_upload_commands): gnupload is now
2186 * gnupload: Remove from CVS, since it's now a gnulib module.
2188 * bootstrap (bootstrap_conf_cleanup): Remove.
2189 (excluded_files): New var.
2190 * bootstrap.conf: Likewise.
2191 * bootstrap (slurp): Exclude files early if they're in the
2192 excluded_files list. That way, their names don't get put into
2195 * aclocal.m4, config.hin, configure:
2196 Remove from CVS, since ./bootstrap generates them automatically.
2197 * .cvsignore: Add INSTALL, Makefile.in, aclocal.m4, config.hin,
2198 configure, *.cache, *.lineno, *.log.
2199 Remove more-specific entries. This catches files like configure.lineno.
2200 * man/.cvsignore: Add Makefile.in.
2201 * src/.cvsignore: Add Makefile.in.
2202 Remove .version, dir.c, install, mvdir, stamp-v, vdir.c, version.c.
2205 * tests/chgrp/.cvsignore:
2206 * tests/chmod/.cvsignore:
2207 * tests/chown/.cvsignore:
2208 * tests/cp/.cvsignore:
2209 * tests/cut/.cvsignore:
2210 * tests/dd/.cvsignore:
2211 * tests/dircolors/.cvsignore:
2212 * tests/du/.cvsignore:
2213 * tests/expr/.cvsignore:
2214 * tests/factor/.cvsignore:
2215 * tests/fmt/.cvsignore:
2216 * tests/head/.cvsignore:
2217 * tests/install/.cvsignore:
2218 * tests/join/.cvsignore:
2219 * tests/ln/.cvsignore:
2220 * tests/ls/.cvsignore:
2221 * tests/ls-2/.cvsignore:
2222 * tests/md5sum/.cvsignore:
2223 * tests/misc/.cvsignore:
2224 * tests/mkdir/.cvsignore:
2225 * tests/mv/.cvsignore:
2226 * tests/od/.cvsignore:
2227 * tests/pr/.cvsignore:
2228 * tests/readlink/.cvsignore:
2229 * tests/rm/.cvsignore:
2230 * tests/rmdir/.cvsignore:
2231 * tests/seq/.cvsignore:
2232 * tests/sha1sum/.cvsignore:
2233 * tests/shred/.cvsignore:
2234 * tests/sort/.cvsignore:
2235 * tests/stty/.cvsignore:
2236 * tests/sum/.cvsignore:
2237 * tests/tac/.cvsignore:
2238 * tests/tail/.cvsignore:
2239 * tests/tail-2/.cvsignore:
2240 * tests/tee/.cvsignore:
2241 * tests/test/.cvsignore:
2242 * tests/touch/.cvsignore:
2243 * tests/tr/.cvsignore:
2244 * tests/tsort/.cvsignore:
2245 * tests/unexpand/.cvsignore:
2246 * tests/uniq/.cvsignore:
2247 * tests/wc/.cvsignore:
2248 Add Makefile.in. Sort entries if necessary. Remove *.I, *.E,
2249 *.X, *.O, *-tests, build-script, mk-script if they're never
2250 created in this directory.
2252 2006-08-22 Bruno Haible <bruno@clisp.org>
2255 * src/uptime.c: Include OS.h if it exists.
2256 (print_uptime): On BeOS, use the get_system_info function (actually a
2257 macro). Loop through utmp entries only if utmp.h or utmpx.h exists.
2258 (uptime): Call read_utmp only if utmp.h or utmpx.h exists.
2260 2006-08-22 Jim Meyering <jim@meyering.net>
2262 * .cvsignore: Add ABOUT-NLS.
2264 Move the check-AUTHORS rule to be run as part of "make distcheck",
2265 rather than "make check".
2266 * src/Makefile.am (check): Don't depend on check-AUTHORS; it would
2267 cause "make check" to fail on systems unable to build all binaries.
2268 * Makefile.maint (check-AUTHORS): New rule.
2269 (local-checks-available): Add it here.
2270 Reported by Bruno Haible. Needed for BeOS.
2272 2006-08-21 Paul Eggert <eggert@cs.ucla.edu>
2274 * src/df.c (print_header, show_dev): Use a column width that
2275 depends on the block size of -P is specified and not autoscaling.
2276 Problem reported by Gustavo G. Rondina in:
2277 http://lists.gnu.org/archive/html/bug-coreutils/2006-08/msg00164.html
2279 2006-08-21 Jim Meyering <jim@meyering.net>
2281 * tests/dircolors/simple (a): Don't fail with an unexpected diagnostic
2282 when the shell variable, SHELL, is not set.
2283 Trigger the failure with "(unset SHELL; make check TESTS=simple)".
2284 Reported by Sven Joachim in <http://bugs.debian.org/355368>.
2286 * src/od.c: Now that HAVE_UNSIGNED_LONG_LONG is no longer defined
2287 in config.h, change the uses to HAVE_UNSIGNED_LONG_LONG_INT.
2288 Otherwise, on a system with 4-byte longs, "od -t u8" fails with this:
2289 od: invalid type string `u8';
2290 this system doesn't provide a 8-byte integral type
2291 FIXME: add a test for this, but skip it when sizeof uintmax < 8.
2293 2006-08-20 Paul Eggert <eggert@cs.ucla.edu>
2295 Add a bootstrap procedure, so that the CVS version contains fewer
2296 files and we bootstrap the rest from gnulib, gettext, etc.
2297 * README-cvs: New file.
2298 * bootstrap: New file.
2299 * bootstrap.conf: New file.
2300 * .x-sc_trailing_blank: Remove config-log, .gdb-history. Add .po.
2301 * configure.ac (AC_PREREQ): Move here from m4/*.m4, for benefit
2303 (gl_DEFAULT_POSIX2_VERSION, gl_USE_SYSTEM_EXTENSIONS, gl_PERL):
2304 (gl_IGNORE_UNUSED_LIBRARIES): Remove; now done by gnulib.
2306 (gl_MACROS): Call just after gl_EARLY, just for clarity.
2307 * src/c99-to-c89.diff: Remove patch to ls.c; no longer needed.
2308 * src/kill.c (strtoimax): Remove decl.
2309 * src/ls.c: Include "wcwidth.h" instead of rolling it ourselves.
2310 * src/wc.c: Likewise.
2311 * src/ls.c (sort_files): Rewrite to avoid need for C99-style
2312 declaration, so that we don't need to patch this file.
2313 * src/printf.c (strtoimax, strtoumax): Remove decls.
2314 * src/su.c: Include getpass.h.
2316 * src/system.h: Include mempcpy.h, stpcpy.h, strpbrk.h.
2317 Include inttypes.h unconditionally.
2318 (LONGEST_MODIFIER, PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Remove.
2319 (stpcpy, strndup, strstr, strtoul, mempcpy, CHAR_MIN, CHAR_MAX):
2320 (SCHAR_MIN, SCHAR_MAX, UCHAR_MAX, SHRT_MIN, SHRT_MAX, INT_MAX):
2321 (INT_MIN, INTMAX_MAX, INTMAX_MIN, UINT_MAX, LONG_MAX, ULONG_MAX):
2322 (SIZE_MAX, SSIZE_MAX, UINTMAX_MAX): Remove.
2324 * ABOUT-NLS, INSTALL, Makefile.in, man/Makefile.in:
2325 * src/Makefile.in, tests/Makefile.in, tests/chgrp/Makefile.in:
2326 * tests/chmod/Makefile.in, tests/chown/Makefile.in:
2327 * tests/cp/Makefile.in, tests/cut/Makefile.in:
2328 * tests/dd/Makefile.in, tests/dircolors/Makefile.in:
2329 * tests/du/Makefile.in, tests/expr/Makefile.in:
2330 * tests/factor/Makefile.in, tests/fmt/Makefile.in:
2331 * tests/general/Makefile.in, tests/head/Makefile.in:
2332 * tests/install/Makefile.in, tests/join/Makefile.in:
2333 * tests/ln/Makefile.in, tests/ls/Makefile.in:
2334 * tests/ls-2/Makefile.in, tests/md5sum/Makefile.in:
2335 * tests/misc/Makefile.in, tests/mkdir/Makefile.in:
2336 * tests/mv/Makefile.in, tests/od/Makefile.in:
2337 * tests/pr/Makefile.in, tests/readlink/Makefile.in:
2338 * tests/rm/Makefile.in, tests/rmdir/Makefile.in:
2339 * tests/seq/Makefile.in, tests/sha1sum/Makefile.in:
2340 * tests/shred/Makefile.in, tests/sort/Makefile.in:
2341 * tests/stty/Makefile.in, tests/sum/Makefile.in:
2342 * tests/tac/Makefile.in, tests/tail/Makefile.in:
2343 * tests/tail-2/Makefile.in, tests/tee/Makefile.in:
2344 * tests/test/Makefile.in, tests/touch/Makefile.in:
2345 * tests/tr/Makefile.in, tests/tsort/Makefile.in:
2346 * tests/unexpand/Makefile.in, tests/uniq/Makefile.in:
2347 * tests/wc/Makefile.in:
2348 Remove from CVS, since ./bootstrap generates them automatically.
2350 2006-08-20 Eric Blake <ebb9@byu.net>
2352 * src/stat.c (USE_STATVFS): Reinstate the patch from 2006-08-15;
2353 the patch from 2006-08-18 broke on cygwin.
2355 2006-08-20 Jim Meyering <jim@meyering.net>
2357 * NEWS: Add a line for 6.2-cvs.
2358 * configure.ac (AC_INIT): Bump to 6.2 and add "-cvs" suffix.
2360 2006-08-19 Jim Meyering <jim@meyering.net>
2363 * NEWS: Record the 6.1 release date.
2364 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
2366 * tests/Makefile.am (EXTRA_DIST): Add sparse-file.
2368 Avoid test failure when `make check' is run through debuild.
2369 * tests/help-version: Ensure that $SHELL is set to some value
2370 and exported. Patch from Sven Joachim. For details, see
2371 <http://bugs.debian.org/355368>.
2373 * tests/ls/stat-dtype: Test for the 2006-08-17 `ls -CF' fix.
2375 * README: Describe potential "pre-C99 build failure", and work-around.
2377 Some of my 2006-07-03 changes to tests/*/Makefile.am were being
2378 backed out due to updates provoked by the copyright changes.
2379 * tests/Makefile.am.in (PATH): Prepend $(VG_PATH_PREFIX), so that
2380 it propagates to the derived Makefile.am files.
2381 ($(srcdir)/Makefile.am): Mark generated .am files as read-only,
2382 so we don't mistakenly edit them again.
2383 * tests/cut/Makefile.am: Regenerate.
2384 * tests/head/Makefile.am: Likewise.
2385 * tests/join/Makefile.am: Likewise.
2386 * tests/pr/Makefile.am: Likewise.
2387 * tests/sort/Makefile.am: Likewise.
2388 * tests/tac/Makefile.am: Likewise.
2389 * tests/tail/Makefile.am: Likewise.
2390 * tests/test/Makefile.am: Likewise.
2391 * tests/tr/Makefile.am: Likewise.
2392 * tests/uniq/Makefile.am: Likewise.
2393 * tests/wc/Makefile.am: Likewise.
2395 * NEWS: Fix cp --sparse so that it preserves tail-end sparseness, even
2396 when the file's apparent size is not a multiple of its block size.
2397 * src/copy.c (copy_reg): Don't write a NUL before calling ftruncate.
2398 For some file sizes, writing that single byte would unnecessarily
2399 waste a few file blocks. That write may have been necessary in the
2400 early days of Linux, but now, removing it should be safe.
2401 Based on a patch by Alan Curry: <http://bugs.debian.org/370792>
2402 * tests/cp/sparse: New test for the above.
2403 * tests/cp/Makefile.am (TESTS): Add sparse.
2405 * tests/sparse-file: New file, essence factored out of...
2406 * tests/du/8gb: ... here. Use the new script.
2408 2006-08-18 Paul Eggert <eggert@cs.ucla.edu>
2410 * src/system.h (select_plural): Reduce by 1000000, not 1000, since
2411 the CVS gettext manual now suggests 1000000.
2413 2006-08-18 Bruno Haible <bruno@clisp.org>
2415 Add support for NetBSD 3.0.
2416 * src/stat.c (USE_STATVFS): Set to 1 if 'struct statvfs' has a field
2418 (STATXFS_FILE_SYSTEM_TYPE_MEMBER_NAME): Define also if 'struct statvfs'
2419 has a field f_fstypename.
2420 This undoes the 2006-08-15 to src/stat.c.
2422 2006-08-17 Paul Eggert <eggert@cs.ucla.edu>
2424 Copyright notice fixes.
2426 * COPYING: Upgrade to latest version from FSF.
2428 * src/uname.c: Use (C) in copyright notice.
2430 * .vg-suppressions: Add copyright notice.
2431 * ChangeLog: Likewise.
2432 * ChangeLog-2005: Likewise.
2433 * Makefile.am: Likewise.
2436 * README-valgrind: Likewise.
2438 * announce-gen: Likewise.
2439 * man/Makefile.am: Likewise.
2440 * man/chmod.x: Likewise.
2441 * man/chown.x: Likewise.
2442 * man/df.x: Likewise.
2443 * man/du.x: Likewise.
2444 * man/rm.x: Likewise.
2445 * src/dircolors.hin: Likewise.
2446 * src/du-tests: Likewise.
2447 * src/extract-magic: Likewise.
2448 * src/tac-pipe.c: Likewise.
2449 * src/wheel-gen.pl: Likewise.
2450 * tests/Coreutils.pm: Likewise.
2451 * tests/Makefile.am.in: Likewise.
2452 * tests/acl: Likewise.
2453 * tests/envvar-check: Likewise.
2454 * tests/expensive: Likewise.
2455 * tests/group-names: Likewise.
2456 * tests/help-version: Likewise.
2457 * tests/mk-script: Likewise.
2458 * tests/priv-check: Likewise.
2459 * tests/rwx-to-mode: Likewise.
2460 * tests/sample-test: Likewise.
2461 * tests/setgid-check: Likewise.
2462 * tests/chgrp/basic: Likewise.
2463 * tests/chgrp/deref: Likewise.
2464 * tests/chgrp/no-x: Likewise.
2465 * tests/chgrp/posix-H: Likewise.
2466 * tests/chgrp/recurse: Likewise.
2467 * tests/chmod/c-option: Likewise.
2468 * tests/chmod/equal-x: Likewise.
2469 * tests/chmod/equals: Likewise.
2470 * tests/chmod/no-x: Likewise.
2471 * tests/chmod/octal: Likewise.
2472 * tests/chmod/setgid: Likewise.
2473 * tests/chmod/umask-x: Likewise.
2474 * tests/chmod/usage: Likewise.
2475 * tests/chown/basic: Likewise.
2476 * tests/chown/deref: Likewise.
2477 * tests/chown/separator: Likewise.
2478 * tests/cp/Makefile.am: Likewise.
2479 * tests/cp/acl: Likewise.
2480 * tests/cp/backup-1: Likewise.
2481 * tests/cp/backup-is-src: Likewise.
2482 * tests/cp/cp-HL: Likewise.
2483 * tests/cp/cp-deref: Likewise.
2484 * tests/cp/cp-mv-backup: Likewise.
2485 * tests/cp/cp-parents: Likewise.
2486 * tests/cp/deref-slink: Likewise.
2487 * tests/cp/dir-rm-dest: Likewise.
2488 * tests/cp/dir-slash: Likewise.
2489 * tests/cp/dir-vs-file: Likewise.
2490 * tests/cp/fail-perm: Likewise.
2491 * tests/cp/into-self: Likewise.
2492 * tests/cp/link: Likewise.
2493 * tests/cp/link-no-deref: Likewise.
2494 * tests/cp/link-preserve: Likewise.
2495 * tests/cp/no-deref-link1: Likewise.
2496 * tests/cp/no-deref-link2: Likewise.
2497 * tests/cp/no-deref-link3: Likewise.
2498 * tests/cp/perm: Likewise.
2499 * tests/cp/preserve-2: Likewise.
2500 * tests/cp/r-vs-symlink: Likewise.
2501 * tests/cp/same-file: Likewise.
2502 * tests/cp/slink-2-slink: Likewise.
2503 * tests/cp/special-bits: Likewise.
2504 * tests/cp/symlink-slash: Likewise.
2505 * tests/cut/Makefile.am: Likewise.
2506 * tests/cut/Test.pm: Likewise.
2507 * tests/dd/misc: Likewise.
2508 * tests/dd/not-rewound: Likewise.
2509 * tests/dd/skip-seek: Likewise.
2510 * tests/dd/skip-seek2: Likewise.
2511 * tests/dd/unblock-sync: Likewise.
2512 * tests/dircolors/simple: Likewise.
2513 * tests/du/2g: Likewise.
2514 * tests/du/8gb: Likewise.
2515 * tests/du/Makefile.am: Likewise.
2516 * tests/du/basic: Likewise.
2517 * tests/du/deref: Likewise.
2518 * tests/du/deref-args: Likewise.
2519 * tests/du/exclude: Likewise.
2520 * tests/du/fd-leak: Likewise.
2521 * tests/du/files0-from: Likewise.
2522 * tests/du/hard-link: Likewise.
2523 * tests/du/inaccessible-cwd: Likewise.
2524 * tests/du/long-from-unreadable: Likewise.
2525 * tests/du/long-sloop: Likewise.
2526 * tests/du/no-deref: Likewise.
2527 * tests/du/no-x: Likewise.
2528 * tests/du/restore-wd: Likewise.
2529 * tests/du/slash: Likewise.
2530 * tests/du/slink: Likewise.
2531 * tests/du/trailing-slash: Likewise.
2532 * tests/du/two-args: Likewise.
2533 * tests/expr/basic: Likewise.
2534 * tests/factor/basic: Likewise.
2535 * tests/fmt/basic: Likewise.
2536 * tests/fmt/long-line: Likewise.
2537 * tests/general/Makefile.am: Likewise.
2538 * tests/general/atgeneral.m4: Likewise.
2539 * tests/general/dd.at: Likewise.
2540 * tests/head/Makefile.am: Likewise.
2541 * tests/head/Test.pm: Likewise.
2542 * tests/install/basic-1: Likewise.
2543 * tests/install/create-leading: Likewise.
2544 * tests/install/d-slashdot: Likewise.
2545 * tests/install/trap: Likewise.
2546 * tests/join/Makefile.am: Likewise.
2547 * tests/join/Test.pm: Likewise.
2548 * tests/ln/backup-1: Likewise.
2549 * tests/ln/misc: Likewise.
2550 * tests/ln/sf-1: Likewise.
2551 * tests/ln/target-1: Likewise.
2552 * tests/ls/Makefile.am: Likewise.
2553 * tests/ls/Test.pm: Likewise.
2554 * tests/ls/dangle: Likewise.
2555 * tests/ls/dired: Likewise.
2556 * tests/ls/file-type: Likewise.
2557 * tests/ls/follow-slink: Likewise.
2558 * tests/ls/infloop: Likewise.
2559 * tests/ls/inode: Likewise.
2560 * tests/ls/m-option: Likewise.
2561 * tests/ls/no-arg: Likewise.
2562 * tests/ls/recursive: Likewise.
2563 * tests/ls/rt-1: Likewise.
2564 * tests/ls/stat-dtype: Likewise.
2565 * tests/ls/stat-failed: Likewise.
2566 * tests/ls/stat-vs-dirent: Likewise.
2567 * tests/ls/symlink-slash: Likewise.
2568 * tests/ls/time-1: Likewise.
2569 * tests/ls-2/tests: Likewise.
2570 * tests/md5sum/basic-1: Likewise.
2571 * tests/md5sum/newline-1: Likewise.
2572 * tests/misc/Makefile.am: Likewise.
2573 * tests/misc/base64: Likewise.
2574 * tests/misc/basename: Likewise.
2575 * tests/misc/cat-proc: Likewise.
2576 * tests/misc/close-stdout: Likewise.
2577 * tests/misc/csplit: Likewise.
2578 * tests/misc/date: Likewise.
2579 * tests/misc/date-sec: Likewise.
2580 * tests/misc/df: Likewise.
2581 * tests/misc/dirname: Likewise.
2582 * tests/misc/expand: Likewise.
2583 * tests/misc/false-status: Likewise.
2584 * tests/misc/fold: Likewise.
2585 * tests/misc/head-c: Likewise.
2586 * tests/misc/head-elide-tail: Likewise.
2587 * tests/misc/head-pos: Likewise.
2588 * tests/misc/mknod: Likewise.
2589 * tests/misc/nice: Likewise.
2590 * tests/misc/nl: Likewise.
2591 * tests/misc/nohup: Likewise.
2592 * tests/misc/paste-no-nl: Likewise.
2593 * tests/misc/pathchk1: Likewise.
2594 * tests/misc/printf: Likewise.
2595 * tests/misc/printf-hex: Likewise.
2596 * tests/misc/pwd-long: Likewise.
2597 * tests/misc/sha224sum: Likewise.
2598 * tests/misc/sha256sum: Likewise.
2599 * tests/misc/sha384sum: Likewise.
2600 * tests/misc/sha512sum: Likewise.
2601 * tests/misc/shuf: Likewise.
2602 * tests/misc/sort-merge: Likewise.
2603 * tests/misc/sort-rand: Likewise.
2604 * tests/misc/split-a: Likewise.
2605 * tests/misc/split-fail: Likewise.
2606 * tests/misc/split-l: Likewise.
2607 * tests/misc/stat-fmt: Likewise.
2608 * tests/misc/stat-printf: Likewise.
2609 * tests/misc/tac-continue: Likewise.
2610 * tests/misc/test-diag: Likewise.
2611 * tests/misc/tty-eof: Likewise.
2612 * tests/misc/wc-files0: Likewise.
2613 * tests/misc/wc-files0-from: Likewise.
2614 * tests/mkdir/concurrent-1: Likewise.
2615 * tests/mkdir/p-1: Likewise.
2616 * tests/mkdir/p-2: Likewise.
2617 * tests/mkdir/p-3: Likewise.
2618 * tests/mkdir/p-slashdot: Likewise.
2619 * tests/mkdir/p-thru-slink: Likewise.
2620 * tests/mkdir/parents: Likewise.
2621 * tests/mkdir/perm: Likewise.
2622 * tests/mkdir/special-1: Likewise.
2623 * tests/mkdir/t-slash: Likewise.
2624 * tests/mkdir/writable-under-readonly: Likewise.
2625 * tests/mv/Makefile.am: Likewise.
2626 * tests/mv/acl: Likewise.
2627 * tests/mv/atomic: Likewise.
2628 * tests/mv/backup-is-src: Likewise.
2629 * tests/mv/childproof: Likewise.
2630 * tests/mv/diag: Likewise.
2631 * tests/mv/dir-file: Likewise.
2632 * tests/mv/dir2dir: Likewise.
2633 * tests/mv/dup-source: Likewise.
2634 * tests/mv/force: Likewise.
2635 * tests/mv/hard-2: Likewise.
2636 * tests/mv/hard-3: Likewise.
2637 * tests/mv/hard-4: Likewise.
2638 * tests/mv/hard-link-1: Likewise.
2639 * tests/mv/i-1: Likewise.
2640 * tests/mv/i-2: Likewise.
2641 * tests/mv/i-3: Likewise.
2642 * tests/mv/i-4: Likewise.
2643 * tests/mv/i-link-no: Likewise.
2644 * tests/mv/into-self: Likewise.
2645 * tests/mv/into-self-2: Likewise.
2646 * tests/mv/into-self-3: Likewise.
2647 * tests/mv/into-self-4: Likewise.
2648 * tests/mv/leak-fd: Likewise.
2649 * tests/mv/mv-special-1: Likewise.
2650 * tests/mv/no-target-dir: Likewise.
2651 * tests/mv/part-fail: Likewise.
2652 * tests/mv/part-hardlink: Likewise.
2653 * tests/mv/part-rename: Likewise.
2654 * tests/mv/part-symlink: Likewise.
2655 * tests/mv/partition-perm: Likewise.
2656 * tests/mv/perm-1: Likewise.
2657 * tests/mv/reply-no: Likewise.
2658 * tests/mv/setup: Likewise.
2659 * tests/mv/to-symlink: Likewise.
2660 * tests/mv/trailing-slash: Likewise.
2661 * tests/mv/update: Likewise.
2662 * tests/mv/vfat: Likewise.
2663 * tests/od/od-N: Likewise.
2664 * tests/od/x8: Likewise.
2665 * tests/pr/Makefile.am: Likewise.
2666 * tests/pr/Test.pm: Likewise.
2667 * tests/readlink/can-e: Likewise.
2668 * tests/readlink/can-f: Likewise.
2669 * tests/readlink/can-m: Likewise.
2670 * tests/readlink/rl-1: Likewise.
2671 * tests/rm/Makefile.am: Likewise.
2672 * tests/rm/cycle: Likewise.
2673 * tests/rm/dangling-symlink: Likewise.
2674 * tests/rm/deep-1: Likewise.
2675 * tests/rm/dir-no-w: Likewise.
2676 * tests/rm/dir-nonrecur: Likewise.
2677 * tests/rm/dot-rel: Likewise.
2678 * tests/rm/empty-inacc: Likewise.
2679 * tests/rm/empty-name: Likewise.
2680 * tests/rm/f-1: Likewise.
2681 * tests/rm/fail-2eperm: Likewise.
2682 * tests/rm/fail-eperm: Likewise.
2683 * tests/rm/hash: Likewise.
2684 * tests/rm/i-1: Likewise.
2685 * tests/rm/i-no-r: Likewise.
2686 * tests/rm/inaccessible: Likewise.
2687 * tests/rm/interactive-always: Likewise.
2688 * tests/rm/interactive-once: Likewise.
2689 * tests/rm/ir-1: Likewise.
2690 * tests/rm/isatty: Likewise.
2691 * tests/rm/no-give-up: Likewise.
2692 * tests/rm/r-1: Likewise.
2693 * tests/rm/r-2: Likewise.
2694 * tests/rm/r-3: Likewise.
2695 * tests/rm/rm1: Likewise.
2696 * tests/rm/rm2: Likewise.
2697 * tests/rm/rm3: Likewise.
2698 * tests/rm/rm4: Likewise.
2699 * tests/rm/rm5: Likewise.
2700 * tests/rm/sunos-1: Likewise.
2701 * tests/rm/unread2: Likewise.
2702 * tests/rm/unread3: Likewise.
2703 * tests/rm/unreadable: Likewise.
2704 * tests/rmdir/fail-perm: Likewise.
2705 * tests/rmdir/ignore: Likewise.
2706 * tests/rmdir/t-slash: Likewise.
2707 * tests/seq/basic: Likewise.
2708 * tests/sha1sum/basic-1: Likewise.
2709 * tests/sha1sum/sample-vec: Likewise.
2710 * tests/shred/exact: Likewise.
2711 * tests/shred/remove: Likewise.
2712 * tests/sort/Makefile.am: Likewise.
2713 * tests/sort/Test.pm: Likewise.
2714 * tests/sort-time/Makefile: Likewise.
2715 * tests/sort-time/README: Likewise.
2716 * tests/sort-time/rand-gen: Likewise.
2717 * tests/stty/basic-1: Likewise.
2718 * tests/stty/row-col-1: Likewise.
2719 * tests/sum/basic-1: Likewise.
2720 * tests/sum/sysv: Likewise.
2721 * tests/tac/Makefile.am: Likewise.
2722 * tests/tac/Test.pm: Likewise.
2723 * tests/tail/Makefile.am: Likewise.
2724 * tests/tail/Test.pm: Likewise.
2725 * tests/tail-2/Makefile.am: Likewise.
2726 * tests/tail-2/append-only: Likewise.
2727 * tests/tail-2/assert: Likewise.
2728 * tests/tail-2/assert-2: Likewise.
2729 * tests/tail-2/big-4gb: Likewise.
2730 * tests/tail-2/fflush: Likewise.
2731 * tests/tail-2/infloop-1: Likewise.
2732 * tests/tail-2/proc-ksyms: Likewise.
2733 * tests/tail-2/start-middle: Likewise.
2734 * tests/tail-2/tail-n0f: Likewise.
2735 * tests/tee/basic: Likewise.
2736 * tests/tee/dash: Likewise.
2737 * tests/test/Makefile.am: Likewise.
2738 * tests/test/Test.pm: Likewise.
2739 * tests/touch/Makefile.am: Likewise.
2740 * tests/touch/dangling-symlink: Likewise.
2741 * tests/touch/empty-file: Likewise.
2742 * tests/touch/fail-diag: Likewise.
2743 * tests/touch/fifo: Likewise.
2744 * tests/touch/no-create-missing: Likewise.
2745 * tests/touch/no-rights: Likewise.
2746 * tests/touch/not-owner: Likewise.
2747 * tests/touch/obsolescent: Likewise.
2748 * tests/touch/read-only: Likewise.
2749 * tests/touch/relative: Likewise.
2750 * tests/tr/Makefile.am: Likewise.
2751 * tests/tr/Test.pm: Likewise.
2752 * tests/tr/failures: Likewise.
2753 * tests/tsort/basic-1: Likewise.
2754 * tests/unexpand/basic-1: Likewise.
2755 * tests/uniq/Makefile.am: Likewise.
2756 * tests/uniq/Test.pm: Likewise.
2757 * tests/wc/Makefile.am: Likewise.
2758 * tests/wc/Test.pm: Likewise.
2760 2006-08-17 Jim Meyering <jim@meyering.net>
2762 ls -CF would misalign columns in some cases.
2763 * src/ls.c (get_type_indicator): New function. extracted from...
2764 (print_type_indicator): ...here. Use it.
2765 (length_of_file_name_and_frills): Use it here, too, rather than
2766 assuming stat.st_mode is valid.
2767 Reported by Andreas Schwab, here:
2768 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7774>
2769 See the test for this above. FYI, I did ls -CF /proc and visually
2770 inspected the result.
2772 * src/copy.c (copy_internal, same_file_ok): Adjust comments not
2773 to mention the now-removed cp_options.xstat member.
2775 * Makefile.maint (patch-check): Adapt to work now that the patch
2776 modifies more than one file in src/.
2778 With this patch, permit building with Solaris cc on Solaris 7.
2779 * src/c99-to-c89.diff: Add diffs to convert more c99-isms.
2780 This integrates patches from Bruno Haible.
2782 2006-08-16 Paul Eggert <eggert@cs.ucla.edu>
2784 Fix some problems reported by Bruno Haible.
2785 * tests/chmod/setgid (abs_srcdir): Remove; not used or needed.
2786 Skip this test if "chmod g+s d" silently does nothing.
2787 * tests/ls-2/tests: Skip this test suite if we can't set up files
2788 properly for the setuid-etc test. This simplifies some of the
2789 hacks we were using to work around porting problems.
2791 2006-08-16 Jim Meyering <jim@meyering.net>
2793 * tests/cp/Makefile.am: Don't mark "acl" as XFAIL.
2794 * tests/cp/acl: Instead, skip the test if either setfacl
2796 Reported by Michael Stone.
2798 2006-08-16 Paul Eggert <eggert@cs.ucla.edu>
2800 * tests/lang-default (LC_ALL): Set to "C", so we get
2801 English-language diagnostics. Unset the other variables; it
2802 should be portable to use 'unset' for this stuff nowadays.
2803 Problem reported by Bruno Haible. Using "C" reverses the
2804 2000-10-22 change to fileutils in this area.
2806 Fix bugs when printing plurals of numbers that are not
2807 unsigned long int values.
2808 * src/system.h (select_plural): New function.
2809 * src/md5sum.c (digest_check): Use select_plural to avoid bug.
2810 * src/uptime.c (print_uptime): Likewise.
2811 * src/dd.c (print_stats): Likewise. Also, don't use ngettext to
2812 print a floating point number, as reducing to 0 or 1 doesn't work
2813 for some languages. Instead, just use "s" for seconds since it
2814 doesn't need a plural form.
2816 2006-08-16 Bruno Haible <bruno@clisp.org>
2818 Old versions of gzip would write --help output to stderr, and it
2819 would be annoying to see that in the output of every "make" command.
2820 * Makefile.maint (gzip_rsyncable): Throw away stderr output of
2823 2006-08-16 Andreas Schwab <schwab@suse.de>
2825 * tests/cp/acl: Don't use non-portable == operator for test.
2827 2006-08-16 Jim Meyering <jim@meyering.net>
2829 * tests/ls/stat-dtype: Use stat to test file system type, rather
2830 than df -T, in case /etc/mtab lies. Reported by Michael Stone.
2832 2006-08-15 Paul Eggert <eggert@cs.ucla.edu>
2834 * NEWS: Mention that df exits with nonzero status if it generates
2835 no output. This change was in 6.0 but inadvertently unmentioned.
2836 * src/df.c (file_systems_processed): Renamed from n_valid_args, and now
2838 (show_dev): Don't set it until we actually output something.
2839 Print the header if this is the first output.
2840 (main): Don't print a header, as that is now show_dev's job.
2841 * tests/misc/Makefile.am (TESTS): Add df.
2842 * tests/misc/df: New file.
2844 2006-08-15 Eric Blake <ebb9@byu.net>
2846 * src/stat.c (USE_STATVFS): Define to 0 if f_type is needed, but
2847 statvfs.f_type not present. See
2848 <http://savannah.gnu.org/bugs/?func=detailitem&item_id=16325>.
2850 2006-08-15 Paul Eggert <eggert@cs.ucla.edu>
2852 * src/dd.c (print_stats): Don't substitute "1" for number, as this
2853 causes confusion for the Hungarian translators. Problem reported
2854 by Egmont Koblinger here:
2855 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7726
2857 2006-08-15 Jim Meyering <jim@meyering.net>
2859 * .x-sc_require_config_h: Add lib/at-func.c.
2861 * NEWS: Add a line for 6.1-cvs.
2862 * configure.ac (AC_INIT): Bump to 6.1 and add "-cvs" suffix.
2864 2006-08-15 Jim Meyering <jim@meyering.net>
2867 * NEWS: Record the 6.0 release date.
2868 * configure.ac (AC_INIT): Remove "-cvs" suffix from version string.
2870 * TODO: Add an item (convert to use gnulib-tool), add to the plan
2871 for id-vs-getgrouplist, and remove a few completed items.
2873 * Makefile.maint (alpha beta major): Fix syntax error.
2875 2006-08-13 Jim Meyering <jim@meyering.net>
2877 * src/shred.c (usage): Don't indent the second line of an item.
2878 Otherwise, help2man would misformat the output.
2879 Reported by Adam Buchbinder in <https://launchpad.net/bugs/48917>.
2881 2006-08-11 Paul Eggert <eggert@cs.ucla.edu>
2883 * configure.ac (AM_GNU_GETTEXT): Upgrade to need-formatstring-macros.
2884 Suggested by Eric Blake to avoid problems like
2885 <http://lists.gnu.org/archive/html/bug-coreutils/2006-07/msg00087.html>.
2887 2006-08-11 Jim Meyering <jim@meyering.net>
2889 * tests/ls/stat-vs-dirent: Too many (losing) systems trigger the
2890 failure that this test checks for (stat/dirent inode mismatch at
2891 a mount point), so continue to give a diagnostic about the failure,
2892 but don't actually count it as a failure.
2894 2006-08-10 Paul Eggert <eggert@cs.ucla.edu>
2896 * ABOUT-NLS: Update from gettext 0.15.
2897 * configure.ac (AM_GNU_GETTEXT_VERSION): Update from 0.13.1 to 0.15.
2899 * src/csplit.c (struct control): Remove fastmap member.
2900 (extract_regexp): Allocate fastmap separately, since otherwise
2901 it might move due to a realloc. This fixes a bug that led
2902 to a core dump on 64-bit sparc Solaris 10 (Sun Studio 10).
2904 2006-08-10 Jim Meyering <jim@meyering.net>
2906 * tests/ls/stat-dtype: If "." is tmpfs, skip this test unless uname -s
2907 reports "Linux". This avoids a failure on Solaris 10's tmpfs.
2908 Redirect both stdout and stderr of df invocations.
2910 * src/dircolors.hin: Add a TERM directive for each of the following:
2911 ansi, color-xterm, gnome, konsole, kterm, rxvt-cygwin,
2912 rxvt-cygwin-native, screen.linux, xterm-256color.
2913 Sort the TERM directives.
2914 From Mike Frysinger.
2916 2006-08-09 Paul Eggert <eggert@cs.ucla.edu>
2918 * src/dd.c (usage): Warn about oflag=append without conv=notrunc.
2919 See Debian bug 373736.
2921 * src/dircolors.hin: Add mlterm, rxvt-unicode; this fixes Debian
2924 * src/.cvsignore: Add shuf.
2926 * Makefile.maint: Remove the po-update procedure; it doesn't
2927 work with the new repository on http://www.iro.umontreal.ca/.
2928 For now I guess we'll have to fix things by hand.
2929 (do-po-update, po-update): Remove. All references removed.
2931 * src/shuf.c (next_line): New function.
2932 (read_input): Use it, to avoid relying on GCC-specific behavior
2933 with void * arithmetic. Problem reported by Bob Proulx.
2934 * Makefile.maint (my-distcheck): Compile with -Wpointer-arith
2935 to detect this sort of problem automatically in the future.
2937 2006-08-09 Jim Meyering <jim@meyering.net>
2939 * src/ls.c: Add a compile-time check to ensure that filetype
2940 and filetype_letter have the same number of elements.
2942 * tests/misc/sort-rand: Remove use of --seed=S.
2944 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
2946 Add a command 'shuf', and modify shred and sort to use the new
2947 random number generator library of 'shuf'.
2949 * AUTHORS: Add shuf.
2951 * NEWS: Likewise. Mention new --random-source option for shred
2952 and sort. Move "sort +1 -2" notice to the appropriate section,
2953 and clarify its role with respect to POSIXLY_CORRECT.
2954 * man/.cvsignore: Add shuf.1.
2955 * man/Makefile.am (dist_man_MANS): Add shuf.1.
2956 (shuf.1): New dependency.
2957 * man/shuf.x: New file.
2958 * src/Makefile.am (bin_PROGRAMS): Add shuf.
2959 (EXTRA_DIST): Remove rand-isaac.c.
2960 (shuf_LDADD): New macro.
2961 * src/rand-isaac.c: Remove, moving most of its contents to
2963 * src/shuf.c: New file.
2964 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
2965 Don't include rand-isaac.c; include randint.h and randread.h instead.
2966 (RANDOM_SOURCE_OPTION): New enum.
2967 (long_opts, usage, main): New option --random-source.
2968 * src/sort.c: Likewise.
2969 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
2970 All callers changed to use randint interface.
2971 (fillrand): Remove. All callers changed to use randread interface.
2972 (dopass): Remove dependency on ISAAC buffer size.
2973 (genpattern): Don't wipe the random state here.
2974 (randint_source): New static var.
2975 (clear_random_data): New function.
2976 (main): Allocate random source, and arrange to wipe it on exit.
2977 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
2978 (longopts, usage, main): Remove undocumented --seed option;
2979 it's now replaced by --random-source.
2980 (rand_state, get_hash): Remove.
2981 (randread_source): New static var.
2982 (random_state, cmp_hashes, compare_random): New functions; they guarantee
2983 no collisions in the random hash function.
2984 (keycompare): Use compare_random for -R; don't fall back on comparing
2985 via memcoll, since compare_random does the right thing.
2986 * tests/misc/Makefile.am (TESTS): Add shuf.
2987 * tests/misc/shuf: New file.
2989 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
2991 * src/copy.c (set_author): Preserve the st_author field via the
2992 file descriptor dest_desc.
2994 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
2996 * NEWS: chmod now preserves setuid and setgid bits on directories
2997 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
2999 Fix test case problems if working directory is setgid,
3000 reported by Bob Proulx.
3001 * tests/cp/fail-perm: Use symbolic mode so that we clear
3002 setgid bit more reliably on directories.
3003 * tests/mkdir/special-1 (set_mode_string): Likewise.
3005 2006-07-27 Jim Meyering <jim@meyering.net>
3007 * src/chgrp.c (usage): Use correct grammar in description of the
3009 * src/chown.c (usage): Likewise.
3011 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
3013 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
3014 Correctly access SRC_SB's element ST_AUTHOR.
3016 2006-07-26 Jim Meyering <jim@meyering.net>
3018 * tests/ls/stat-failed: Adapt to match new expected output.
3021 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
3022 than having the code test for all of the other types first.
3023 Hoist the set-uid/gid-testing code "up" into this new block.
3024 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
3025 C_ORPHAN, not as C_FILE.
3027 2006-07-26 Jim Meyering <jim@meyering.net>
3029 Checking in a change from Paul.
3031 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
3033 * src/ls.c (DT_INIT): Remove. All uses removed.
3034 (enum filetype): Use an ordinary enum rather than trying to keep
3035 the values in sync with DT_FIFO etc. That way, we don't have
3036 to make special assumptions about them. All uses changed.
3037 (whiteout): New constant member of enum filetype.
3038 (filetype_letter): New constant, for use with enum filetype.
3039 (FILETYPE_INDICATORS): New initializer list.
3040 (print_dir): Add case for DT_WHT.
3041 (gobble_file): If stat fails, don't discard information from
3042 readdir; instead, preserve it so it can be printed.
3043 (print_long_format): Fall back on readdir result if stat info
3044 is not available. Use "?" to denote each unknown mode char,
3045 instead of an overall "?", since we now know some of the mode
3047 (print_type_indicator): Now that MODE isn't necessarily
3048 useful, guard all uses.
3049 Now that two blocks in the type-checking tree can set "type = C_FILE",
3050 move the suffix-handling code out and down.
3052 2006-07-26 Jim Meyering <jim@meyering.net>
3054 Prepare for the above change.
3055 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
3056 and adjust uses. From a patch by Paul Eggert.
3058 2006-07-26 Jim Meyering <jim@meyering.net>
3060 * src/ls.c: Correct indentation/formatting in a few places.
3062 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
3064 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
3065 Problem report and fix from Bob Proulx.
3066 * NEWS: Clarify the "chmod 0500" news, and correct the vague
3067 statements about compatibility with BSD.
3069 2006-07-25 Jim Meyering <jim@meyering.net>
3071 * src/ls.c (gobble_file): When handling a stat-failed entry,
3072 print the entry name not the absolute_name -- to be consistent
3073 with the usual case.
3074 * tests/ls/stat-failed: Update accordingly.
3076 * src/ls.c: Add parens around the new uses of ?: ternary operator.
3078 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
3081 Get --dired offsets right when handling stat-failed entries.
3082 * src/ls.c (print_long_format): Be careful to increment P by the
3083 appropriate amount, even when inode_number_width and nlink_width
3085 * tests/ls/stat-failed: Test for the above.
3087 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
3088 have_acl member. That would happen for a directory with both a
3089 non-stat'able entry and one with an ACL.
3091 * src/ls.c (gobble_file): Make it so failure to stat a
3092 non-command-line file provokes an exit status of 1, not 0.
3093 Say "cannot access" rather than "cannot stat".
3094 * tests/ls/stat-failed: New file/test, for the above.
3095 * tests/ls/Makefile.am (TESTS): Add stat-failed.
3096 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
3097 of "cannot access " to diagnostic.
3099 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
3101 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
3102 Replace all occurrences of "type == command_line" with the
3103 equivalent, "command_line_arg".
3105 * src/ls.c: Apply the stat-failed parts of Red Hat's
3106 coreutils-selinux.patch. From Ulrich Drepper.
3107 This makes it so files not mentioned on the command line (e.g.,
3108 names read from a directory that *is* mentioned on the command
3109 line) for which stat fails are still listed. With --color,
3110 such files are colored just like ORPHANs (aka dangling symlinks).
3112 * src/df.c (n_valid_args): Declare global to be static.
3114 2006-07-24 Jim Meyering <jim@meyering.net>
3116 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
3117 system lacks d_type support.
3119 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
3121 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
3123 2006-07-21 Jim Meyering <jim@meyering.net>
3125 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
3126 Reported by Tim Waugh.
3127 Also remove the comment duplicating much of --help output.
3129 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
3130 name so the list remains alphabetized.
3132 Fix another bug: ls --indicator-style=file-type would call
3133 stat for a symlink, even though it wasn't always needed.
3134 In some cases, that unnecessary stat would cause ls to fail.
3135 * src/ls.c (gobble_file): Don't treat symlinks specially (in
3136 requiring a stat syscall). Remove the offending exclusion.
3138 * NEWS: Mention the fix.
3140 * tests/ls/stat-dtype: New file/test, for the above fix.
3141 Also exercises the new df feature, below.
3143 * src/df.c (main): Fail and don't print the headers if no
3144 file system is processed. This makes it easy to test whether
3145 a specified directory is on a file system of a given type or types.
3146 Otherwise, applications would have had to parse df's output.
3147 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
3149 Fix a bug: ls --file-type worked like --indicator-style=slash,
3150 rather than like --indicator-style=file-type.
3151 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
3152 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
3154 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
3155 * NEWS: Mention the fix.
3156 * tests/ls-2/tests (file-type): New test, for the above fix.
3158 2006-07-19 Jim Meyering <jim@meyering.net>
3160 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
3162 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
3164 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
3166 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
3167 of directories alone unless you specify them explicitly.
3168 install and mkdir now implement X correctly.
3169 install now creates parent directories with mode 755, without
3170 changing their owner or group.
3171 * src/chmod.c (process_file): Adjust to mode_adjust API change.
3172 * src/install.c: Include mkancesdirs.h.
3173 (announce_mkdir, make_ancestor): New functions.
3174 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
3176 (dir_mode, dir_mode_bits): New vars.
3177 (main): Set dir modes separately from nondir, so that the X
3178 op of -m works correctly.
3179 (main): Remove cwd_errno cruft, since make_dir_parents no longer
3180 affects cwd. Adjust to new make_dir_parents API.
3181 (install_file_in_file_parents): 2nd arg is now char *, not char
3182 const *. Use mkancesdirs instead of rolling our own code.
3183 (change_attributes): Don't worry about AFS, since that kludge
3184 should not be needed any more.
3185 * src/mkdir.c (struct mkdir_options): New struct.
3186 (announce_mkdir, make_ancestor): New functions.
3187 (main): Use them. Adjust to mode_adjust API change. Stick with
3188 umask 0. Use make_dir_parents for all the work.
3189 * src/mkfifo.c (main): Adjust to new mode_adjust API.
3190 * src/mknod.c (main): Likewise.
3191 * tests/chmod/setgid: Do the setgid test instead of bailing.
3192 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
3193 GNU chmod now behaves like other versions of chmod.
3194 * tests/mkdir/perm: Add a test for the X bug.
3196 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
3198 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
3199 This doesn't fix any bugs, since OUT always equals stdout, but it
3200 makes the code easier to understand.
3202 2006-07-14 Jim Meyering <jim@meyering.net>
3204 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
3205 rather than open-coding it. Now supports mercurial, too.
3206 * .hgignore: New file.
3207 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
3208 all generated files, including ones like configure and po/*.po
3209 that are currently version-controlled in cvs.
3211 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
3212 They've been in CVS, just haven't been distributed before this.
3213 Distribute ChangeLog-2005, too.
3214 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
3216 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
3218 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
3221 2006-07-09 Jim Meyering <jim@meyering.net>
3223 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
3224 That happens with Linux/tmpfs.
3225 * tests/mv/Makefile.am (TESTS): Add dir2dir.
3227 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
3229 Adjust to recent updates from gnulib.
3230 * src/dd.c (apply_translations): Use toupper rather than
3231 islower followed by toupper; it's simpler and typically
3232 faster now that we assume at least C89 semantics. Similarly
3234 * src/sort.c (inittables): Likewise.
3235 * src/expand.c (expand): Don't assume that isprint etc. return
3236 booleans (needed for pre-C99 hosts).
3237 * src/fmt.c (check_punctuation): Likewise.
3238 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
3239 * src/tr.c (is_char_class_member): Likewise.
3240 * src/unexpand.c (unexpand): Likewise.
3241 * src/join.c (is_blank): Remove; no longer needed. All uses
3242 replaced by isblank (to_uchar (...)).
3243 * src/pinky.c (create_fullname): Don't assume char is unsigned.
3244 * src/printf.c (print_esc): Likewise.
3245 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
3246 (copy_unescaped_string): Likewise.
3247 * src/stat.c (print_it): Likewise.
3248 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
3249 convenience on GNU systems. All uses changed. Don't bother
3250 looking for any dirent.h substitute other than ndir.h.
3251 (D_INO): Remove unnecessary parentheses.
3252 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
3253 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
3254 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
3255 to ctype.h equivalents.
3256 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
3259 2006-07-08 Jim Meyering <jim@meyering.net>
3261 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
3263 * Makefile.maint (sc_the_the): New rule.
3265 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
3266 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
3269 2006-07-07 Jim Meyering <jim@meyering.net>
3271 * NEWS: Mention that mv can now remove an empty destination directory,
3272 and give an example. Prompted by a report from Florent Bayle.
3274 2006-07-05 Jim Meyering <jim@meyering.net>
3276 * src/ls.c (usage): Correct the description of -G: it is useful
3277 only in a long listing. Reported by Martin Pool in
3278 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
3280 * man/chmod.x: Correct the description of the sticky bit. Reported
3281 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
3283 * src/copy.c (copy_internal): Don't work around old NFS clients like
3284 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
3285 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
3286 a banal failure as a recursive move-into-self failure.
3287 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
3289 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
3291 2006-07-03 Jim Meyering <jim@meyering.net>
3293 Plug another unusual leak.
3294 (AD_mark_helper): Free malloc'd filename if hash_insert says
3295 that string is already in the hash table.
3297 The dev/inode of the topmost directory in each hierarchy were not
3299 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
3300 (AD_push): Call it from here instead.
3302 Fix two small leaks.
3303 * src/remove.c (AD_stack_clear): New function.
3305 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
3307 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
3308 Add $VG_PATH_PREFIX as a prefix to $PATH
3310 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
3311 * tests/Makefile.am (evar-check): Remove rule.
3312 (EXTRA_DIST): Remove .env-warn.
3313 * tests/.env-warn: Remove file. No longer used.
3314 Suggestion from Eric Blake.
3316 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
3318 * src/system.h: Include <stdint.h> unconditionally, since we
3319 now assume the stdint module.
3321 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
3323 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
3324 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
3325 * src/tail.c (main): Implement this.
3326 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
3327 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
3329 2006-07-01 Jim Meyering <jim@meyering.net>
3331 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
3333 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
3336 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
3338 * NEWS: seq now uses long double internally rather than double.
3339 It now defaults to a minimal fixed point format if possible.
3340 It lets you use %a, %A, %E, %F, %G.
3341 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
3342 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
3343 (isfinite) [!defined isfinite]: New macro.
3344 (separator, terminator): Now points to const.
3345 (first, step, last): Remove.
3346 (usage): Update to match new behavior.
3347 (struct operand, operand): New type.
3348 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
3350 Compute and return a value of type operand, not double.
3351 (long_double_format): Renamed from valid_format, and now returns a
3352 new format with an "L" added if needed, if the original format was
3353 valid. Allow %a, %A, %E, %F, and %G formats.
3354 (print_numbers): Take numeric values as args rather than from globals.
3355 Print long double, not double.
3356 (get_width_format): Remove.
3357 (get_default_format): New function.
3358 (main): Implement new way of calculating default format.
3359 Don't worry about locale's representation of the decimal point, since
3360 the arguments are always processed in the C locale.
3361 * tests/seq/basic (neg-2): Adjust to new default format.
3362 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
3363 implementation should do the right thing.
3365 2006-06-30 Jim Meyering <jim@meyering.net>
3367 * tests/stty/basic-1: Work around an intermittent test failure
3368 on HP-UX 11.11. Report and analysis from Bob Proulx.
3369 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
3371 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
3373 * NEWS: Support obsolete usages like "sort +1 -2" even when
3374 conforming to POSIX 1003.1-2001, since this is a pure extension to
3375 POSIX. Problem reported by Christian in:
3376 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
3377 * src/sort.c (main): Implement this.
3379 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
3380 Autoconf 2.60 says this stuff was obsolete.
3382 2006-06-28 Jim Meyering <jim@meyering.net>
3384 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
3386 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
3388 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
3389 (set -x when VERBOSE=yes) when stderr is redirected before stdout
3390 causing shell tracing of the stdout redirection to be written to
3391 the stderr file. Avoid problem and test failure on HP-UX by
3392 redirecting stderr last.
3393 * tests/dd/unblock-sync: Order shell file redirections for
3394 stderr and stdout in the common style.
3395 tests/acl: Likewise.
3397 2006-06-27 Jim Meyering <jim@meyering.net>
3399 * tests/misc/cat-proc: Try to avoid any spurious numeric
3400 differences in frequently-changing /proc/cpuinfo.
3401 Reported by Nelson Beebe.
3403 2006-06-26 Jim Meyering <jim@meyering.net>
3405 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
3406 fd_to_subdirp failure, not just when errno == EACCES.
3407 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
3408 rmdir, here, even though rmdir may happen to be adequate.
3410 * NEWS: rm no longer fails to remove an empty, unreadable directory
3411 * src/remove.c (remove_cwd_entries): If we can't open a directory,
3412 and the failure is not being ignored, try to remove the directory
3413 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
3414 Problem report and test case from Paul Eggert in
3415 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
3417 * tests/rm/empty-inacc: New test, for the above.
3419 Avoid a segfault for wc --files0=- < /dev/null.
3420 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
3422 2006-06-25 Jim Meyering <jim@meyering.net>
3424 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
3425 contains a list of NUL-separated file names.
3427 * src/wc.c: Include "readtokens.h".
3428 (usage): Describe the new option, and adjust the `Usage':
3429 with this option, no FILE may be specified on the command line.
3430 (main): Handle the new option.
3431 * tests/misc/wc-files0: New tests, for the above.
3432 * tests/misc/wc-files0-from: Likewise.
3433 * tests/misc/Makefile.am (TESTS): Add wc-files0.
3435 2006-06-24 Jim Meyering <jim@meyering.net>
3437 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
3439 2006-06-22 Jim Meyering <jim@meyering.net>
3441 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
3442 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
3444 2006-06-19 Jim Meyering <jim@meyering.net>
3446 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
3447 so this check is not run as part of "make distcheck".
3449 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
3451 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
3453 2006-06-18 Jim Meyering <jim@meyering.net>
3455 * tests/misc/pwd-long: Make error output a little clearer.
3457 2006-06-17 Jim Meyering <jim@meyering.net>
3459 * tests/rm/inaccessible: Skip this test on systems without openat
3460 support. Reported by Bob Proulx.
3462 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
3464 * tests/misc/mknod: Improve permission checks to handle
3465 running mkdir test in set-gid directories.
3467 2006-06-14 Jim Meyering <jim@meyering.net>
3469 * tests/du/basic: Revamp not to hard-code file system block sizes.
3471 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
3473 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
3476 2006-06-11 Jim Meyering <jim@meyering.net>
3478 * .gitignore: New file.
3479 * Makefile.am (EXTRA_DIST): Add .gitignore.
3481 Setting TIME_STYLE=long-iso in the environment would make the
3482 cp/same-file test fail.
3483 * tests/envvar-check (vars): Add TIME_STYLE to the list.
3484 * tests/cp/same-file: Revert last change.
3485 Source the envvar-check script, to ensure that TIME_STYLE
3486 settings don't affect these tests.
3488 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
3490 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
3491 uses POSIX time stamp formats. Problem reported by John Nixon in
3492 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
3494 2006-06-10 Jim Meyering <jim@meyering.net>
3496 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
3498 Require a "Version N.M" line at the top of the ChangeLog
3499 file only when making the actual release, not when running
3501 * Makefile.maint (maintainer-distcheck): Don't depend on
3503 (alpha beta major): Depend on it here, instead.
3505 2006-06-08 Jim Meyering <jim@meyering.net>
3507 Ensure that cat works with any of the options, -A -v -e -E -T,
3508 when applied to files in /proc and /sys, even when the FIONREAD
3509 ioctl produces nonsensical results. Before this change, cat would
3510 produce no output (or truncated output), for some linux kernels.
3512 * src/cat.c (write_pending): New function, factored out of cat.
3513 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
3514 that there are bytes to read. Some versions of linux-2.6.16 do that.
3515 Write any pending output before returning.
3516 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
3517 * NEWS: Mention this bug fix.
3518 * tests/misc/cat-proc: New file. Test for the above.
3519 * tests/misc/Makefile.am (TESTS): Add cat-proc.
3521 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
3523 * src/expr.c (eval4): Detect overflow properly when multiplying
3526 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
3528 * NEWS: The 'expr' command now detects and reports integer overflow.
3529 (It would be better to use extended precision instead, but that
3530 would be more work.)
3531 * src/expr.c (integer_overflow): New function.
3532 (eval4, eval3): Check for integer overflow.
3534 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
3536 Fix problems when building with Solaris/SVR4/etc. make, which uses a
3537 different and somewhat bogus implementation of VPATH. In the
3538 directory tests/misc, rename tests whose names might appear in the
3539 Automake-generated rules. For example, we can't use a test named
3540 'test', since Automake generates a rule that contains the text
3541 "if test -f ./$$tst; ...", and this might expand to something like
3542 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
3543 which executes the 'test' script rather than the 'test' command.
3544 * tests/misc/false-status: Renamed from tests/misc/false.
3545 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
3546 * tests/misc/sort-merge: Renamed from tests/misc/sort.
3547 ($prog): Set to 'sort' rather than to $PROG.
3548 * tests/misc/test-diag: Renamed from tests/misc/test.
3549 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
3550 in case Solaris make has prepended the directory.
3551 (TESTS): Adjust to above renamings.
3552 * tests/misc/expand: Don't assign to PROG; no longer needed
3553 now that Makefile.am sets PROG to the basename.
3554 * tests/misc/fold: Likewise.
3556 2006-06-03 Jim Meyering <jim@meyering.net>
3558 Make `cp --link --no-dereference' work also on systems where the
3559 link system call cannot create a hard link to a symbolic link.
3560 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
3561 the link syscall on a symlink when it would do the wrong thing.
3562 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
3563 * tests/cp/link-no-deref: New file/test for the above.
3564 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
3565 * NEWS: Mention the change (doesn't affect Linux).
3567 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
3569 Fix some porting problems in the test cases reported by
3570 Ralf Wildenhues for HP-UX 11.23 in:
3571 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
3572 * tests/help-version: Don't assume that \< \> works in sed.
3573 * tests/misc/close-stdout: Don't assume that >&- works.
3574 Add a /dev/full test.
3575 * tests/touch/no-create-missing: Don't assume that >&- works.
3577 2006-05-30 Jim Meyering <jim@meyering.net>
3579 * src/ls.c (usage): Add `v' to the list of sorting-related options.
3582 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
3584 * tests/cp/fail-perm: source lang-default.
3585 * tests/rm/inaccessible: Likewise.
3587 2006-05-28 Jim Meyering <jim@meyering.net>
3589 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
3590 Recognize it, too. Reported by Ralf Wildenhues, in
3591 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
3593 2006-05-27 Jim Meyering <jim@meyering.net>
3595 * src/chgrp.c: Support new options: --preserve-root and
3596 --no-preserve-root. Somehow this program was skipped when those
3597 options were added to chown, chmod, and rm. Reported by
3598 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
3599 * NEWS: Mention this.
3601 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
3603 * NEWS: Remove mention of --seed. We'll replace it with something
3604 better, and don't want to indicate that it is supported.
3605 * src/sort.c (usage): Likewise.
3607 2006-05-20 Jim Meyering <jim@meyering.net>
3609 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
3611 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
3612 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
3613 FTS_COMFOLLOW. Spotted by Justin Pryzby.
3615 * gnupload: Merge changes from automake, retaining the ""--to...
3616 kludge to placate overzealous `make distcheck' check.
3618 2006-05-19 Jim Meyering <jim@meyering.net>
3620 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
3621 FTS_TIGHT_CYCLE_CHECK directory traversal option.
3622 Reported by Justin Pryzby in http://bugs.debian.org/367691
3624 2006-05-15 Jim Meyering <jim@meyering.net>
3626 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
3627 From Tomas Pospisek.
3629 2006-05-13 Jim Meyering <jim@meyering.net>
3631 * tests/mv/no-target-dir: Test two more cases.
3633 2006-05-11 Jim Meyering <jim@meyering.net>
3635 mv -T DIR EMPTY_DIR no longer fails unconditionally
3636 * src/copy.c (copy_internal): Don't manually prohibit a move where
3637 the destination is an existing directory. Sometimes doing that is
3638 valid. Let the rename system call enforce the rules. That is
3639 allowed only when the source is a directory and the destination
3640 directory (to be replaced) is empty. Reported by Eric Blake.
3641 * tests/mv/no-target-dir: New file/test for this.
3642 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
3643 * NEWS: Mention this.
3645 * tests/mv/atomic: New file/test for yesterday's fix.
3646 * tests/mv/Makefile.am (TESTS): Add atomic.
3648 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
3650 2006-05-10 Jim Meyering <jim@meyering.net>
3652 * src/copy.c (copy_internal): Don't explicitly unlink the destination
3653 when moving a symlink into the place of an existing non-directory.
3654 Reported by Joshua Hudson.
3655 * NEWS: mention this.
3657 2006-05-07 Jim Meyering <jim@meyering.net>
3659 * Makefile.maint (patch-check): Fail if patch generates any output,
3660 even merely for changed offsets.
3662 * src/c99-to-c89.diff: Adjust to reflect new offsets.
3664 * NEWS: Mention changes affecting df, pwd, shred.
3666 2006-05-06 Jim Meyering <jim@meyering.net>
3668 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
3669 system condition where dirent.d_ino != stat.st_ino.
3670 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
3672 2006-05-06 Eric Blake <ebb9@byu.net>
3674 * tests/ls/inode: Expand to test inode from readdir case.
3675 * tests/ls/follow-slink: Expand to test broken links encountered
3676 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
3678 2006-05-06 Eric Blake <ebb9@byu.net>
3680 * tests/mv/leak-fd: Work even on case-insensitive file system.
3682 2006-05-04 Jim Meyering <jim@meyering.net>
3684 * NEWS: Mention the 2006-03-19 pwd-related change that makes
3685 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
3687 2006-05-03 Jim Meyering <jim@meyering.net>
3689 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
3690 Use better macro parameter names: s/basename/key_name/,
3691 s/basefunc/key_cmp_func. Fix typo in comment.
3693 2006-04-29 Eric Blake <ebb9@byu.net>
3695 * src/ls.c (main): On systems with d_type, directories_first only
3696 implies format_needs_type, not format_needs_stat.
3698 2006-05-03 Jim Meyering <jim@meyering.net>
3700 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
3701 after comma in arg list, from Eric Blake.
3703 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
3705 * tests/misc/date (relative-3): New test, derived from a bug
3706 report by John Thomas McDole.
3708 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
3710 New option for ls: --group-directories-first.
3711 It makes ls list directories before files.
3712 * NEWS [New features]: Mention it.
3713 * src/ls.c (sort_type): Rearrange to use as an array index when
3714 choosing sort function; added new sort_numtypes member for
3716 (time_type): Add new time_numtypes member for compile-time check.
3717 (directories_first): New global variable.
3718 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
3719 (long_options): Add --directories-first.
3720 (main): Support new option.
3721 (is_directory): New function.
3722 (extract_dirs_from_files): Use it.
3723 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
3724 (LIST_SORTFUNCTION_VARIANTS): New macros.
3725 (sort_functions): New global variable.
3726 (sort_files): Use it.
3727 (usage): Document new option.
3729 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
3731 * src/shred.c (fillrand): The assertion was way too weak, due to
3732 what must be a typo. Strengthen it to its intended value.
3733 (dopass): Don't use alloca; it's not worth the aggravation here,
3734 since it's used only to get a page-aligned buffer, and page
3735 alignment doesn't buy us much here. I'm suspicious that alloca
3736 causes problems on some hosts, due to a recent bug report by Adam
3737 Waltman: http://bugs.gentoo.org/130246.
3739 2006-04-18 Jim Meyering <jim@meyering.net>
3741 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
3742 sha384sum, sha512sum.
3744 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
3746 * src/chmod.c (describe_change): Adjust to filemode changes.
3747 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
3748 (print_long_format): Use (new) filemodestring rather than
3749 (old) mode_string, so that we get more file types right, at least
3750 in theory. Adjust to filemode changes.
3751 * src/stat.c (human_access): Likewise.
3753 2006-04-18 Jim Meyering <jim@meyering.net>
3755 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
3756 ignore file. This has never been enabled. Reported by Eric Blake.
3758 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
3760 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
3761 bug in Interix. Just call symlink or link directly. All uses changed.
3762 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
3763 * src/stat.c (USE_STATVFS): New macro.
3764 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
3765 (NAMEMAX_FORMAT): define a bit more clearly, now that the
3766 statvfs-using code is a bit more regular.
3767 * src/system.h (sync) [!HAVE_SYNC]: New macro.
3769 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
3771 * NEWS: csplit, nl, expr now conform to POSIX better, and are
3772 more-compatible with traditional Unix, with respect to regular
3774 * src/csplit.c (extract_regexp): Set re_syntax_options to a
3775 value that is compatible with what POSIX requires.
3776 * src/nl.c (build_type_arg): Likewise.
3777 * src/expr.c (docolon): Likewise. Also, don't let anchors match
3778 newline; this fixes an incompatibility with tradition and with POSIX.
3779 Don't warn about leading ^. POSIX says it is unspecified whether
3780 ^ is a special character, which means that implementations can
3781 either treat it as special or not, but either way a warning is not
3782 allowed (unless the regexp is otherwise invalid). Instead, anchor
3783 the expression but treat ^ as an anchor; this is the traditional
3784 behavior (e.g., Solaris 10).
3785 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
3786 and the like as invalid expressions (exit status 2), not as
3787 failure of 'expr' (exit status 3). This is more consistent with
3788 how Solaris behaves.
3789 * tests/expr/basic (fail-a): Adjust exit status to match new expr
3790 behavior, for status 2 versus 3.
3792 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
3793 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
3794 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
3795 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
3796 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
3797 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
3798 (bre61, bre62): New tests.
3799 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
3800 conforming to POSIX.
3803 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
3804 "if !". Do not assume that 'sed' can handle long, newline-free input.
3805 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
3807 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
3809 Adjust to new regex.h API (with new fastmap type), and clean
3810 up the regex storage allocation a bit.
3812 * src/csplit.c (struct control): Put re_compiled member at the
3813 end, since it's large. Change regexpr member from char * to bool;
3814 all uses changed. Add new member fastmap.
3815 (extract_regexp): regexp arg is now char const *, not char *.
3816 Don't bother duplicating the regular expression; it's not needed.
3817 Set fastmap from new fastmap member. Don't bother allocating
3818 a buffer, as the regexp code does a better job than we do.
3819 * src/expr.c (docolon): Allocate and use a fastmap.
3820 Don't bother allocating a buffer.
3821 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
3823 (build_type_arg): New fastmap arg. All uses changed.
3824 Don't bother allocating a buffer, but set a fastmap.
3825 * src/ptx.c (context_regex_string, word_regex_string): Remove.
3826 (context_regex, word_regex): New vars, replacing the above.
3828 (struct regex_data): New type.
3829 (compile_regex): Renamed from alloc_and_compile_regex, since
3830 we no longer allocate storage. Arg is now a struct regex_data *,
3831 not a const char *. All uses changed. Don't allocate the fastmap;
3832 instead, take it from the caller. Don't convert size_t to int,
3833 to avoid arithmetic overflow problems. Don't bother freeing
3834 storage afterwards; it's not worth the aggravation.
3835 * src/tac.c (compiled_separator_fastmap): New ver.
3836 (main): Use it. Don't bother allocating a buffer.
3838 2006-03-30 Jim Meyering <jim@meyering.net>
3840 * src/dd.c (iwrite): Remove assignment without effect.
3841 Reported by Felix Rauch Valenti.
3843 2006-03-22 Eric Blake <ebb9@byu.net>
3845 * src/ptx.c (usage): Remove mention of --copyright/-C.
3846 (main): Alias --copyright to --version plus a deprecation warning.
3847 * NEWS: Mention this.
3849 2006-03-27 Jim Meyering <jim@meyering.net>
3851 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
3852 use of strtod. Tiny patch from Nickolai Zeldovich.
3854 2006-03-11 Eric Blake <ebb9@byu.net>
3856 * tests/misc/dirname: New file.
3857 * tests/basename/Makefile.am: Delete.
3858 * tests/basename/basic: Move to...
3859 * tests/misc/basename: ... this new file. Add some tests,
3860 including fixed behavior for //.
3861 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
3862 * tests/Makefile.am (SUBDIRS): Remove basename.
3863 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
3865 Improvements to dirname/basename handling on platforms like
3866 cygwin with distinct // and with drive letters.
3867 * NEWS: Document new behavior.
3868 * src/basename.c (main): Don't strip suffix from file system
3870 * src/cp.c (target_directory_operand): Use new last_component.
3871 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
3872 traversing the string.
3873 * src/dircolors.c (guess_shell_syntax): Use new last_component.
3874 * src/install.c (target_directory_operand, install_file_in_dir):
3876 * src/ln.c (target_directory_operand, main): Likewise.
3877 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
3878 * src/mv.c (target_directory_operand, movefile): Likewise.
3879 * src/remove.c (rm_1): Likewise.
3880 * src/shred.c (wipename): Likewise.
3881 * src/split.c (next_file_name): Likewise.
3882 * src/su.c (log_su, run_shell): Likewise.
3884 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
3886 * NEWS: nohup diagnostics are now more precise, and nohup now
3887 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
3888 * src/nohup.c (main): Implement this.
3889 * tests/misc/nohup: Test the new behavior.
3891 2006-03-12 Jim Meyering <jim@meyering.net>
3893 * src/copy.c (set_author): Rename function, from preserve_author.
3895 * src/remove.c (AD_pop_and_chdir): Use new macro,
3896 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
3898 * src/system.h (SAME_INODE): Remove definition.
3899 Include "same-inode.h", instead.
3901 2006-03-11 Eric Blake <ebb9@byu.net>
3903 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
3905 2006-03-10 Jim Meyering <jim@meyering.net>
3907 Fix a bug whereby a user with write access to a directory being removed
3908 could cause the removal of that directory to fail with an erroneous
3909 diagnostic about a directory cycle. Reported by Vineet Chadha.
3911 * NEWS: Mention this.
3912 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
3913 leave (and try to rmdir) is the one whose dev_ino is being used to
3914 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
3916 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
3918 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
3919 * src/dd.c (set_fd_flags): Handle file-creation flags on file
3920 descriptors, rather than ignoring them.
3921 * tests/dd/misc: Add test cases for append, nofollow, directory,
3922 and nolinks flags. Simplify redirection to /dev/null in some cases.
3924 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
3925 noatime test never tested anything.
3927 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
3929 * src/dd.c (flags, usage): New flags directory, nolinks.
3930 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
3932 * src/ls.c (usage): Mention that -f disables --color.
3933 Problem reported by Niels Möller.
3935 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
3937 * man/*.x: Add references to syscalls from utilities of the same name.
3939 2006-03-05 Jim Meyering <jim@meyering.net>
3941 * tests/help-version: Set SHELL, if not already set, in order to
3942 avoid failure when `make check' is run through debuild; dircolors
3943 would fail due to lack of $SHELL. Reported by Sven Joachim.
3945 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
3946 * src/base64.c (wrap_write, do_encode, main): Change type of
3947 parameters and locals, wrap_column, form size_t to uintmax_t.
3948 (main): Adjust to use xstrtoumax, accordingly.
3950 2006-03-03 Jim Meyering <jim@meyering.net>
3952 Don't fail when run from an environment with SHELL not a Bourne
3953 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
3954 * tests/dircolors/simple: Invoke each non-failing test with -b.
3955 Reported by Michael Stone.
3957 2006-02-27 Jim Meyering <jim@meyering.net>
3959 * tests/misc/base64: Derive --decode-using tests from the
3962 * tests/misc/base64: Factor out a long constant string.
3963 Split lines to stay within 80 columns.
3965 * tests/misc/Makefile.am (TESTS): Add base64.
3966 * tests/misc/base64: Test base64. From Simon Josefsson.
3968 * src/base64.c (do_decode): Use correct type for parameter,
3969 ignore_garbage: s/size_t/bool/.
3971 * src/base64.c: Don't include .h files already included by system.h:
3972 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
3973 Include "system.h" before the other lib/*.h header files.
3974 Include <sys/types.h> before "system.h".
3975 (wrap_write): Remove declaration of unused local, initial_column.
3976 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
3978 * README: Add base64 to the list.
3980 2006-02-17 Simon Josefsson <jas@extundo.com>
3982 New program: base64.
3983 * AUTHORS: Mention base64.
3985 * man/Makefile.am: Build base64.1.
3986 * man/base64.x: New file.
3987 * src/Makefile.am (bin_PROGRAMS): Add base64.
3988 * src/base64.c: New file.
3990 2006-02-25 Eric Blake <ebb9@byu.net>
3992 In ls, avoid calling stat for --inode (-i), when possible.
3993 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
3994 * src/system.h: ... here, for use in ...
3995 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
3997 (gobble_file): Add inode argument.
3998 (print_dir): Pass inode if available.
3999 (usage): Remove inaccuracy.
4001 2006-02-23 Jim Meyering <jim@meyering.net>
4003 * TODO: Update/correct some obsolete entries.
4005 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
4007 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
4008 * src/join.c (usage): Likewise.
4009 Documentation problem reported by Philip Kensche.
4011 2006-02-20 Eric Blake <ebb9@byu.net>
4013 * man/rm.x: Update documentation to match previous patch.
4015 2006-02-18 Eric Blake <ebb9@byu.net>
4017 New option for rm: --interactive=once (-I).
4018 * NEWS: Document it, along with change to rm --interactive.
4019 * TODO: Remove entry for implementing rm -I
4020 * src/rm.c (INTERACTIVE_OPTION): New enum value.
4021 (interactive_type): New enum.
4022 (long_opts): Let interactive take an optional argument.
4023 (interactive_args, interactive_types): New option arguments.
4024 (usage): Document -I, --interactive=WHEN. Use program_name
4025 instead of a basename.
4026 (main): New -I option, new behavior to --interactive.
4027 * tests/rm/interactive-once: New tests.
4028 * tests/rm/interactive-always: Ditto.
4029 * tests/rm/Makefile.am (TESTS): Run them.
4031 2006-02-18 Jim Meyering <jim@meyering.net>
4033 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
4034 expression match more of the target lines, e.g., those that start with
4035 `-S,' (short option followed by a comma) or that include `=[...]'.
4036 Patch by Nicolas François.
4037 Fix the four offenders thus exposed:
4038 * src/join.c (usage): Use two spaces (not one) to separate the
4039 --first-only option string from its description, so help2man formats
4040 the derived man page properly.
4041 * src/pr.c (usage): Likewise.
4042 * src/uniq.c (usage): Likewise.
4043 * src/install.c (usage): Likewise.
4045 2006-02-15 Jim Meyering <jim@meyering.net>
4047 * Makefile.maint (alpha beta major): For `make major', ensure that the
4048 version string is of the form N.N[.N]*, where N is one or more digits.
4050 2006-02-14 Jim Meyering <jim@meyering.net>
4052 * INSTALL: Update from gnulib.
4054 2006-02-13 Jim Meyering <jim@meyering.net>
4056 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
4058 2006-02-12 Jim Meyering <jim@meyering.net>
4060 * Makefile.maint (patch-check): New target.
4061 (local-checks-available): Add to the list.
4063 2006-02-11 Jim Meyering <jim@meyering.net>
4065 * src/c99-to-c89.diff: New file.
4066 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
4068 * .x-po-check: New file, with exclusions so that `make distcheck'
4070 * Makefile.am (EXTRA_DIST): Add .x-po-check.
4072 rm -r must remove an empty directory, even if it is inaccessible.
4073 * src/remove.c (close_preserve_errno): New function.
4074 (fd_to_subdirp): Don't print a diagnostic in this function.
4075 Do it from the callers instead, unless rmdir succeeds.
4076 (remove_cwd_entries, remove_dir): Adjust callers.
4077 * tests/rm/empty-inacc: New test for the above.
4078 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
4079 * NEWS: Mention this bug fix.
4080 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
4081 a tiny bit less precise: cannot remove `a/1': ... instead of
4082 cannot open directory `a/1': ...
4084 * Makefile.maint (syntax-check-rules): Automatically derive this
4085 list of sc_-prefixed rule names.
4087 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
4089 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
4090 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
4091 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
4092 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
4093 go away? was that an accident?)
4094 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
4095 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
4096 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
4097 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
4098 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
4099 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
4100 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
4101 (author_mark_check, makefile_path_separator_check):
4102 Output line numbers, to simplify navigation of Emacs *compilation*
4104 (sc_prohibit_atoi_atof, sc_file_system):
4105 Rework slightly so that Makefile.maint doesn't get reported as a
4106 violation of its own syntax rules.
4107 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
4108 it at run-time (which didn't work with Bison). Fix a makefile typo,
4109 caught by Makefile.maint itself: spaces where a tab should be.
4110 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
4111 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
4112 Ignore djgpp and man subdirectories, to avoid false matches with
4113 Bison and coreutils, respectively. Use sort -u to remove the
4114 resulting duplicates.
4115 * gnupload: Rework slightly to avoid bogus warning from
4116 sc_two_space_separator_in_usage.
4118 2006-02-10 Jim Meyering <jim@meyering.net>
4120 Use gzip's --rsyncable option only if it's available.
4121 * Makefile.maint (gzip_rsyncable): New variable.
4124 2006-02-08 Jim Meyering <jim@meyering.net>
4126 * Makefile.maint (local-checks-available): Define in terms of
4127 the expansion, $(syntax-check-rules), rather than the single,
4128 top-level target `syntax-check', so that it's easier to exclude
4129 individual rules (via $(local-checks-to-skip)).
4130 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
4132 2006-02-07 Jim Meyering <jim@meyering.net>
4134 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
4135 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
4137 * tests/help-version (expected_failure_status_vdir):
4138 Redirect an expected disk-full diagnostic to /dev/null.
4140 2006-02-06 Jim Meyering <jim@meyering.net>
4142 * src/unexpand.c (usage): Use two spaces (not one) to separate the
4143 --first-only option string from its description, so help2man formats
4144 the derived man page properly.
4145 * src/rm.c (usage): Likewise for --no-preserve-root.
4146 * src/chown.c (usage): Likewise.
4147 * src/chgrp.c (usage): Likewise.
4149 Add a rule to ensure that the above doesn't happen again.
4150 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
4151 (syntax-check-rules): Add it.
4152 * .x-sc_two_space_separator_in_usage: New empty file.
4153 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
4155 2006-02-06 Jim Meyering <jim@meyering.net>
4157 * src/cp.c (usage): Use two spaces (not one) to separate each
4158 option string from its description, so help2man formats the
4159 derived man page properly.
4160 * src/mv.c (usage): Likewise.
4161 Patch from Nicolas François in http://bugs.debian.org/351601.
4163 2006-02-04 Jim Meyering <jim@meyering.net>
4165 * src/copy.c (copy_internal): cp -RL would fail when encountering
4166 the same directory more than once in the hierarchy beneath a single
4167 command-line argument. That is legitimate, e.g. when there are
4168 two or more symbolic links, each pointing to some directory that
4169 would not otherwise be copied. Reported by Christophe LYON.
4170 * tests/cp/cp-deref: New file. Test for today's fix.
4171 * tests/cp/Makefile.am (TESTS): Add cp-deref.
4172 * NEWS: Document this.
4174 2006-02-03 Jim Meyering <jim@meyering.net>
4176 * configure.ac: Require automake-1.9.6, not 1.8.3.
4178 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
4180 * src/od.c (usage): Mention that -t a ignores high order bit.
4181 Documentation problem reported by Ed Avis.
4183 2006-02-01 Jim Meyering <jim@meyering.net>
4185 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
4187 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
4189 * src/head.c (main): Use a better diagnostic when someone uses a
4190 trailing numeric option in an invalid way. Problem reported by
4192 * src/tail.c (parse_options): Likewise.
4194 2006-01-30 Jim Meyering <jim@meyering.net>
4196 * man/wc.x: Include `count' keyword in man page synopsis,
4197 per suggestion from http://bugs.debian.org/181585.
4199 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
4201 * src/df.c (show_dev): If the file system claims to have
4202 more available than total blocks, report the number of used
4203 blocks as being total - available (a negative number) rather
4204 than as garbage. Problem reported by Toralf Foerster.
4206 2006-01-24 Jim Meyering <jim@meyering.net>
4208 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
4209 to put a regular file in O_NONBLOCK mode fails with EPERM.
4210 That happens on Linux (up to 2.6.15) when using tail -f on a file with
4211 the append-only attribute. Reported by Dean Gaudet. For details,
4212 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
4213 * NEWS: Mention this fix.
4214 * tests/tail-2/append-only: New file. Test for the above.
4215 * tests/tail-2/Makefile.am (TESTS): Add append-only.
4216 * tests/Makefile.am (check-root): Add tail-2/append-only
4218 2006-01-21 Jim Meyering <jim@meyering.net>
4220 * NEWS: Mention fts-related improvements and bug fixes.
4222 2006-01-19 Jim Meyering <jim@meyering.net>
4224 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
4225 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
4227 2006-01-18 Jim Meyering <jim@meyering.net>
4229 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
4231 2006-01-17 Jim Meyering <jim@meyering.net>
4233 Now that fts no longer changes the current working directory, adjust
4234 its clients accordingly -- note that du.c uses fts but doesn't need
4235 any adjustment, since it doesn't operate on the actual files,
4236 but rather just uses the stat buffers provided by fts.
4238 * src/chown-core.c: Include "openat.h".
4239 Don't include "lchown.h".
4240 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
4241 calling openat, lchownat, chownat, rather than open, lchown, chown.
4243 * src/chmod.c: Include "openat.h".
4244 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
4246 * tests/du/long-from-unreadable: New test, to exercise one small
4249 2006-01-13 Jim Meyering <jim@meyering.net>
4251 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
4252 addition of new directories under tests/.
4254 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
4257 2006-01-12 Jim Meyering <jim@meyering.net>
4259 * tests/du/long-sloop: Adjust not to hard-code the expected
4260 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
4261 from that of GNU libc. Reported by Paul Eggert.
4263 * tests/du/long-sloop: Create file at end of symlink chain.
4265 * tests/misc/test: New file, with a test for one of the
4266 bugs fixed by yesterday's test.c changes.
4267 * tests/misc/Makefile.am (TESTS): Add test.
4269 2006-01-11 Jim Meyering <jim@meyering.net>
4271 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
4272 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
4273 a very long sequence of symbolic links (not necessarily a loop).
4274 * tests/du/Makefile.am (TESTS): Add long-sloop.
4276 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
4278 * src/test.c (test_syntax_error): Append a newline. All callers
4279 changed, except for the ones that didn't already append a newline.
4280 Bug reported by Eric Blake.
4282 2006-01-11 Jim Meyering <jim@meyering.net>
4284 * src/system.h (X2NREALLOC): Now that verify_true is no longer
4285 void, cast its result to void, to avoid gcc's warning that
4286 ``left-hand operand of comma expression has no effect''.
4287 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
4289 2006-01-10 Jim Meyering <jim@meyering.net>
4291 * tests/chmod/no-x: Add a test for today's fts.c fix.
4293 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
4295 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
4296 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
4298 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
4300 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
4301 Use verify_true instead of verify_expr, to sync with gnulib.
4303 2006-01-08 Jim Meyering <jim@meyering.net>
4305 * src/date.c (usage): Adjust the formatting of the entries for
4306 %::z and %:::z (separate with two spaces, not one) so that help2man
4307 formats them properly. Reported by Philip Rowlands.
4309 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
4311 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
4313 2006-01-06 Jim Meyering <jim@meyering.net>
4315 * Makefile.maint (copyright-check): Use date +%Y in place of
4318 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
4319 First off, the attribute should have been `volatile' (not static)
4320 to avoid longjmp-related risk of clobber. Secondly, now there is
4321 no longer any risk of a local variable being clobbered, so there's
4322 no need for any attribute at all.
4324 2006-01-05 Jim Meyering <jim@meyering.net>
4326 * src/remove.c: Give a few functions the inline attribute.
4327 (AD_pop_and_chdir): Use gotos to avoid some duplication.
4328 (AD_push): Rewrite an assertion so that the entire computation
4329 goes away when assertions are turned off.
4331 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
4332 It's already defined in "system.h".
4333 * Makefile.maint: Add a FIXME comment.
4335 2006-01-04 Jim Meyering <jim@meyering.net>
4337 * ChangeLog: Remove entries from 2005-10-22 and earlier.
4338 * ChangeLog-2005: New file, for entries up to version 5.92.
4340 2006-01-03 Jim Meyering <jim@meyering.net>
4342 * tests/du/no-x: Also allow a slightly different diagnostic -- the
4343 one you get when using openat-enabled fts.c and du (coming soon).
4344 * tests/chmod/no-x: Likewise.
4345 * tests/chgrp/no-x: Likewise.
4347 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
4349 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
4351 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
4352 (restricted_chown): Return it, if the file cannot be accessed due
4353 to EPERM, or if no uid or gid are required, or if the file is
4354 neither a directory nor a regular file. Rewrite to avoid gotos.
4355 (change_file_owner): Handle RC_do_ordinary_chown case.
4356 Rewrite to avoid gotos.
4357 * tests/chgrp/basic: Make sure we can change the group of
4360 * src/date.c (usage): Explain %g, %G, and %V a bit better.
4362 2006-01-02 Jim Meyering <jim@meyering.net>
4364 * src/copy.c (set_owner): Correct a comment.
4366 * src/tail.c (parse_options): Change warning to say that --retry
4367 is useful `mainly' (not `only') when following by name.
4368 Reported here: http://bugs.debian.org/273781
4370 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
4372 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
4373 * src/copy.c: Include lchmod.h.
4374 (copy_internal): Use lchmod rather than chmod.
4375 * src/cp.c: Include lchmod.h.
4376 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
4377 * src/mkdir.c: Include lchmod.h.
4378 (usage): Clarify -m's operation.
4379 (main): Use lchmod rather than chmod. Don't use lchmod unless the
4380 new mode contains bits outside the 777 range.
4381 * src/mkfifo.c (usage): Clarify -m's operation.
4382 (main): If -m is given, don't invoke chmod; use umask 0 instead.
4383 Report an error if -m asks for bits outside the 777 range.
4384 * src/mknod.c (usage, main): Likewise.
4386 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
4388 2005-12-27 Jim Meyering <jim@meyering.net>
4390 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
4391 (sc_prohibit_assert_without_use): New rule.
4392 (syntax-check-rules): Add it to the list.
4393 * .x-sc_prohibit_assert_without_use: New empty file.
4394 * Makefile.am (EXTRA_DIST): Add it.
4396 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
4398 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
4399 Don't include <assert.h>; it wasn't used.
4401 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
4403 * src/chown-core.c (restricted_chown):
4404 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
4405 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
4406 | O_NOFOLLOW too, for consistency with other dir-openers.
4407 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
4408 (is_empty_dir): Likewise.
4409 * src/shred.c (wipename): Likewise. Don't bother trying to open
4410 dir for writing, since POSIX prohibits it.
4412 2005-12-22 Jim Meyering <jim@meyering.net>
4414 * tests/help-version: Redirect stderr to /dev/full, to suppress
4415 write error diagnostic.
4417 2005-12-19 Jim Meyering <jim@meyering.net>
4419 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
4420 Avoid a minor race condition when `-m MODE' is specified, by using
4421 open, fchown, and close rather than just chown. To do that reliably --
4422 even with an overly restrictive umask -- ensure that each mkdir,
4423 mknod and mkfifo call uses a mode including at least owner-read access.
4424 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
4425 the subsequent chown (or equivalent open,fchown,close) fails.
4426 * tests/misc/mknod: New tests.
4427 * tests/misc/Makefile.am (TESTS): Add mknod.
4429 2005-12-17 Jim Meyering <jim@meyering.net>
4431 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
4432 e.g., on a named pipe.
4433 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
4434 place of all uses, since it is guaranteed (system.h) to be defined.
4436 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
4438 Add POSIX ACL support
4439 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
4440 is no requirement for ACL support; particularly, it does not exist
4441 on systems that have POSIX ACLs.
4442 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
4443 * src/cp.c (umask_kill): With default acls, the umask is not to be
4444 applied. Remove umask_kill, don't change the process umask, and let
4445 the kernel apply the umask where appropriate.
4446 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
4447 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
4449 (copy_reg, copy_internal): Use copy_acl and set_acl
4450 instead of fchown/chown. Fix the logic for POSIX ACLs.
4451 (chown_succeded): Remove; we now always copy acls and
4452 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
4453 did a chown before or not.
4454 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
4455 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
4456 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
4457 to link with it via $(LIB_ACL), for the utilities that need it.
4459 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
4461 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
4462 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
4463 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
4464 value is now signified by whether cwd_errno is null.
4465 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
4466 pointer-to-bool to pointer-to-errno-value. All callers changed.
4467 (rm_1): Don't bother setting a local cwd failure flag and then
4468 ORing it into the caller's. Just set the caller's.
4469 (rm): Use cwd failure errno value to print a slightly-better
4472 2005-12-15 Jim Meyering <jim@meyering.net>
4474 * src/stat.c (print_it): Properly handle a backslash at the
4475 end of a --printf format string. Reported by Paul Eggert.
4476 * tests/misc/stat-printf (end-bs): Add a test for the above.
4478 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
4480 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
4481 Don't assume /etc/passwd contains user names; use 'id' instead.
4483 2005-12-15 Jim Meyering <jim@meyering.net>
4485 stat: revert behavior of --format=FMT (-c)
4486 stat: add new option: --printf=FMT
4487 * NEWS: Mention this.
4488 * src/stat.c (isodigit, octtobin, hextobin): Define.
4489 (PRINTF_OPTION): Define.
4490 (interpret_backslash_escapes, trailing_delim): New globals.
4491 (usage): Document them. Alphabetize on long option names.
4492 (print_esc_char): New function.
4493 (print_it): Rewrite, in order to handle backslash escapes.
4494 (main): Handle new option. Set globals for --format, too.
4496 * tests/misc/stat-printf: Test --printf and --format.
4497 * tests/misc/Makefile.am (TESTS): Add stat-printf.
4499 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
4501 * NEWS: sort now reports incompatible options.
4502 * src/sort.c (incompatible_options, check_ordering_compatibility):
4504 (main): Use them. Don't bother with a usage message for
4505 "sort -c a b", for consistency with other error diagnostics.
4506 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
4509 * src/cat.c (main): Undo previous change. close_stdout already
4510 does the check, so the previous change wasn't necessary.
4512 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
4514 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
4516 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
4518 Install a more-conservative approach for sort -R. It's the
4519 same basic idea as the existing code, except it uses the full ISAAC
4520 approach (called the "more kosher" approach in the existing comments).
4521 This makes "sort -R" quite a bit slower (about a factor of 2 on my
4522 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
4523 better to be conservative here at first, and review any performance
4524 improvements carefully.
4525 * .x-sc_require_config_h: Add src/rand-isaac.c.
4526 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
4527 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
4528 (shred_SOURCES, sort_SOURCES): Remove.
4529 (EXTRA_DIST): Add rand-isaac.c.
4530 * src/rand-isaac.c: Revert to what used to be in shred.c, without
4531 changing it to allow for varying numbers of words in the state.
4532 Alter so that we include rand-isaac.c directly rather than
4533 compiling it and linking to it. Don't include config.h or
4534 system.h; that's the includer's responsibility.
4535 Omit functions that are specific to shred.
4536 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
4537 (isaac_step, struct irand_state):
4538 Resurrect these, with the same defns that used to be in shred.c.
4539 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
4540 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
4542 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
4543 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
4544 (irand_init, irand32, irand_mod):
4545 Number of words is constant again.
4546 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
4547 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
4548 * src/sort.c: Likewise.
4549 * src/shred.c (fillrand, dopass, main): Undo previous change.
4550 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
4552 * src/sort.c: Don't include md5.h; it wasn't needed.
4553 (struct keyfield): Rename random_hash to random, for consistency
4554 with the other member names. All uses changed.
4555 (usage): Tweak wording to mention STRING for --seed option.
4556 (short_options): Rorder for consistency with other programs.
4557 (rand_state): Now a struct, not a pointer to one. All uses changed.
4558 (HASH_WORDS, HASH_SIZE): Remove.
4559 (get_hash): Remove comments around resbuf size, since we can assume C89.
4560 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
4561 (keycompare): Adjust to the new get_hash.
4563 (badfieldspec): Omit recently-introduced comment; it isn't needed.
4564 (main): Don't set need_random simply because gkey has it set; that
4565 doesn't necessarily mean we'll need random numbers.
4566 Redo seeding to match new get_hash approach.
4568 2005-12-10 Jim Meyering <jim@meyering.net>
4570 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
4572 Avoid shred segfault on 64-bit systems.
4573 * src/rand-isaac.c (isaac_refill): Don't try to negate a
4574 local of type uint32_t. Make the local an `int' instead.
4576 * NEWS: Mention sort's new options.
4578 * src/rand-isaac.c (isaac_mix): Declare to be static.
4579 Mark all other functions as `extern' so the tight-scope
4580 part of `make distcheck' passes once again.
4581 * src/rand-isaac.h (isaac_mix): Remove declaration.
4583 * src/sort.c (get_hash): Change position of `*' in parameter
4584 type to conform with convention.
4585 (main): Split a long line so it fits in 80 columns.
4586 (keycompare): Remove stray SPACE before TAB that was
4587 causing `make distcheck' to fail.
4589 * src/shred.c: Don't include gethrxtime.h. No longer needed.
4591 * tests/misc/sort-rand: New file: basic tests for the new options.
4592 * tests/misc/Makefile.am (TESTS): Add sort-rand.
4594 2005-12-10 Frederik Eaton <frederik@ofb.net>
4596 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
4597 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
4598 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
4599 Make state size runtime-configurable.
4600 (isaac_new, isaac_copy): New functions.
4601 * src/rand-isaac.h: New file.
4602 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
4603 (fillrand, main): Adjust to the fact that the state size is now
4604 runtime-configurable.
4605 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
4606 (usage): Add options --random-sort and --seed to implement a random
4608 Include md5.h and rand-isaac.h.
4609 (get_hash): New function.
4610 (rand_state): New var.
4611 (HASH_WORDS, HASH_SIZE): New macros.
4613 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
4615 * tests/dd/misc: Add test for dd iflags=noatime.
4617 2005-12-09 Jim Meyering <jim@meyering.net>
4619 * src/sort.c (usage): Mention white space vs -b and -t options.
4622 2005-12-09 Eric Blake <ebb9@byu.net>
4624 * src/test.c (main): Fix misleading comment.
4626 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
4628 * NEWS: Mention dd's new noatime flag.
4629 * src/system.h (O_NOATIME): Define to 0 if not already defined.
4630 * src/dd.c (flags, usage): Add support for noatime flag.
4632 2005-12-07 Jim Meyering <jim@meyering.net>
4634 Distribute the cvsu script, used only by `make syntax-check'.
4635 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
4636 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
4637 distribute a copy of this script.
4638 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
4640 * tests/mv/acl: exit-77 before the trap, not after, if we fail
4641 to create a temporary directory on another partition.
4642 From Andreas Gruenbacher.
4644 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
4646 * man/basename.x: Cross-reference to dirname and readlink.
4647 * man/dirname.x: Cross-reference to basename and readlink.
4649 2005-12-05 Andreas Gruenbacher
4651 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
4652 (set_owner, preserve_author): New functions, factored out of copy_reg.
4653 (copy_reg): Use them.
4654 (copy_internal): Use them here, too.
4656 2005-12-04 Jim Meyering <jim@meyering.net>
4658 * src/sleep.c (usage): Say what happens with two or more arguments.
4659 Suggested by Justin Pryzby.
4661 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
4664 2005-12-03 Jim Meyering <jim@meyering.net>
4666 * src/rm.c (long_opts): Change the name of each undocumented, for-
4667 testing-only option to start with `-', so that it cannot render
4668 ambiguous any prefix it happens to share with some other option name.
4669 Problem reported by Eric Blake.
4670 * src/head.c (long_options): Likewise.
4671 * src/tail.c (long_options): Likewise.
4673 * tests/misc/head-elide-tail: Update uses of undocumented, for-
4674 testing-only --presume* options to start with `---'.
4675 * tests/rm/dangling-symlink: Likewise.
4676 * tests/rm/dir-no-w: Likewise.
4677 * tests/rm/isatty: Likewise.
4679 2005-11-30 Jim Meyering <jim@meyering.net>
4681 * Makefile.maint: Add a comment about cvsu.
4683 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
4685 * NEWS: df updates for "none", "proc", inaccessible file systems.
4686 * src/df.c (show_point): Ignore inaccessible file systems.
4687 (usage): -a includes dummy file systems, not size-0 file systems.
4689 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
4690 to avoid collision with POSIX name space. All uses changed.
4692 2005-11-24 Jim Meyering <jim@meyering.net>
4694 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
4695 * tests/acl: Add `$0: ' prefix to diagnostics.
4697 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
4699 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
4701 * src/copy.c: Improve performance a bit by optimizing away
4702 unnecessary system calls and going to a block size of at least
4703 8192 (on normal hosts, anyway). This improved performance 5% on my
4704 Debian stable host (2.4.27 kernel, x86, copying from root
4705 ext3 file system to itself).
4706 Include "buffer-lcm.h".
4707 (copy_reg): Omit last argument. All callers changed.
4708 Use xmalloc to allocate rather than trusting alloca
4709 (which is unwise with large block sizes).
4710 Declare locals more locally, if possible.
4711 Use uintptr_t words instead of int words, for a bit more speed
4712 when looking for null blocks on 64-bit hosts.
4713 Optimize away reads of zero bytes on regular files.
4714 In the typical case, insist on 8 KiB buffers, at least.
4715 Avoid unnecessary extra call to fstat when checking for sparse files.
4716 Avoid now-unnecessary cast to off_t, and "0L".
4717 Avoid unnecessary test of *new_dst when checking for same owner
4720 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
4722 * src/remove.c (rm): Don't assume C99 for-loop syntax.
4724 2005-11-22 Jim Meyering <jim@meyering.net>
4726 * src/remove.c (AD_push): Remove debugging cruft.
4728 * tests/rm/unread2 (rm): Change expected diagnostic,
4729 `cannot open directory' to `cannot remove', to align with
4731 * tests/rm/rm2: Ensure that rm now continues removing entries
4732 even after certain types of failure.
4734 * src/remove.c: Rewrite. Now, this module is reentrant on systems
4735 that provide openat (Solaris), and on systems like Linux+procfs
4736 where our openat emulation code is reentrant. This also fixes a
4737 few low-probability leaks and eliminates some code that could,
4738 in very unusual circumstances, cause rm() (via a callee) to exit.
4739 * NEWS: Mention this.
4741 * configure.ac: Put copyright dates all on one line so the
4742 emacs function that updates them works properly.
4744 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
4746 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
4747 Problem reported by Eric Blake.
4748 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
4749 we get a standard-conforming compiler. This relies on the new
4750 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
4751 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
4752 m4/c.m4 can go away with Autoconf 2.60 comes out.
4754 2005-11-17 Jim Meyering <jim@meyering.net>
4756 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
4757 (AD_mark_current_as_unremovable): Likewise, but for a local.
4760 * tests/mv/acl: Let traps handle removing temporary directories.
4762 Expect acl-related tests to fail, until the corresponding
4763 patches are committed.
4764 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
4765 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
4767 ACL tests, from Andreas Gruenbacher.
4768 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
4769 * tests/mv/Makefile.am (TESTS): Add acl.
4770 * tests/cp/Makefile.am (TESTS): Add acl.
4772 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
4774 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
4776 * NEWS: Improve quality of ln's diagnostics.
4777 * src/ln.c (do_link, usage): Likewise.
4778 (do_link): Don't use alloca on a buffer of unbounded size.
4780 2005-11-16 Jim Meyering <jim@meyering.net>
4782 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
4783 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
4784 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
4785 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
4786 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
4788 2005-11-14 Jim Meyering <jim@meyering.net>
4790 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
4792 2005-11-13 Jim Meyering <jim@meyering.net>
4794 * announce-gen: Accept new option, --gpg-key-id=ID and
4795 emit a blurb telling how to use the .sig files.
4796 * Makefile.cfg (gpg_key_ID): Define.
4797 * Makefile.maint (announcement): Use new option and key.
4799 Require that most .c files include <config.h>.
4800 * Makefile.maint (sc_require_config_h): New rule.
4801 (syntax-check-rules): Add it.
4802 * .x-sc_require_config_h: New file listing exceptions to the
4803 above rule. Some are legit, others are simply grandfathered in.
4804 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
4806 2005-11-12 Jim Meyering <jim@meyering.net>
4808 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
4810 2005-11-11 Jim Meyering <jim@meyering.net>
4812 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
4813 Mention new readlink options in 5.3.0's `New features' section.
4814 Spotted by Thomas Hood.
4816 2005-11-08 Jim Meyering <jim@meyering.net>
4818 * NEWS: Merge in changes from b5_9x branch.
4820 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
4822 * NEWS: ls now defaults to --time-style='locale', which in turn acts
4823 like --time-style='posix-long-iso' if the locale settings are messed up.
4824 * src/ls.c (decode_switches): Implement this.
4826 2005-11-08 Jim Meyering <jim@meyering.net>
4828 * tests/du/2g: s/expensive/very expensive/ in a comment.
4831 2005-10-17 Eric Blake <ebb9@byu.net>
4833 * src/ls.c (usage): Fix descriptions of --sort, --time.
4834 Reported by Vitaly A. Ostanin.
4836 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
4838 * src/ln.c: Include filenamecat.c.
4839 (FILE_BASENAME_CONCAT): Remove.
4840 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
4841 (main): Use file_name_concat, base_name, and strip_trailing_slashes
4842 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
4845 2005-11-04 Jim Meyering <jim@meyering.net>
4847 * src/du.c (process_file): Don't overflow for files of size >= 2^31
4848 on systems with stat.st_blocks of a signed 32-bit type.
4849 This bug causes trouble on some AIX 5.1 systems.
4850 Report and trivial patch from Paul Townsend:
4851 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
4852 * NEWS: Mention this.
4854 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
4855 * tests/du/Makefile.am (TESTS): Add it here.
4856 * tests/very-expensive: New file.
4857 * tests/Makefile.am (EXTRA_DIST): Add it here.
4858 * tests/cp/perm: Mark this test as `very-expensive', too.
4860 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
4862 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
4864 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
4866 * src/rm.c (usage): Don't mention rm -d.
4868 2005-11-02 Jim Meyering <jim@meyering.net>
4870 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
4871 From Andreas Schwab.
4873 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
4874 `M+N records in/out' lines don't pollute `make check' output.
4876 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
4877 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
4878 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
4879 to indicate that the input file should be piped into the command
4880 under test (via `cat FILE | $prog ...').
4882 * src/remove.c (remove_entry): Emit a better diagnostic when rm
4883 (without -r) fails to remove a directory on a non-Linux system.
4884 This change affects only newer Solaris systems (with priv_*
4885 functions like priv_allocset). Reported by Keith Thompson.
4887 * tests/rm/dir-nonrecur: New file/test for the above fix.
4888 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
4890 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
4892 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
4893 POSIX 1002.1-2001 requires.
4894 * src/tail.c (parse_obsolete_option): Implement this.
4895 Problem reported by Vincent Lefevre.
4896 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
4897 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
4898 (test_vector): Add special cases for _POSIX2_VERSION, and
4899 regularize the old ones a bit.
4900 * tests/touch/obsolescent: Add y2000 test.
4902 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
4904 * src/dd.c (skip): Fix off-by-one error reported by
4905 Theodoros V. Kalamatianos.
4907 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
4909 * tests/mkdir/p-3: Require that the test be run as non-root.
4910 Problem and trivial fix reported by Theodoros V. Kalamatianos.
4912 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
4914 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
4915 boundary between DEST and SOURCE in the result.
4917 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
4919 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
4920 back to text, to sync with documentation and for backwards
4923 2005-10-25 Jim Meyering <jim@meyering.net>
4925 * tests/dircolors/simple (other-wr): Add an explicit test for
4926 the dircolors bug (NULL-dereference) fixed yesterday.
4928 2005-10-24 Jim Meyering <jim@meyering.net>
4930 * src/tac.c (tac_file): When determining whether a file is seekable,
4931 also test whether it is a tty. Using only the lseek-based test would
4932 give a false positive on Solaris. Reported by Peter Fales.
4934 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
4936 * tests/install/d-slashdot: New test, for "install -d" failure.
4937 * tests/install/Makefile.am (TESTS): Add d-slashdot.
4938 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
4939 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
4941 2005-10-24 Jim Meyering <jim@meyering.net>
4943 * src/dircolors.c (ls_codes): Add missing comma.
4944 Anonymous report and patch from
4945 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
4947 * src/dircolors.c: Add compile-time assertion that the slack_codes
4948 and ls_codes arrays have the same number of elements. This would
4949 have prevented the above-fixed bug.
4951 * src/expand.c (parse_tab_stops): Add a comment to make this function
4952 identical to the one in unexpand.c.
4953 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
4954 identical to the one in expand.c.
4956 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
4958 2005-10-23 Jim Meyering <jim@meyering.net>
4960 * src/md5sum.c (digest_check, main): Use ptr_align rather than
4961 a dangerous pointer-value-to-`unsigned' cast.
4962 * NEWS: mention the new sha* programs.
4963 * AUTHORS: Add new sha* programs.
4965 2005-08-28 David Madore <david.madore@ens.fr>
4967 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
4968 * README: Add their names to the list.
4969 * src/md5sum.c: Provide framework for computing sha-2 hashes.
4970 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
4971 Rules for compiling sha-2 utilities
4972 (noinst_HEADERS): Remove checksum.h.
4973 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
4975 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
4976 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
4977 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
4978 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
4979 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
4980 sha384sum, sha512sum test scripts here rather that each in its
4983 2005-08-28 David Madore <david.madore@ens.fr>
4985 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
4986 of the FIPS test vectors).
4988 2005-10-23 Jim Meyering <jim@meyering.net>
4990 * configure.ac: Use 6.0-cvs as the version string.
4991 * NEWS: Adjust accordingly.
4996 Copyright (C) 2005, 2006 Free Software Foundation, Inc.
4998 Copying and distribution of this file, with or without
4999 modification, are permitted provided the copyright notice
5000 and this notice are preserved.