| commit | 5b50ebaefb128f2ecc0921e7009d6b54b96a7633 | |
| author | Jeremy Sowden <jeremy@azazel.net> | |
| Thu, 13 Jun 2019 14:05:18 +0000 (13 15:05 +0100) | ||
| committer | Carlos R. Mafra <crmafra@gmail.com> | |
| Thu, 13 Jun 2019 21:35:56 +0000 (13 22:35 +0100) | ||
| tree | 57809db53917a7ad8df38dbbfdc004e8286e141b | treesnapshot (tar.gz zip) |
| parent | 00630c75c7b1cad507d80a4aaea9a8dc75298e07 | commitdiff |
libdockapp: removed assertion that short-form options have length 2.
The mixed-option parsing code includes an assertion that short-form
options have a length of two. However, there is no other validation of
this requirement and some dock-apps do not comply with it, which means
that if one exec's them with an unrecognized option or a mix of short
options, the assertion fails and the app aborts.
For example:
$ /usr/bin/wmail --help | grep '\<display\>'
-display <string> display to use
$ /usr/bin/wmail --blah
wmail: daargs.c:126: contains: Assertion `strlen(needle) == 2' failed.
Aborted
Since there is no explicit statement of this requirement, let's replace
the assertion with a conditional.
The mixed-option parsing code includes an assertion that short-form
options have a length of two. However, there is no other validation of
this requirement and some dock-apps do not comply with it, which means
that if one exec's them with an unrecognized option or a mix of short
options, the assertion fails and the app aborts.
For example:
$ /usr/bin/wmail --help | grep '\<display\>'
-display <string> display to use
$ /usr/bin/wmail --blah
wmail: daargs.c:126: contains: Assertion `strlen(needle) == 2' failed.
Aborted
Since there is no explicit statement of this requirement, let's replace
the assertion with a conditional.
| libdockapp/src/daargs.c | diffblobblamehistory |