| commit | 335f2091275ee85e88447880cdb5148ca915ee16 | |
| author | Mathias Kinzler <mathias.kinzler@sap.com> | |
| Mon, 14 Jun 2010 06:58:32 +0000 (14 08:58 +0200) | ||
| committer | Mathias Kinzler <mathias.kinzler@sap.com> | |
| Mon, 14 Jun 2010 06:58:32 +0000 (14 08:58 +0200) | ||
| tree | b6d422b0856c4f9e47abc98ccc3e4b82d0aeb727 | treesnapshot (tar.gz zip) |
| parent | 4a71cec90fa8ee0e4b63cc3367247ab5e4f14b48 | commitdiff |
NullPointerException in Git History View
This occurs because these menu actions are implemented
using a preference change listener. When the page is disposed,
the corresponding actions are not disposed by the history framework,
so the registered actions keep listening for the preference changes.
To reproduce, open a Git History, then open "History" on some non-
Git controlled object in order to dispose the page. Open again a Git
History page, then click on the view menu -> Wrap comments (or any
other action there).
The fix actively disposes the registered actions when the page is disposed.
Bug: 316277
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
This occurs because these menu actions are implemented
using a preference change listener. When the page is disposed,
the corresponding actions are not disposed by the history framework,
so the registered actions keep listening for the preference changes.
To reproduce, open a Git History, then open "History" on some non-
Git controlled object in order to dispose the page. Open again a Git
History page, then click on the view menu -> Wrap comments (or any
other action there).
The fix actively disposes the registered actions when the page is disposed.
Bug: 316277
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java | diffblobblamehistory |