From 6bcdfef6ad148672872e4f5930a01a5a45dd9df0 Mon Sep 17 00:00:00 2001
From: void <thevoidf@gmail.com>
Date: Sun, 4 Mar 2018 04:56:32 +0400
Subject: [PATCH] Improve error message for non-strings to res.sendFile

closes #3582
---
 History.md           | 5 +++++
 lib/response.js      | 4 ++++
 test/res.sendFile.js | 8 ++++++++
 3 files changed, 17 insertions(+)

diff --git a/History.md b/History.md
index 2f6eab10..6a069942 100644
--- a/History.md
+++ b/History.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Improve error message for non-strings to `res.sendFile`
+
 4.16.4 / 2018-10-10
 ===================
 
diff --git a/lib/response.js b/lib/response.js
index 2e445ac0..11adeb61 100644
--- a/lib/response.js
+++ b/lib/response.js
@@ -411,6 +411,10 @@ res.sendFile = function sendFile(path, options, callback) {
     throw new TypeError('path argument is required to res.sendFile');
   }
 
+  if (typeof path !== 'string') {
+    throw new TypeError('path must be a string to res.sendFile')
+  }
+
   // support function as second arg
   if (typeof options === 'function') {
     done = options;
diff --git a/test/res.sendFile.js b/test/res.sendFile.js
index d7585b77..5f494f1e 100644
--- a/test/res.sendFile.js
+++ b/test/res.sendFile.js
@@ -20,6 +20,14 @@ describe('res', function(){
       .expect(500, /path.*required/, done);
     });
 
+    it('should error for non-string path', function (done) {
+      var app = createApp(42)
+
+      request(app)
+      .get('/')
+      .expect(500, /TypeError: path must be a string to res.sendFile/, done)
+    })
+
     it('should transfer a file', function (done) {
       var app = createApp(path.resolve(fixtures, 'name.txt'));
 
-- 
2.11.4.GIT