From 869afd8d8785c7a395b79b5a34721a2cce622a66 Mon Sep 17 00:00:00 2001
From: Chance Zibolski <chance.zibolski@gmail.com>
Date: Wed, 4 Sep 2013 11:59:12 -0700
Subject: [PATCH] ClusterDetail: Show vm tab if perms exist on at least 1 vm

refs #14877
---
 ganeti_web/templates/ganeti/cluster/detail.html | 4 +++-
 ganeti_web/views/cluster.py                     | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ganeti_web/templates/ganeti/cluster/detail.html b/ganeti_web/templates/ganeti/cluster/detail.html
index d8a09cb2..68b38d85 100644
--- a/ganeti_web/templates/ganeti/cluster/detail.html
+++ b/ganeti_web/templates/ganeti/cluster/detail.html
@@ -129,8 +129,10 @@
 <div id="tabs">
     <ul>
         <li><a href="#overview"><span>{% trans "Overview" %}</span></a></li>
-        {% if admin %}
+        {% if show_vms %}
             <li><a title="virtual machines" href="{% url cluster-vm-list cluster.slug %}"><span>{% trans "Virtual Machines" %}</span></a></li>
+        {% endif %}
+        {% if admin %}
             <li><a title="nodes" href="{% url cluster-nodes cluster.slug %}"><span>{% trans "Nodes" %}</span></a></li>
             <li><a title="user" href="{% url cluster-users cluster.slug %}"><span>{% trans "Users" %}</span></a></li>
             <li><a title="log" href="{% url cluster-object_log cluster.slug %}"><span>{% trans "Log" %}</span></a></li>
diff --git a/ganeti_web/views/cluster.py b/ganeti_web/views/cluster.py
index 480c8799..6e7e31c1 100644
--- a/ganeti_web/views/cluster.py
+++ b/ganeti_web/views/cluster.py
@@ -69,10 +69,16 @@ class ClusterDetailView(LoginRequiredMixin, DetailView):
         user = self.request.user
         admin = user.is_superuser or user.has_perm("admin", cluster)
 
+        # If we're not admin we might still have admin on a VM so this
+        # is to determine if we should show the VM tab to the user.
+        show_vms = admin or user.get_objects_any_perms(
+            VirtualMachine, perms=['admin']).filter(cluster=cluster)
+
         return {
             "cluster": cluster,
             "admin": admin,
             "readonly": not admin,
+            "show_vms": show_vms
         }
 
 
-- 
2.11.4.GIT