| commit | aa27e46111a777ae8b11e00675e13b1a9cde7fc2 | |
| author | Linus Torvalds <torvalds@linux-foundation.org> | |
| Wed, 28 Feb 2007 00:22:52 +0000 (27 16:22 -0800) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Wed, 28 Feb 2007 01:09:55 +0000 (27 17:09 -0800) | ||
| tree | 83c3f0128a43d02ec7b095973e906015b00901c1 | treesnapshot (tar.gz zip) |
| parent | 7ee70a7119e7d7edc1f85992d0ba8860c1c60a96 | commitdiff |
git-show: Reject native ref
So when we do
git show v1.4.4..v1.5.0
that's an illogical thing to do, since "git show" is defined to be a
non-revision-walking action, which means the range operator be pointless
and wrong. The fact that we happily accept it (and then _only_ show
v1.5.0, which is the positive end of the range) is quite arguably not very
logical.
We should complain, and say that you can only do "no_walk" with positive
refs. Negative object refs really don't make any sense unless you walk
the obejct list (or you're "git diff" and know about ranges explicitly).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
So when we do
git show v1.4.4..v1.5.0
that's an illogical thing to do, since "git show" is defined to be a
non-revision-walking action, which means the range operator be pointless
and wrong. The fact that we happily accept it (and then _only_ show
v1.5.0, which is the positive end of the range) is quite arguably not very
logical.
We should complain, and say that you can only do "no_walk" with positive
refs. Negative object refs really don't make any sense unless you walk
the obejct list (or you're "git diff" and know about ranges explicitly).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| revision.c | diffblobblamehistory |