| commit | 9a7a62ff71c436fb5e024ec409ec28fca460a168 | |
| author | Jakub Narebski <jnareb@gmail.com> | |
| Fri, 6 Oct 2006 10:31:05 +0000 (6 12:31 +0200) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sun, 8 Oct 2006 20:36:58 +0000 (8 13:36 -0700) | ||
| tree | f5ec987f490d4af197e3b8923285f7fb7f145aad | treesnapshot (tar.gz zip) |
| parent | 9cb90b80fc1ec09d8e51451b18a7c8ef7eac8908 | commitdiff |
gitweb: Cleanup Git logo and Git logo target generation
Rename $githelp_url and $githelp_label to $logo_url and $logo_label to
be more obvious what they refer to; while at it add commented out
previous contents (git documentation at kernel.org). Add comment about
logo size.
Use $cgi->a(...) to generate Git logo link; it automatically escapes
attribute values when it is needed. Escape href attribute using
esc_url instead of (incorrect!) esc_html.
Move styling of git logo <img> element from "style" attribute to CSS
via setting class to "logo". Perhaps we should set it by id rather
than by class.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Rename $githelp_url and $githelp_label to $logo_url and $logo_label to
be more obvious what they refer to; while at it add commented out
previous contents (git documentation at kernel.org). Add comment about
logo size.
Use $cgi->a(...) to generate Git logo link; it automatically escapes
attribute values when it is needed. Escape href attribute using
esc_url instead of (incorrect!) esc_html.
Move styling of git logo <img> element from "style" attribute to CSS
via setting class to "logo". Perhaps we should set it by id rather
than by class.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| gitweb/gitweb.css | diffblobblamehistory | |
| gitweb/gitweb.perl | diffblobblamehistory |