Merge branch 'icasefs-symlink-confusion'
[git/gitster.git] / bisect.c
blobec7487e6836c7ec5819f0b22cc7b08bce0e59fa0
1 #include "cache.h"
2 #include "config.h"
3 #include "commit.h"
4 #include "diff.h"
5 #include "revision.h"
6 #include "refs.h"
7 #include "list-objects.h"
8 #include "quote.h"
9 #include "hash-lookup.h"
10 #include "run-command.h"
11 #include "log-tree.h"
12 #include "bisect.h"
13 #include "oid-array.h"
14 #include "strvec.h"
15 #include "commit-slab.h"
16 #include "commit-reach.h"
17 #include "object-store.h"
18 #include "dir.h"
20 static struct oid_array good_revs;
21 static struct oid_array skipped_revs;
23 static struct object_id *current_bad_oid;
25 static const char *term_bad;
26 static const char *term_good;
28 /* Remember to update object flag allocation in object.h */
29 #define COUNTED (1u<<16)
32 * This is a truly stupid algorithm, but it's only
33 * used for bisection, and we just don't care enough.
35 * We care just barely enough to avoid recursing for
36 * non-merge entries.
38 static int count_distance(struct commit_list *entry)
40 int nr = 0;
42 while (entry) {
43 struct commit *commit = entry->item;
44 struct commit_list *p;
46 if (commit->object.flags & (UNINTERESTING | COUNTED))
47 break;
48 if (!(commit->object.flags & TREESAME))
49 nr++;
50 commit->object.flags |= COUNTED;
51 p = commit->parents;
52 entry = p;
53 if (p) {
54 p = p->next;
55 while (p) {
56 nr += count_distance(p);
57 p = p->next;
62 return nr;
65 static void clear_distance(struct commit_list *list)
67 while (list) {
68 struct commit *commit = list->item;
69 commit->object.flags &= ~COUNTED;
70 list = list->next;
74 define_commit_slab(commit_weight, int *);
75 static struct commit_weight commit_weight;
77 #define DEBUG_BISECT 0
79 static inline int weight(struct commit_list *elem)
81 return **commit_weight_at(&commit_weight, elem->item);
84 static inline void weight_set(struct commit_list *elem, int weight)
86 **commit_weight_at(&commit_weight, elem->item) = weight;
89 static int count_interesting_parents(struct commit *commit, unsigned bisect_flags)
91 struct commit_list *p;
92 int count;
94 for (count = 0, p = commit->parents; p; p = p->next) {
95 if (!(p->item->object.flags & UNINTERESTING))
96 count++;
97 if (bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY)
98 break;
100 return count;
103 static inline int approx_halfway(struct commit_list *p, int nr)
105 int diff;
108 * Don't short-cut something we are not going to return!
110 if (p->item->object.flags & TREESAME)
111 return 0;
112 if (DEBUG_BISECT)
113 return 0;
115 * For small number of commits 2 and 3 are halfway of 5, and
116 * 3 is halfway of 6 but 2 and 4 are not.
118 diff = 2 * weight(p) - nr;
119 switch (diff) {
120 case -1: case 0: case 1:
121 return 1;
122 default:
124 * For large number of commits we are not so strict, it's
125 * good enough if it's within ~0.1% of the halfway point,
126 * e.g. 5000 is exactly halfway of 10000, but we consider
127 * the values [4996, 5004] as halfway as well.
129 if (abs(diff) < nr / 1024)
130 return 1;
131 return 0;
135 static void show_list(const char *debug, int counted, int nr,
136 struct commit_list *list)
138 struct commit_list *p;
140 if (!DEBUG_BISECT)
141 return;
143 fprintf(stderr, "%s (%d/%d)\n", debug, counted, nr);
145 for (p = list; p; p = p->next) {
146 struct commit_list *pp;
147 struct commit *commit = p->item;
148 unsigned commit_flags = commit->object.flags;
149 enum object_type type;
150 unsigned long size;
151 char *buf = read_object_file(&commit->object.oid, &type,
152 &size);
153 const char *subject_start;
154 int subject_len;
156 fprintf(stderr, "%c%c%c ",
157 (commit_flags & TREESAME) ? ' ' : 'T',
158 (commit_flags & UNINTERESTING) ? 'U' : ' ',
159 (commit_flags & COUNTED) ? 'C' : ' ');
160 if (*commit_weight_at(&commit_weight, p->item))
161 fprintf(stderr, "%3d", weight(p));
162 else
163 fprintf(stderr, "---");
164 fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid));
165 for (pp = commit->parents; pp; pp = pp->next)
166 fprintf(stderr, " %.*s", 8,
167 oid_to_hex(&pp->item->object.oid));
169 subject_len = find_commit_subject(buf, &subject_start);
170 if (subject_len)
171 fprintf(stderr, " %.*s", subject_len, subject_start);
172 fprintf(stderr, "\n");
176 static struct commit_list *best_bisection(struct commit_list *list, int nr)
178 struct commit_list *p, *best;
179 int best_distance = -1;
181 best = list;
182 for (p = list; p; p = p->next) {
183 int distance;
184 unsigned commit_flags = p->item->object.flags;
186 if (commit_flags & TREESAME)
187 continue;
188 distance = weight(p);
189 if (nr - distance < distance)
190 distance = nr - distance;
191 if (distance > best_distance) {
192 best = p;
193 best_distance = distance;
197 return best;
200 struct commit_dist {
201 struct commit *commit;
202 int distance;
205 static int compare_commit_dist(const void *a_, const void *b_)
207 struct commit_dist *a, *b;
209 a = (struct commit_dist *)a_;
210 b = (struct commit_dist *)b_;
211 if (a->distance != b->distance)
212 return b->distance - a->distance; /* desc sort */
213 return oidcmp(&a->commit->object.oid, &b->commit->object.oid);
216 static struct commit_list *best_bisection_sorted(struct commit_list *list, int nr)
218 struct commit_list *p;
219 struct commit_dist *array = xcalloc(nr, sizeof(*array));
220 struct strbuf buf = STRBUF_INIT;
221 int cnt, i;
223 for (p = list, cnt = 0; p; p = p->next) {
224 int distance;
225 unsigned commit_flags = p->item->object.flags;
227 if (commit_flags & TREESAME)
228 continue;
229 distance = weight(p);
230 if (nr - distance < distance)
231 distance = nr - distance;
232 array[cnt].commit = p->item;
233 array[cnt].distance = distance;
234 cnt++;
236 QSORT(array, cnt, compare_commit_dist);
237 for (p = list, i = 0; i < cnt; i++) {
238 struct object *obj = &(array[i].commit->object);
240 strbuf_reset(&buf);
241 strbuf_addf(&buf, "dist=%d", array[i].distance);
242 add_name_decoration(DECORATION_NONE, buf.buf, obj);
244 p->item = array[i].commit;
245 if (i < cnt - 1)
246 p = p->next;
248 if (p) {
249 free_commit_list(p->next);
250 p->next = NULL;
252 strbuf_release(&buf);
253 free(array);
254 return list;
258 * zero or positive weight is the number of interesting commits it can
259 * reach, including itself. Especially, weight = 0 means it does not
260 * reach any tree-changing commits (e.g. just above uninteresting one
261 * but traversal is with pathspec).
263 * weight = -1 means it has one parent and its distance is yet to
264 * be computed.
266 * weight = -2 means it has more than one parent and its distance is
267 * unknown. After running count_distance() first, they will get zero
268 * or positive distance.
270 static struct commit_list *do_find_bisection(struct commit_list *list,
271 int nr, int *weights,
272 unsigned bisect_flags)
274 int n, counted;
275 struct commit_list *p;
277 counted = 0;
279 for (n = 0, p = list; p; p = p->next) {
280 struct commit *commit = p->item;
281 unsigned commit_flags = commit->object.flags;
283 *commit_weight_at(&commit_weight, p->item) = &weights[n++];
284 switch (count_interesting_parents(commit, bisect_flags)) {
285 case 0:
286 if (!(commit_flags & TREESAME)) {
287 weight_set(p, 1);
288 counted++;
289 show_list("bisection 2 count one",
290 counted, nr, list);
293 * otherwise, it is known not to reach any
294 * tree-changing commit and gets weight 0.
296 break;
297 case 1:
298 weight_set(p, -1);
299 break;
300 default:
301 weight_set(p, -2);
302 break;
306 show_list("bisection 2 initialize", counted, nr, list);
309 * If you have only one parent in the resulting set
310 * then you can reach one commit more than that parent
311 * can reach. So we do not have to run the expensive
312 * count_distance() for single strand of pearls.
314 * However, if you have more than one parents, you cannot
315 * just add their distance and one for yourself, since
316 * they usually reach the same ancestor and you would
317 * end up counting them twice that way.
319 * So we will first count distance of merges the usual
320 * way, and then fill the blanks using cheaper algorithm.
322 for (p = list; p; p = p->next) {
323 if (p->item->object.flags & UNINTERESTING)
324 continue;
325 if (weight(p) != -2)
326 continue;
327 if (bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY)
328 BUG("shouldn't be calling count-distance in fp mode");
329 weight_set(p, count_distance(p));
330 clear_distance(list);
332 /* Does it happen to be at half-way? */
333 if (!(bisect_flags & FIND_BISECTION_ALL) &&
334 approx_halfway(p, nr))
335 return p;
336 counted++;
339 show_list("bisection 2 count_distance", counted, nr, list);
341 while (counted < nr) {
342 for (p = list; p; p = p->next) {
343 struct commit_list *q;
344 unsigned commit_flags = p->item->object.flags;
346 if (0 <= weight(p))
347 continue;
349 for (q = p->item->parents;
351 q = bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY ? NULL : q->next) {
352 if (q->item->object.flags & UNINTERESTING)
353 continue;
354 if (0 <= weight(q))
355 break;
357 if (!q)
358 continue;
361 * weight for p is unknown but q is known.
362 * add one for p itself if p is to be counted,
363 * otherwise inherit it from q directly.
365 if (!(commit_flags & TREESAME)) {
366 weight_set(p, weight(q)+1);
367 counted++;
368 show_list("bisection 2 count one",
369 counted, nr, list);
371 else
372 weight_set(p, weight(q));
374 /* Does it happen to be at half-way? */
375 if (!(bisect_flags & FIND_BISECTION_ALL) &&
376 approx_halfway(p, nr))
377 return p;
381 show_list("bisection 2 counted all", counted, nr, list);
383 if (!(bisect_flags & FIND_BISECTION_ALL))
384 return best_bisection(list, nr);
385 else
386 return best_bisection_sorted(list, nr);
389 void find_bisection(struct commit_list **commit_list, int *reaches,
390 int *all, unsigned bisect_flags)
392 int nr, on_list;
393 struct commit_list *list, *p, *best, *next, *last;
394 int *weights;
396 show_list("bisection 2 entry", 0, 0, *commit_list);
397 init_commit_weight(&commit_weight);
400 * Count the number of total and tree-changing items on the
401 * list, while reversing the list.
403 for (nr = on_list = 0, last = NULL, p = *commit_list;
405 p = next) {
406 unsigned commit_flags = p->item->object.flags;
408 next = p->next;
409 if (commit_flags & UNINTERESTING) {
410 free(p);
411 continue;
413 p->next = last;
414 last = p;
415 if (!(commit_flags & TREESAME))
416 nr++;
417 on_list++;
419 list = last;
420 show_list("bisection 2 sorted", 0, nr, list);
422 *all = nr;
423 CALLOC_ARRAY(weights, on_list);
425 /* Do the real work of finding bisection commit. */
426 best = do_find_bisection(list, nr, weights, bisect_flags);
427 if (best) {
428 if (!(bisect_flags & FIND_BISECTION_ALL)) {
429 list->item = best->item;
430 free_commit_list(list->next);
431 best = list;
432 best->next = NULL;
434 *reaches = weight(best);
436 free(weights);
437 *commit_list = best;
438 clear_commit_weight(&commit_weight);
441 static int register_ref(const char *refname, const struct object_id *oid,
442 int flags UNUSED, void *cb_data UNUSED)
444 struct strbuf good_prefix = STRBUF_INIT;
445 strbuf_addstr(&good_prefix, term_good);
446 strbuf_addstr(&good_prefix, "-");
448 if (!strcmp(refname, term_bad)) {
449 current_bad_oid = xmalloc(sizeof(*current_bad_oid));
450 oidcpy(current_bad_oid, oid);
451 } else if (starts_with(refname, good_prefix.buf)) {
452 oid_array_append(&good_revs, oid);
453 } else if (starts_with(refname, "skip-")) {
454 oid_array_append(&skipped_revs, oid);
457 strbuf_release(&good_prefix);
459 return 0;
462 static int read_bisect_refs(void)
464 return for_each_ref_in("refs/bisect/", register_ref, NULL);
467 static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES")
468 static GIT_PATH_FUNC(git_path_bisect_expected_rev, "BISECT_EXPECTED_REV")
469 static GIT_PATH_FUNC(git_path_bisect_ancestors_ok, "BISECT_ANCESTORS_OK")
470 static GIT_PATH_FUNC(git_path_bisect_run, "BISECT_RUN")
471 static GIT_PATH_FUNC(git_path_bisect_start, "BISECT_START")
472 static GIT_PATH_FUNC(git_path_bisect_log, "BISECT_LOG")
473 static GIT_PATH_FUNC(git_path_bisect_terms, "BISECT_TERMS")
474 static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
475 static GIT_PATH_FUNC(git_path_head_name, "head-name")
477 static void read_bisect_paths(struct strvec *array)
479 struct strbuf str = STRBUF_INIT;
480 const char *filename = git_path_bisect_names();
481 FILE *fp = xfopen(filename, "r");
483 while (strbuf_getline_lf(&str, fp) != EOF) {
484 strbuf_trim(&str);
485 if (sq_dequote_to_strvec(str.buf, array))
486 die(_("Badly quoted content in file '%s': %s"),
487 filename, str.buf);
490 strbuf_release(&str);
491 fclose(fp);
494 static char *join_oid_array_hex(struct oid_array *array, char delim)
496 struct strbuf joined_hexs = STRBUF_INIT;
497 int i;
499 for (i = 0; i < array->nr; i++) {
500 strbuf_addstr(&joined_hexs, oid_to_hex(array->oid + i));
501 if (i + 1 < array->nr)
502 strbuf_addch(&joined_hexs, delim);
505 return strbuf_detach(&joined_hexs, NULL);
509 * In this function, passing a not NULL skipped_first is very special.
510 * It means that we want to know if the first commit in the list is
511 * skipped because we will want to test a commit away from it if it is
512 * indeed skipped.
513 * So if the first commit is skipped, we cannot take the shortcut to
514 * just "return list" when we find the first non skipped commit, we
515 * have to return a fully filtered list.
517 * We use (*skipped_first == -1) to mean "it has been found that the
518 * first commit is not skipped". In this case *skipped_first is set back
519 * to 0 just before the function returns.
521 struct commit_list *filter_skipped(struct commit_list *list,
522 struct commit_list **tried,
523 int show_all,
524 int *count,
525 int *skipped_first)
527 struct commit_list *filtered = NULL, **f = &filtered;
529 *tried = NULL;
531 if (skipped_first)
532 *skipped_first = 0;
533 if (count)
534 *count = 0;
536 if (!skipped_revs.nr)
537 return list;
539 while (list) {
540 struct commit_list *next = list->next;
541 list->next = NULL;
542 if (0 <= oid_array_lookup(&skipped_revs, &list->item->object.oid)) {
543 if (skipped_first && !*skipped_first)
544 *skipped_first = 1;
545 /* Move current to tried list */
546 *tried = list;
547 tried = &list->next;
548 } else {
549 if (!show_all) {
550 if (!skipped_first || !*skipped_first)
551 return list;
552 } else if (skipped_first && !*skipped_first) {
553 /* This means we know it's not skipped */
554 *skipped_first = -1;
556 /* Move current to filtered list */
557 *f = list;
558 f = &list->next;
559 if (count)
560 (*count)++;
562 list = next;
565 if (skipped_first && *skipped_first == -1)
566 *skipped_first = 0;
568 return filtered;
571 #define PRN_MODULO 32768
574 * This is a pseudo random number generator based on "man 3 rand".
575 * It is not used properly because the seed is the argument and it
576 * is increased by one between each call, but that should not matter
577 * for this application.
579 static unsigned get_prn(unsigned count)
581 count = count * 1103515245 + 12345;
582 return (count/65536) % PRN_MODULO;
586 * Custom integer square root from
587 * https://en.wikipedia.org/wiki/Integer_square_root
589 static int sqrti(int val)
591 float d, x = val;
593 if (!val)
594 return 0;
596 do {
597 float y = (x + (float)val / x) / 2;
598 d = (y > x) ? y - x : x - y;
599 x = y;
600 } while (d >= 0.5);
602 return (int)x;
605 static struct commit_list *skip_away(struct commit_list *list, int count)
607 struct commit_list *cur, *previous;
608 int prn, index, i;
610 prn = get_prn(count);
611 index = (count * prn / PRN_MODULO) * sqrti(prn) / sqrti(PRN_MODULO);
613 cur = list;
614 previous = NULL;
616 for (i = 0; cur; cur = cur->next, i++) {
617 if (i == index) {
618 if (!oideq(&cur->item->object.oid, current_bad_oid))
619 return cur;
620 if (previous)
621 return previous;
622 return list;
624 previous = cur;
627 return list;
630 static struct commit_list *managed_skipped(struct commit_list *list,
631 struct commit_list **tried)
633 int count, skipped_first;
635 *tried = NULL;
637 if (!skipped_revs.nr)
638 return list;
640 list = filter_skipped(list, tried, 0, &count, &skipped_first);
642 if (!skipped_first)
643 return list;
645 return skip_away(list, count);
648 static void bisect_rev_setup(struct repository *r, struct rev_info *revs,
649 struct strvec *rev_argv,
650 const char *prefix,
651 const char *bad_format, const char *good_format,
652 int read_paths)
654 struct setup_revision_opt opt = {
655 .free_removed_argv_elements = 1,
657 int i;
659 repo_init_revisions(r, revs, prefix);
660 revs->abbrev = 0;
661 revs->commit_format = CMIT_FMT_UNSPECIFIED;
663 /* rev_argv.argv[0] will be ignored by setup_revisions */
664 strvec_push(rev_argv, "bisect_rev_setup");
665 strvec_pushf(rev_argv, bad_format, oid_to_hex(current_bad_oid));
666 for (i = 0; i < good_revs.nr; i++)
667 strvec_pushf(rev_argv, good_format,
668 oid_to_hex(good_revs.oid + i));
669 strvec_push(rev_argv, "--");
670 if (read_paths)
671 read_bisect_paths(rev_argv);
673 setup_revisions(rev_argv->nr, rev_argv->v, revs, &opt);
676 static void bisect_common(struct rev_info *revs)
678 if (prepare_revision_walk(revs))
679 die("revision walk setup failed");
680 if (revs->tree_objects)
681 mark_edges_uninteresting(revs, NULL, 0);
684 static enum bisect_error error_if_skipped_commits(struct commit_list *tried,
685 const struct object_id *bad)
687 if (!tried)
688 return BISECT_OK;
690 printf("There are only 'skip'ped commits left to test.\n"
691 "The first %s commit could be any of:\n", term_bad);
693 for ( ; tried; tried = tried->next)
694 printf("%s\n", oid_to_hex(&tried->item->object.oid));
696 if (bad)
697 printf("%s\n", oid_to_hex(bad));
698 printf(_("We cannot bisect more!\n"));
700 return BISECT_ONLY_SKIPPED_LEFT;
703 static int is_expected_rev(const struct object_id *oid)
705 const char *filename = git_path_bisect_expected_rev();
706 struct stat st;
707 struct strbuf str = STRBUF_INIT;
708 FILE *fp;
709 int res = 0;
711 if (stat(filename, &st) || !S_ISREG(st.st_mode))
712 return 0;
714 fp = fopen_or_warn(filename, "r");
715 if (!fp)
716 return 0;
718 if (strbuf_getline_lf(&str, fp) != EOF)
719 res = !strcmp(str.buf, oid_to_hex(oid));
721 strbuf_release(&str);
722 fclose(fp);
724 return res;
727 enum bisect_error bisect_checkout(const struct object_id *bisect_rev,
728 int no_checkout)
730 struct commit *commit;
731 struct pretty_print_context pp = {0};
732 struct strbuf commit_msg = STRBUF_INIT;
734 update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0, UPDATE_REFS_DIE_ON_ERR);
736 if (no_checkout) {
737 update_ref(NULL, "BISECT_HEAD", bisect_rev, NULL, 0,
738 UPDATE_REFS_DIE_ON_ERR);
739 } else {
740 struct child_process cmd = CHILD_PROCESS_INIT;
742 cmd.git_cmd = 1;
743 strvec_pushl(&cmd.args, "checkout", "-q",
744 oid_to_hex(bisect_rev), "--", NULL);
745 if (run_command(&cmd))
747 * Errors in `run_command()` itself, signaled by res < 0,
748 * and errors in the child process, signaled by res > 0
749 * can both be treated as regular BISECT_FAILED (-1).
751 return BISECT_FAILED;
754 commit = lookup_commit_reference(the_repository, bisect_rev);
755 format_commit_message(commit, "[%H] %s%n", &commit_msg, &pp);
756 fputs(commit_msg.buf, stdout);
757 strbuf_release(&commit_msg);
759 return BISECT_OK;
762 static struct commit *get_commit_reference(struct repository *r,
763 const struct object_id *oid)
765 struct commit *c = lookup_commit_reference(r, oid);
766 if (!c)
767 die(_("Not a valid commit name %s"), oid_to_hex(oid));
768 return c;
771 static struct commit **get_bad_and_good_commits(struct repository *r,
772 int *rev_nr)
774 struct commit **rev;
775 int i, n = 0;
777 ALLOC_ARRAY(rev, 1 + good_revs.nr);
778 rev[n++] = get_commit_reference(r, current_bad_oid);
779 for (i = 0; i < good_revs.nr; i++)
780 rev[n++] = get_commit_reference(r, good_revs.oid + i);
781 *rev_nr = n;
783 return rev;
786 static enum bisect_error handle_bad_merge_base(void)
788 if (is_expected_rev(current_bad_oid)) {
789 char *bad_hex = oid_to_hex(current_bad_oid);
790 char *good_hex = join_oid_array_hex(&good_revs, ' ');
791 if (!strcmp(term_bad, "bad") && !strcmp(term_good, "good")) {
792 fprintf(stderr, _("The merge base %s is bad.\n"
793 "This means the bug has been fixed "
794 "between %s and [%s].\n"),
795 bad_hex, bad_hex, good_hex);
796 } else if (!strcmp(term_bad, "new") && !strcmp(term_good, "old")) {
797 fprintf(stderr, _("The merge base %s is new.\n"
798 "The property has changed "
799 "between %s and [%s].\n"),
800 bad_hex, bad_hex, good_hex);
801 } else {
802 fprintf(stderr, _("The merge base %s is %s.\n"
803 "This means the first '%s' commit is "
804 "between %s and [%s].\n"),
805 bad_hex, term_bad, term_good, bad_hex, good_hex);
807 return BISECT_MERGE_BASE_CHECK;
810 fprintf(stderr, _("Some %s revs are not ancestors of the %s rev.\n"
811 "git bisect cannot work properly in this case.\n"
812 "Maybe you mistook %s and %s revs?\n"),
813 term_good, term_bad, term_good, term_bad);
814 return BISECT_FAILED;
817 static void handle_skipped_merge_base(const struct object_id *mb)
819 char *mb_hex = oid_to_hex(mb);
820 char *bad_hex = oid_to_hex(current_bad_oid);
821 char *good_hex = join_oid_array_hex(&good_revs, ' ');
823 warning(_("the merge base between %s and [%s] "
824 "must be skipped.\n"
825 "So we cannot be sure the first %s commit is "
826 "between %s and %s.\n"
827 "We continue anyway."),
828 bad_hex, good_hex, term_bad, mb_hex, bad_hex);
829 free(good_hex);
833 * "check_merge_bases" checks that merge bases are not "bad" (or "new").
835 * - If one is "bad" (or "new"), it means the user assumed something wrong
836 * and we must return error with a non 0 error code.
837 * - If one is "good" (or "old"), that's good, we have nothing to do.
838 * - If one is "skipped", we can't know but we should warn.
839 * - If we don't know, we should check it out and ask the user to test.
840 * - If a merge base must be tested, on success return
841 * BISECT_INTERNAL_SUCCESS_MERGE_BASE (-11) a special condition
842 * for early success, this will be converted back to 0 in
843 * check_good_are_ancestors_of_bad().
845 static enum bisect_error check_merge_bases(int rev_nr, struct commit **rev, int no_checkout)
847 enum bisect_error res = BISECT_OK;
848 struct commit_list *result;
850 result = get_merge_bases_many(rev[0], rev_nr - 1, rev + 1);
852 for (; result; result = result->next) {
853 const struct object_id *mb = &result->item->object.oid;
854 if (oideq(mb, current_bad_oid)) {
855 res = handle_bad_merge_base();
856 break;
857 } else if (0 <= oid_array_lookup(&good_revs, mb)) {
858 continue;
859 } else if (0 <= oid_array_lookup(&skipped_revs, mb)) {
860 handle_skipped_merge_base(mb);
861 } else {
862 printf(_("Bisecting: a merge base must be tested\n"));
863 res = bisect_checkout(mb, no_checkout);
864 if (!res)
865 /* indicate early success */
866 res = BISECT_INTERNAL_SUCCESS_MERGE_BASE;
867 break;
871 free_commit_list(result);
872 return res;
875 static int check_ancestors(struct repository *r, int rev_nr,
876 struct commit **rev, const char *prefix)
878 struct strvec rev_argv = STRVEC_INIT;
879 struct rev_info revs;
880 int res;
882 bisect_rev_setup(r, &revs, &rev_argv, prefix, "^%s", "%s", 0);
884 bisect_common(&revs);
885 res = (revs.commits != NULL);
887 /* Clean up objects used, as they will be reused. */
888 clear_commit_marks_many(rev_nr, rev, ALL_REV_FLAGS);
890 release_revisions(&revs);
891 strvec_clear(&rev_argv);
892 return res;
896 * "check_good_are_ancestors_of_bad" checks that all "good" revs are
897 * ancestor of the "bad" rev.
899 * If that's not the case, we need to check the merge bases.
900 * If a merge base must be tested by the user, its source code will be
901 * checked out to be tested by the user and we will return.
904 static enum bisect_error check_good_are_ancestors_of_bad(struct repository *r,
905 const char *prefix,
906 int no_checkout)
908 char *filename;
909 struct stat st;
910 int fd, rev_nr;
911 enum bisect_error res = BISECT_OK;
912 struct commit **rev;
914 if (!current_bad_oid)
915 return error(_("a %s revision is needed"), term_bad);
917 filename = git_pathdup("BISECT_ANCESTORS_OK");
919 /* Check if file BISECT_ANCESTORS_OK exists. */
920 if (!stat(filename, &st) && S_ISREG(st.st_mode))
921 goto done;
923 /* Bisecting with no good rev is ok. */
924 if (!good_revs.nr)
925 goto done;
927 /* Check if all good revs are ancestor of the bad rev. */
929 rev = get_bad_and_good_commits(r, &rev_nr);
930 if (check_ancestors(r, rev_nr, rev, prefix))
931 res = check_merge_bases(rev_nr, rev, no_checkout);
932 free(rev);
934 if (!res) {
935 /* Create file BISECT_ANCESTORS_OK. */
936 fd = open(filename, O_CREAT | O_TRUNC | O_WRONLY, 0600);
937 if (fd < 0)
939 * BISECT_ANCESTORS_OK file is not absolutely necessary,
940 * the bisection process will continue at the next
941 * bisection step.
942 * So, just signal with a warning that something
943 * might be wrong.
945 warning_errno(_("could not create file '%s'"),
946 filename);
947 else
948 close(fd);
950 done:
951 free(filename);
952 return res;
956 * This does "git diff-tree --pretty COMMIT" without one fork+exec.
958 static void show_diff_tree(struct repository *r,
959 const char *prefix,
960 struct commit *commit)
962 const char *argv[] = {
963 "diff-tree", "--pretty", "--stat", "--summary", "--cc", NULL
965 struct rev_info opt;
967 git_config(git_diff_ui_config, NULL);
968 repo_init_revisions(r, &opt, prefix);
970 setup_revisions(ARRAY_SIZE(argv) - 1, argv, &opt, NULL);
971 log_tree_commit(&opt, commit);
972 release_revisions(&opt);
976 * The terms used for this bisect session are stored in BISECT_TERMS.
977 * We read them and store them to adapt the messages accordingly.
978 * Default is bad/good.
980 void read_bisect_terms(const char **read_bad, const char **read_good)
982 struct strbuf str = STRBUF_INIT;
983 const char *filename = git_path_bisect_terms();
984 FILE *fp = fopen(filename, "r");
986 if (!fp) {
987 if (errno == ENOENT) {
988 *read_bad = "bad";
989 *read_good = "good";
990 return;
991 } else {
992 die_errno(_("could not read file '%s'"), filename);
994 } else {
995 strbuf_getline_lf(&str, fp);
996 *read_bad = strbuf_detach(&str, NULL);
997 strbuf_getline_lf(&str, fp);
998 *read_good = strbuf_detach(&str, NULL);
1000 strbuf_release(&str);
1001 fclose(fp);
1005 * We use the convention that return BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND (-10) means
1006 * the bisection process finished successfully.
1007 * In this case the calling function or command should not turn a
1008 * BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND return code into an error or a non zero exit code.
1010 * Checking BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND
1011 * in bisect_helper::bisect_next() and only transforming it to 0 at
1012 * the end of bisect_helper::cmd_bisect__helper() helps bypassing
1013 * all the code related to finding a commit to test.
1015 enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
1017 struct strvec rev_argv = STRVEC_INIT;
1018 struct rev_info revs = REV_INFO_INIT;
1019 struct commit_list *tried;
1020 int reaches = 0, all = 0, nr, steps;
1021 enum bisect_error res = BISECT_OK;
1022 struct object_id *bisect_rev;
1023 char *steps_msg;
1025 * If no_checkout is non-zero, the bisection process does not
1026 * checkout the trial commit but instead simply updates BISECT_HEAD.
1028 int no_checkout = ref_exists("BISECT_HEAD");
1029 unsigned bisect_flags = 0;
1031 read_bisect_terms(&term_bad, &term_good);
1032 if (read_bisect_refs())
1033 die(_("reading bisect refs failed"));
1035 if (file_exists(git_path_bisect_first_parent()))
1036 bisect_flags |= FIND_BISECTION_FIRST_PARENT_ONLY;
1038 if (skipped_revs.nr)
1039 bisect_flags |= FIND_BISECTION_ALL;
1041 res = check_good_are_ancestors_of_bad(r, prefix, no_checkout);
1042 if (res)
1043 goto cleanup;
1045 bisect_rev_setup(r, &revs, &rev_argv, prefix, "%s", "^%s", 1);
1047 revs.first_parent_only = !!(bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY);
1048 revs.limited = 1;
1050 bisect_common(&revs);
1052 find_bisection(&revs.commits, &reaches, &all, bisect_flags);
1053 revs.commits = managed_skipped(revs.commits, &tried);
1055 if (!revs.commits) {
1057 * We should return error here only if the "bad"
1058 * commit is also a "skip" commit.
1060 res = error_if_skipped_commits(tried, NULL);
1061 if (res < 0)
1062 goto cleanup;
1063 printf(_("%s was both %s and %s\n"),
1064 oid_to_hex(current_bad_oid),
1065 term_good,
1066 term_bad);
1068 res = BISECT_FAILED;
1069 goto cleanup;
1072 if (!all) {
1073 fprintf(stderr, _("No testable commit found.\n"
1074 "Maybe you started with bad path arguments?\n"));
1076 res = BISECT_NO_TESTABLE_COMMIT;
1077 goto cleanup;
1080 bisect_rev = &revs.commits->item->object.oid;
1082 if (oideq(bisect_rev, current_bad_oid)) {
1083 res = error_if_skipped_commits(tried, current_bad_oid);
1084 if (res)
1085 return res;
1086 printf("%s is the first %s commit\n", oid_to_hex(bisect_rev),
1087 term_bad);
1089 show_diff_tree(r, prefix, revs.commits->item);
1091 * This means the bisection process succeeded.
1092 * Using BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND (-10)
1093 * so that the call chain can simply check
1094 * for negative return values for early returns up
1095 * until the cmd_bisect__helper() caller.
1097 res = BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND;
1098 goto cleanup;
1101 nr = all - reaches - 1;
1102 steps = estimate_bisect_steps(all);
1104 steps_msg = xstrfmt(Q_("(roughly %d step)", "(roughly %d steps)",
1105 steps), steps);
1107 * TRANSLATORS: the last %s will be replaced with "(roughly %d
1108 * steps)" translation.
1110 printf(Q_("Bisecting: %d revision left to test after this %s\n",
1111 "Bisecting: %d revisions left to test after this %s\n",
1112 nr), nr, steps_msg);
1113 free(steps_msg);
1114 /* Clean up objects used, as they will be reused. */
1115 repo_clear_commit_marks(r, ALL_REV_FLAGS);
1117 res = bisect_checkout(bisect_rev, no_checkout);
1118 cleanup:
1119 release_revisions(&revs);
1120 strvec_clear(&rev_argv);
1121 return res;
1124 static inline int log2i(int n)
1126 int log2 = 0;
1128 for (; n > 1; n >>= 1)
1129 log2++;
1131 return log2;
1134 static inline int exp2i(int n)
1136 return 1 << n;
1140 * Estimate the number of bisect steps left (after the current step)
1142 * For any x between 0 included and 2^n excluded, the probability for
1143 * n - 1 steps left looks like:
1145 * P(2^n + x) == (2^n - x) / (2^n + x)
1147 * and P(2^n + x) < 0.5 means 2^n < 3x
1149 int estimate_bisect_steps(int all)
1151 int n, x, e;
1153 if (all < 3)
1154 return 0;
1156 n = log2i(all);
1157 e = exp2i(n);
1158 x = all - e;
1160 return (e < 3 * x) ? n : n - 1;
1163 static int mark_for_removal(const char *refname,
1164 const struct object_id *oid UNUSED,
1165 int flag UNUSED, void *cb_data)
1167 struct string_list *refs = cb_data;
1168 char *ref = xstrfmt("refs/bisect%s", refname);
1169 string_list_append(refs, ref);
1170 return 0;
1173 int bisect_clean_state(void)
1175 int result = 0;
1177 /* There may be some refs packed during bisection */
1178 struct string_list refs_for_removal = STRING_LIST_INIT_NODUP;
1179 for_each_ref_in("refs/bisect", mark_for_removal, (void *) &refs_for_removal);
1180 string_list_append(&refs_for_removal, xstrdup("BISECT_HEAD"));
1181 result = delete_refs("bisect: remove", &refs_for_removal, REF_NO_DEREF);
1182 refs_for_removal.strdup_strings = 1;
1183 string_list_clear(&refs_for_removal, 0);
1184 unlink_or_warn(git_path_bisect_expected_rev());
1185 unlink_or_warn(git_path_bisect_ancestors_ok());
1186 unlink_or_warn(git_path_bisect_log());
1187 unlink_or_warn(git_path_bisect_names());
1188 unlink_or_warn(git_path_bisect_run());
1189 unlink_or_warn(git_path_bisect_terms());
1190 unlink_or_warn(git_path_bisect_first_parent());
1191 /* Cleanup head-name if it got left by an old version of git-bisect */
1192 unlink_or_warn(git_path_head_name());
1194 * Cleanup BISECT_START last to support the --no-checkout option
1195 * introduced in the commit 4796e823a.
1197 unlink_or_warn(git_path_bisect_start());
1199 return result;