| commit | 8977c110b5bbd230c28c727ddb85856067d55cfb | |
| author | Junio C Hamano <junkio@cox.net> | |
| Thu, 4 Jan 2007 07:09:08 +0000 (3 23:09 -0800) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Fri, 5 Jan 2007 06:17:59 +0000 (4 22:17 -0800) | ||
| tree | 99c23def7dd3a9279226614f3af0aba82a555c81 | treesnapshot (tar.gz zip) |
| parent | 1084b845d9d77bcb2e8255636358dd0dc35360a5 | commitdiff |
pack-check.c::verify_packfile(): don't run SHA-1 update on huge data
Running the SHA1_Update() on the whole packfile in a single call
revealed an overflow problem we had in the SHA-1 implementation
on POWER architecture some time ago, which was fixed with commit
b47f509b (June 19, 2006). Other SHA-1 implementations may have
a similar problem.
The sliding mmap() series already makes chunked calls to
SHA1_Update(), so this patch itself will become moot when it
graduates to "master", but in the meantime, run the hash
function in smaller chunks to prevent possible future problems.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Running the SHA1_Update() on the whole packfile in a single call
revealed an overflow problem we had in the SHA-1 implementation
on POWER architecture some time ago, which was fixed with commit
b47f509b (June 19, 2006). Other SHA-1 implementations may have
a similar problem.
The sliding mmap() series already makes chunked calls to
SHA1_Update(), so this patch itself will become moot when it
graduates to "master", but in the meantime, run the hash
function in smaller chunks to prevent possible future problems.
Signed-off-by: Junio C Hamano <junkio@cox.net>
| pack-check.c | diffblobblamehistory |