gmem: Only evaluate pointer argument to g_clear_pointer() once2e9c31af11b7d2d18052d5bbcdc3611f2f7480f5262/head
| commit | 2e9c31af11b7d2d18052d5bbcdc3611f2f7480f5 | |
| author | Philip Withnall <withnall@endlessm.com> | |
| Wed, 22 Aug 2018 13:47:52 +0000 (22 14:47 +0100) | ||
| committer | Philip Withnall <withnall@endlessm.com> | |
| Wed, 22 Aug 2018 13:47:52 +0000 (22 14:47 +0100) | ||
| tree | 341d290ca2b21832c42e852794af87d43976741d | treesnapshot (tar.gz zip) |
| parent | 9a72ebe01609f0e9afd299451ccbae8a677da9da | commitdiff |
gmem: Only evaluate pointer argument to g_clear_pointer() once
The new typeof() macro version of g_clear_pointer() was evaluating its
pointer argument more than once, meaning any side effects would be
evaluated multiple times.
The existing (other) macro version of g_clear_pointer() was evaluating
its argument exactly once. This mismatch could have confused people or
lead to subtle bugs.
See https://gitlab.gnome.org/GNOME/glib/issues/1494.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
The new typeof() macro version of g_clear_pointer() was evaluating its
pointer argument more than once, meaning any side effects would be
evaluated multiple times.
The existing (other) macro version of g_clear_pointer() was evaluating
its argument exactly once. This mismatch could have confused people or
lead to subtle bugs.
See https://gitlab.gnome.org/GNOME/glib/issues/1494.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
| glib/gmem.h | diffblobblamehistory | |
| glib/tests/utils.c | diffblobblamehistory |