| commit | 28ea5c924c907727d070ee26a56c2ff7c2da7c61 | |
| author | gears.daemon <gears.daemon@fe895e04-df30-0410-9975-d76d301b4276> | |
| Fri, 21 Dec 2007 22:00:38 +0000 (21 22:00 +0000) | ||
| committer | gears.daemon <gears.daemon@fe895e04-df30-0410-9975-d76d301b4276> | |
| Fri, 21 Dec 2007 22:00:38 +0000 (21 22:00 +0000) | ||
| tree | ad8247536cfbec71340c94fa4d4927163b8471a8 | treesnapshot (tar.gz zip) |
| parent | 79a952c44012c786a57f086545b852ad3486fa80 | commitdiff |
[Author: mpcomplete]
More refactoring of NPAPI wrapper classes. At Aaron's suggestion, I moved the Register* calls out of the wrapper classes and into the impl classes. This gets us two cool things:
- We'll only need to register properties/methods in one, platform-neutral place (not one per port).
- The _wrapper files can go away completely. The wrapper classes have been reduced down enough that they can be defined in a simple macro call in each module file.
Potential tricky bits about this CL:
- PluginBase<T> now expects T to be the ImplClass (ie, GearsFactory), rather than the WrapperClass (ie, GearsFactoryWrapper). It doesn't really matter, but it made the macros simpler.
- I put the dynamic dispatch in a separate class rather than in ModuleImplBaseClass, because HtmlEventMonitor uses dynamic dispatch but is not a module.
R=aa
CC=google-gears-eng@googlegroups.com
DELTA=1106 (438 added, 596 deleted, 72 changed)
OCL=6130547
SCL=6145539
git-svn-id: https://google-gears.googlecode.com/svn/trunk@625 fe895e04-df30-0410-9975-d76d301b4276
More refactoring of NPAPI wrapper classes. At Aaron's suggestion, I moved the Register* calls out of the wrapper classes and into the impl classes. This gets us two cool things:
- We'll only need to register properties/methods in one, platform-neutral place (not one per port).
- The _wrapper files can go away completely. The wrapper classes have been reduced down enough that they can be defined in a simple macro call in each module file.
Potential tricky bits about this CL:
- PluginBase<T> now expects T to be the ImplClass (ie, GearsFactory), rather than the WrapperClass (ie, GearsFactoryWrapper). It doesn't really matter, but it made the macros simpler.
- I put the dynamic dispatch in a separate class rather than in ModuleImplBaseClass, because HtmlEventMonitor uses dynamic dispatch but is not a module.
R=aa
CC=google-gears-eng@googlegroups.com
DELTA=1106 (438 added, 596 deleted, 72 changed)
OCL=6130547
SCL=6145539
git-svn-id: https://google-gears.googlecode.com/svn/trunk@625 fe895e04-df30-0410-9975-d76d301b4276
23 files changed: