| commit | f8c03d0287aa3a745bc50244731a8a8a31ca7a5a | |
| author | Kyle Ackerman <kackerman0102@gmail.com> | |
| Wed, 27 Mar 2024 09:07:00 +0000 (27 09:07 +0000) | ||
| committer | Thomas Adam <thomas@xteddy.org> | |
| Sat, 30 Mar 2024 17:21:23 +0000 (30 17:21 +0000) | ||
| tree | e87cc5696c5c5712f33c9b29ab86f6026920608a | treesnapshot (tar.gz zip) |
| parent | 22af6a95d11edbe6ded4e23d85858238a9be64e2 | commitdiff |
plug a memory leak in 'got blame'
The leak is present in got_privsep_recv_traversed_commits. There is
an edge case where it receives consecutive imsgs. The first behaves as
normal and we got_object_id_dup the last commit id for
changed_commit_id. The following imsg(s) then still allocates the last
commit id, leaking the one(s) prior allocated.
Patch by Kyle Ackerman
The leak is present in got_privsep_recv_traversed_commits. There is
an edge case where it receives consecutive imsgs. The first behaves as
normal and we got_object_id_dup the last commit id for
changed_commit_id. The following imsg(s) then still allocates the last
commit id, leaking the one(s) prior allocated.
Patch by Kyle Ackerman
| lib/got_lib_privsep.h | diffblobblamehistory | |
| lib/object_open_privsep.c | diffblobblamehistory | |
| lib/privsep.c | diffblobblamehistory |