| commit | 456342ca99e43ef8faf5db853d13d6cc258d3ca8 | |
| author | Rene Gollent <rene@gollent.com> | |
| Mon, 25 Sep 2017 00:23:34 +0000 (24 20:23 -0400) | ||
| committer | Rene Gollent <rene@gollent.com> | |
| Mon, 25 Sep 2017 00:23:34 +0000 (24 20:23 -0400) | ||
| tree | 9a3cdae34fc4f109154dff56cf8e4a0ccdebeb26 | treesnapshot (tar.gz zip) |
| parent | 93f521060e787cee01f28504dde672951e2c7f5e | commitdiff |
Debugger: Reimplement #10671.
- Rather than the previous (reverted) approach of tracking the last selected
stack frame from within the StackTraceView, we now do so from the TeamWindow,
where the selection can be mapped by thread. This fixes a subtle issue where,
due to a lack of contextual information, the stack trace view would restore
the remembered last selected frame rather than an explicitly chosen one. This
was most noticeable upon selecting a function that had a corresponding stack
frame in the current stack trace, where, instead of selecting that frame,
the existing one would remain highlighted, even though the state of all other
views had updated. Found while investigating the cause of #13710.
- Rather than the previous (reverted) approach of tracking the last selected
stack frame from within the StackTraceView, we now do so from the TeamWindow,
where the selection can be mapped by thread. This fixes a subtle issue where,
due to a lack of contextual information, the stack trace view would restore
the remembered last selected frame rather than an explicitly chosen one. This
was most noticeable upon selecting a function that had a corresponding stack
frame in the current stack trace, where, instead of selecting that frame,
the existing one would remain highlighted, even though the state of all other
views had updated. Found while investigating the cause of #13710.
| src/apps/debugger/user_interface/gui/team_window/TeamWindow.cpp | diffblobblamehistory | |
| src/apps/debugger/user_interface/gui/team_window/TeamWindow.h | diffblobblamehistory |