HBASE-19497 Fix findbugs and error-prone warnings in hbase-common (branch-2)
commitf9f869f60a334982b739420a614b5d44adf26af0
authorPeter Somogyi <psomogyi@cloudera.com>
Mon, 11 Dec 2017 12:38:44 +0000 (11 13:38 +0100)
committerMichael Stack <stack@apache.org>
Sat, 16 Dec 2017 00:16:34 +0000 (15 16:16 -0800)
treea5c9d9f9b5bc6f13bfd6388c0b61727ba78e501c
parent59529a78f039965a4c08805c9087d82d64621c20
HBASE-19497 Fix findbugs and error-prone warnings in hbase-common (branch-2)
Signed-off-by: Apekshit Sharma <appy@apache.org>
203 files changed:
hbase-common/src/main/java/org/apache/hadoop/hbase/ArrayBackedTag.java
hbase-common/src/main/java/org/apache/hadoop/hbase/AsyncConsoleAppender.java
hbase-common/src/main/java/org/apache/hadoop/hbase/AuthUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/BaseConfigurable.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferTag.java
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java
hbase-common/src/main/java/org/apache/hadoop/hbase/CellScanner.java
hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java
hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptor.java
hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsByteBufferKeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsKeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java
hbase-common/src/main/java/org/apache/hadoop/hbase/SizeCachedKeyValue.java
hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodec.java
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/Codec.java
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java
hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/UnexpectedStateException.java
hbase-common/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteArrayOutputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffInputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferInputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferListOutputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferOutputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferPool.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterDataOutputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/Compression.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Context.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/CryptoCipherProvider.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/DefaultCipherProvider.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/AES.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/AESDecryptor.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/AESEncryptor.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/CommonsCryptoAES.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/CommonsCryptoAESDecryptor.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/CommonsCryptoAESEncryptor.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/CryptoAES.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/AbstractDataBlockEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/CompressionState.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDecodingContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockEncodingContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/PrefixKeyDeltaEncoder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexCodecV1.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexEncoderV1.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hadoopbackport/ThrottledInputStream.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockType.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContextBuilder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/Dictionary.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java
hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/StreamUtils.java
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/SingleByteBuff.java
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
hbase-common/src/main/java/org/apache/hadoop/hbase/security/Superusers.java
hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/DataType.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/FixedLengthWrapper.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlobVar.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBytesBase.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedFloat32.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedFloat64.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedInt16.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedInt32.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedInt64.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedInt8.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedNumeric.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedString.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/PBType.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawByte.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytes.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytesFixedLength.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytesTerminated.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawDouble.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawFloat.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawInteger.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawLong.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawShort.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawString.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawStringFixedLength.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawStringTerminated.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/Struct.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/StructBuilder.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/StructIterator.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/TerminatedWrapper.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/Union2.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/Union3.java
hbase-common/src/main/java/org/apache/hadoop/hbase/types/Union4.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractHBaseTool.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Base64.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassLoaderBase.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/HasThread.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Hash.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/JRubyFormat.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/JSONMetricUtil.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/OrderedBytes.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectionUtils.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/RetryCounterFactory.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/SoftObjectPool.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Triple.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java
hbase-common/src/main/java/org/apache/hadoop/hbase/util/WeakObjectPool.java
hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
hbase-common/src/test/java/org/apache/hadoop/hbase/ClassFinder.java
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellBuilder.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestChoreService.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestClassFinder.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCompoundConfiguration.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestHBaseConfiguration.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestIndividualBytesFieldCell.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestTableName.java
hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimeout.java
hbase-common/src/test/java/org/apache/hadoop/hbase/Waiter.java
hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecWithTags.java
hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodec.java
hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodecWithTags.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestByteBufferListOutputStream.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestByteBufferPool.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestTagCompressionContext.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/KeyProviderForTesting.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestCipherProvider.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestEncryption.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestKeyProvider.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestKeyStoreKeyProvider.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/aes/TestAES.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/aes/TestCommonsAES.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/hadoopbackport/TestThrottledInputStream.java
hbase-common/src/test/java/org/apache/hadoop/hbase/io/util/TestLRUDictionary.java
hbase-common/src/test/java/org/apache/hadoop/hbase/nio/TestMultiByteBuff.java
hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestCopyOnWriteMaps.java
hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestStruct.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/AbstractHBaseToolTest.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/ClassLoaderTestHelper.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/RedundantKVGenerator.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestAvlUtil.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBase64.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferArray.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeWithKVSerialization.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestCommonFSUtils.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestConcatenatedLists.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorClassLoader.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestDynamicClassLoader.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestJRubyFormat.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestLoadTestKVGenerator.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestOrderedBytes.java
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestVersionInfo.java
hbase-common/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKConfig.java