| commit | 784b24dde151a967229c2f8c2f08b0827709bd4d | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Tue, 2 Feb 2010 17:09:26 +0000 (2 09:09 -0800) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Tue, 2 Feb 2010 17:09:26 +0000 (2 09:09 -0800) | ||
| tree | 19d2084c5a794a4c21e577ef7bc86b1cd5514015 | treesnapshot (tar.gz zip) |
| parent | 434e7884e5b7db7a4314e80c33a3b98f045050b9 | commitdiff |
Correctly skip over unrecognized optional dircache extensions
We didn't skip the correct number of bytes when we skipped over an
unrecognized but optional dircache extension. We missed skipping
the 8 byte header that makes up the extension's name and length.
We also didn't include the skipped extension's payload as part of
our index checksum, resuting in a checksum failure when the index
was done reading. So ensure we always scan through a skipped
section and include it in the checksum computation.
Add a test case for a currently unsupported index extension, 'ZZZZ',
to verify we can still read the DirCache object even though we
don't know what 'ZZZZ' is supposed to mean.
Bug: 301287
Change-Id: I4bdde94576fffe826d0782483fd98cab1ea628fa
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
We didn't skip the correct number of bytes when we skipped over an
unrecognized but optional dircache extension. We missed skipping
the 8 byte header that makes up the extension's name and length.
We also didn't include the skipped extension's payload as part of
our index checksum, resuting in a checksum failure when the index
was done reading. So ensure we always scan through a skipped
section and include it in the checksum computation.
Add a test case for a currently unsupported index extension, 'ZZZZ',
to verify we can still read the DirCache object even though we
don't know what 'ZZZZ' is supposed to mean.
Bug: 301287
Change-Id: I4bdde94576fffe826d0782483fd98cab1ea628fa
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>