python: return dictionary without value in case of no blockjobCVE-2013-4153CVE-2013-4154
commitf8bc3a9ccc3f40d800d856a9c6d44bc225d621bd
authorGuannan Ren <gren@redhat.com>
Fri, 17 May 2013 06:30:10 +0000 (17 14:30 +0800)
committerGuannan Ren <gren@redhat.com>
Mon, 15 Jul 2013 10:20:42 +0000 (15 18:20 +0800)
tree4b343cb20f61428010ce1018d238b70942b1ca37
parent82395204f317217a2a9fd04c9d2db307c07a3978
python: return dictionary without value in case of no blockjob

Currently, when there is no blockjob, dom.blockJobInfo('vda')
still reports error because it doesn't distinguish return value 0 from -1.
libvirt.libvirtError: virDomainGetBlockJobInfo() failed

virDomainGetBlockJobInfo() API return value:
 -1 in case of failure, 0 when nothing found, 1 found.

And use PyDict_SetItemString instead of PyDict_SetItem when key is
of string type. PyDict_SetItemString increments key/value reference
count, so call Py_DECREF() for value. For key, we don't need to
do this, because PyDict_SetItemString will handle it internally.
libvirt-override.c