| commit | 9e75eb3d44b92e77bd52a0b3cd38712c8d526755 | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Tue, 23 Oct 2007 18:51:33 +0000 (23 18:51 +0000) | ||
| committer | Matthias Urlichs <smurf@hera.kernel.org> | |
| Wed, 14 Nov 2007 11:12:18 +0000 (14 11:12 +0000) | ||
| tree | 235ef4e8fa855b82b0633eaf9f677c6fce28d35b | treesnapshot (tar.gz zip) |
| parent | cc3ecab6c911f4d57f4291709141452e62f92288 | commitdiff |
ia64-slim-down-__clear_bit_unlock-checkpatch-fixes
WARNING: no space between function name and open parenthesis '('
#30: FILE: include/asm-ia64/bitops.h:131:
+__clear_bit_unlock (int nr, volatile void *addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#30: FILE: include/asm-ia64/bitops.h:131:
+__clear_bit_unlock (int nr, volatile void *addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#33: FILE: include/asm-ia64/bitops.h:134:
+ volatile __u32 *m;
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#35: FILE: include/asm-ia64/bitops.h:136:
+ m = (volatile __u32 *) addr + (nr >> 5);
total: 0 errors, 4 warnings, 24 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
WARNING: no space between function name and open parenthesis '('
#30: FILE: include/asm-ia64/bitops.h:131:
+__clear_bit_unlock (int nr, volatile void *addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#30: FILE: include/asm-ia64/bitops.h:131:
+__clear_bit_unlock (int nr, volatile void *addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#33: FILE: include/asm-ia64/bitops.h:134:
+ volatile __u32 *m;
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#35: FILE: include/asm-ia64/bitops.h:136:
+ m = (volatile __u32 *) addr + (nr >> 5);
total: 0 errors, 4 warnings, 24 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| include/asm-ia64/bitops.h | diffblobblamehistory |