| commit | a90a11e0caca63b362bfb03046f34cdae36af9c7 | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Mon, 5 Nov 2007 21:21:17 +0000 (5 21:21 +0000) | ||
| committer | Matthias Urlichs <smurf@hera.kernel.org> | |
| Wed, 14 Nov 2007 11:27:24 +0000 (14 11:27 +0000) | ||
| tree | ddd46fa676e088af4ffa7a19f557fcf9fd9d6940 | treesnapshot (tar.gz zip) |
| parent | 30a80f25f348c5a22a54a49f7ad529062a1007bd | commitdiff |
slub-do-our-own-locking-via-slab_lock-and-slab_unlock-checkpatch-fixes
ERROR: do not use assignment in if condition
#627: FILE: mm/slub.c:2827:
+ if (!page->inuse && (state = slab_trylock(page))) {
total: 1 errors, 0 warnings, 611 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Seems nicer this way.
Should the `if (page->inuse)' test be marked unlikely()?
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
ERROR: do not use assignment in if condition
#627: FILE: mm/slub.c:2827:
+ if (!page->inuse && (state = slab_trylock(page))) {
total: 1 errors, 0 warnings, 611 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Seems nicer this way.
Should the `if (page->inuse)' test be marked unlikely()?
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| mm/slub.c | diffblobblamehistory |