| commit | 2e4ceec4edaef6e903422792de4f7f37de98cec6 | |
| author | Julia Lawall <julia@diku.dk> | |
| Wed, 1 Jun 2011 19:48:50 +0000 (1 19:48 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 2 Jun 2011 07:10:01 +0000 (2 00:10 -0700) | ||
| tree | 628626d17ea26b1c77449afc9bdee88581982033 | treesnapshot (tar.gz zip) |
| parent | 6979d5dd96a4a4975ce240982436e92a3da23315 | commitdiff |
drivers/net/can/flexcan.c: add missing clk_put
The failed_get label is used after the call to clk_get has succeeded, so it
should be moved up above the call to clk_put.
The failed_req labels doesn't do anything different than failed_get, so
delete it.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression e1,e2;
statement S;
@@
e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
The failed_get label is used after the call to clk_get has succeeded, so it
should be moved up above the call to clk_put.
The failed_req labels doesn't do anything different than failed_get, so
delete it.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression e1,e2;
statement S;
@@
e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/can/flexcan.c | diffblobblamehistory |