| commit | 77dc2db6d1d2703ee4e83d4b3dbecf4e06a910e6 | |
| author | Mark Assad <massad@gmail.com> | |
| Thu, 5 Oct 2006 02:25:05 +0000 (5 12:25 +1000) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Thu, 5 Oct 2006 02:44:36 +0000 (4 19:44 -0700) | ||
| tree | f8ff9b87a63409bd774a9723e2c5b3b546d91134 | treesnapshot (tar.gz zip) |
| parent | 4b8447184ae85de4ce710e5f561fbaada21b8394 | commitdiff |
[PATCH] itmtouch: fix inverted flag to indicate touch location correctly, correct white space
There is a bug in the current version of the itmtouch USB touchscreen
driver. The if statment that checks if pressure is being applied to the
touch screen is now missing a ! (not), so events are no longer being
reported correctly.
The original source code for this line was as follows:
#define UCP(x) ((unsigned char*)(x))
#define UCOM(x,y,z) ((UCP((x)->transfer_buffer)[y]) & (z))
...
if (!UCOM(urb, 7, 0x20)) {
And was cleaned to:
unsigned char *data = urb->transfer_buffer;
....
if (data[7] & 0x20) {
(note the lack of '!')
This has been tested on an LG L1510BF and an LG1510SF touch screen.
Signed-off-by: Mark Assad <massad@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
There is a bug in the current version of the itmtouch USB touchscreen
driver. The if statment that checks if pressure is being applied to the
touch screen is now missing a ! (not), so events are no longer being
reported correctly.
The original source code for this line was as follows:
#define UCP(x) ((unsigned char*)(x))
#define UCOM(x,y,z) ((UCP((x)->transfer_buffer)[y]) & (z))
...
if (!UCOM(urb, 7, 0x20)) {
And was cleaned to:
unsigned char *data = urb->transfer_buffer;
....
if (data[7] & 0x20) {
(note the lack of '!')
This has been tested on an LG L1510BF and an LG1510SF touch screen.
Signed-off-by: Mark Assad <massad@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| drivers/usb/input/itmtouch.c | diffblobblamehistory |