| commit | dc1b83ab08f1954335692cdcd499f78c94f4c42a | |
| author | Oleg Nesterov <oleg@redhat.com> | |
| Mon, 14 Mar 2011 19:05:30 +0000 (14 20:05 +0100) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Mon, 14 Mar 2011 20:38:35 +0000 (14 13:38 -0700) | ||
| tree | e05f9760a40c2560e500762b13ef81b37f153b9d | treesnapshot (tar.gz zip) |
| parent | 5f40d4209461f23a15d88c6b55993bb8b0fa2670 | commitdiff |
oom: oom_kill_process: fix the child_points logic
oom_kill_process() starts with victim_points == 0. This means that
(most likely) any child has more points and can be killed erroneously.
Also, "children has a different mm" doesn't match the reality, we should
check child->mm != t->mm. This check is not exactly correct if t->mm ==
NULL but this doesn't really matter, oom_kill_task() will kill them
anyway.
Note: "Kill all processes sharing p->mm" in oom_kill_task() is wrong
too.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
oom_kill_process() starts with victim_points == 0. This means that
(most likely) any child has more points and can be killed erroneously.
Also, "children has a different mm" doesn't match the reality, we should
check child->mm != t->mm. This check is not exactly correct if t->mm ==
NULL but this doesn't really matter, oom_kill_task() will kill them
anyway.
Note: "Kill all processes sharing p->mm" in oom_kill_task() is wrong
too.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| mm/oom_kill.c | diffblobblamehistory |