| commit | dc66c74de6f4238020db3e2041d4aca5c5b3e9bc | |
| author | Philipp Reisner <philipp.reisner@linbit.com> | |
| Wed, 2 Jun 2010 12:31:29 +0000 (2 14:31 +0200) | ||
| committer | Philipp Reisner <philipp.reisner@linbit.com> | |
| Mon, 14 Jun 2010 10:19:41 +0000 (14 12:19 +0200) | ||
| tree | 8df9cdd2f1672217a210e624f4613744e57450e0 | treesnapshot (tar.gz zip) |
| parent | 7e27d6e778cd87b6f2415515d7127eba53fe5d02 | commitdiff |
drbd: Fixed a race between disk-attach and unexpected state changes
This was a very hard to trigger race condition.
If we got a state packet from the peer, after drbd_nl_disk() has
already changed the disk state to D_NEGOTIATING but
after_state_ch() was not yet run by the worker, then receive_state()
might called drbd_sync_handshake(), which in turn crashed
when accessing p_uuid.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
This was a very hard to trigger race condition.
If we got a state packet from the peer, after drbd_nl_disk() has
already changed the disk state to D_NEGOTIATING but
after_state_ch() was not yet run by the worker, then receive_state()
might called drbd_sync_handshake(), which in turn crashed
when accessing p_uuid.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
| drivers/block/drbd/drbd_main.c | diffblobblamehistory | |
| drivers/block/drbd/drbd_nl.c | diffblobblamehistory | |
| include/linux/drbd.h | diffblobblamehistory |