| commit | de75577c8c3ab733f808c65e1a9d55882efde68e | |
| author | Julia Lawall <julia@diku.dk> | |
| Sat, 20 Aug 2011 06:12:41 +0000 (20 08:12 +0200) | ||
| committer | Takashi Iwai <tiwai@suse.de> | |
| Sat, 20 Aug 2011 07:27:04 +0000 (20 09:27 +0200) | ||
| tree | 09c9b6f77ecb2c8e4bdd823c8748606cddf8f3d0 | treesnapshot (tar.gz zip) |
| parent | 1b004d03d8670bdd871e0f297ed20bc510e404de | commitdiff |
ALSA: sound/aoa/fabrics/layout.c: remove unneeded kfree
The label outnodev is only used when kzalloc has not yet taken place or has
failed, so there is no need for the call for kfree under this label.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@
(
if (...) { ... when != kfree(x)
when != x = E3
when != E3 = x
* return ...;
}
... when != x = E2
when != I(...,x,...) S
if (...) { ... when != x = E4
kfree(x); ... return ...; }
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
The label outnodev is only used when kzalloc has not yet taken place or has
failed, so there is no need for the call for kfree under this label.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@
(
if (...) { ... when != kfree(x)
when != x = E3
when != E3 = x
* return ...;
}
... when != x = E2
when != I(...,x,...) S
if (...) { ... when != x = E4
kfree(x); ... return ...; }
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| sound/aoa/fabrics/layout.c | diffblobblamehistory |