| commit | 299f590f26da9764f20e905879f0090552ff2e86 | |
| author | Julia Lawall <julia@diku.dk> | |
| Tue, 11 Dec 2007 01:16:56 +0000 (10 17:16 -0800) | ||
| committer | David S. Miller <davem@sunset.davemloft.net> | |
| Tue, 11 Dec 2007 10:45:28 +0000 (11 02:45 -0800) | ||
| tree | c60015bd19092e936d9aa492ab6f74e10258c6ec | treesnapshot (tar.gz zip) |
| parent | 505a41d43c24345f3fa77ddab152d1f82dd8264d | commitdiff |
[XTENSA]: Fix use of skb after netif_rx
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument. The same problem occurs in some other drivers as well.
This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression skb, e,e1;
@@
(
netif_rx(skb);
|
netif_rx_ni(skb);
)
... when != skb = e
(
skb = e1
|
* skb
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument. The same problem occurs in some other drivers as well.
This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression skb, e,e1;
@@
(
netif_rx(skb);
|
netif_rx_ni(skb);
)
... when != skb = e
(
skb = e1
|
* skb
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| arch/xtensa/platform-iss/network.c | diffblobblamehistory |