| commit | c32bc6e9b0778c891f7f3b97cd05c8cdf98b6721 | |
| author | Roel Kluin <12o3l@tiscali.nl> | |
| Wed, 5 Dec 2007 19:57:30 +0000 (5 11:57 -0800) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Fri, 7 Dec 2007 20:01:43 +0000 (7 15:01 -0500) | ||
| tree | c65214a5e8cedacf517d9337fa100ec0810e4d7a | treesnapshot (tar.gz zip) |
| parent | 70eba18b5664f90d7620905e005b89388e5fd94b | commitdiff |
e1000: fix memcpy in e1000_get_strings
drivers/net/e1000/e1000_ethtool.c:113:
#define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
drivers/net/e1000e/ethtool.c:106:
#define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
E1000_TEST_LEN*ETH_GSTRING_LEN will expand to
sizeof(e1000_gstrings_test) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN)
A lack of parentheses around defines causes unexpected results due to
operator precedences.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/e1000/e1000_ethtool.c:113:
#define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
drivers/net/e1000e/ethtool.c:106:
#define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
E1000_TEST_LEN*ETH_GSTRING_LEN will expand to
sizeof(e1000_gstrings_test) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN)
A lack of parentheses around defines causes unexpected results due to
operator precedences.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/e1000/e1000_ethtool.c | diffblobblamehistory | |
| drivers/net/e1000e/ethtool.c | diffblobblamehistory |