| commit | eb4965344965530411359891214cd6fcab483649 | |
| author | Johannes Berg <johannes@sipsolutions.net> | |
| Wed, 18 Jul 2007 09:07:51 +0000 (18 02:07 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 18 Jul 2007 09:07:51 +0000 (18 02:07 -0700) | ||
| tree | d6007042cd1ca2ac1f2378ea93ce3878bec89d0b | treesnapshot (tar.gz zip) |
| parent | f77ae9390438409b535f3b1854672e54120cd38b | commitdiff |
[NETLINK]: negative groups in netlink_setsockopt
Reading netlink_setsockopt it's not immediately clear why there isn't a
bug when you pass in negative numbers, the reason being that the >=
comparison is really unsigned although 'val' is signed because
nlk->ngroups is unsigned. Make 'val' unsigned too.
[ Update the get_user() cast to match. --DaveM ]
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Reading netlink_setsockopt it's not immediately clear why there isn't a
bug when you pass in negative numbers, the reason being that the >=
comparison is really unsigned although 'val' is signed because
nlk->ngroups is unsigned. Make 'val' unsigned too.
[ Update the get_user() cast to match. --DaveM ]
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/netlink/af_netlink.c | diffblobblamehistory |