[SCSI] aic94xx: fix REQ_TASK_ABORT and REQ_DEVICE_RESET
commitcb84e2d2ff3b50c0da5a7604a6d8634294a00a01
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 15 Feb 2008 15:28:43 +0000 (15 09:28 -0600)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Mon, 18 Feb 2008 14:57:15 +0000 (18 08:57 -0600)
treed94f524f967583bbe26da0bb15ea48f230d83f43
parent691b4773aa556d0975dbc25c93e6c8b839dad325
[SCSI] aic94xx: fix REQ_TASK_ABORT and REQ_DEVICE_RESET

This driver has been failing under heavy load with

aic94xx: escb_tasklet_complete: REQ_TASK_ABORT, reason=0x6
aic94xx: escb_tasklet_complete: Can't find task (tc=4) to abort!

The second message is because the driver fails to identify the task
it's being asked to abort.  On closer inpection, there's a thinko in
the for each task loop over pending tasks in both the REQ_TASK_ABORT
and REQ_DEVICE_RESET cases where it doesn't look at the task on the
pending list but at the one on the ESCB (which is always NULL).

Fix by looking at the right task.  Also add a print for the case where
the pending SCB doesn't have a task attached.

Not sure if this will fix all the problems, but it's a definite first
step.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/aic94xx/aic94xx_scb.c