sctp: avoid BUG_ON on sctp_wait_for_sndbuf
commit00eff2ebbd229758e90659907724c14dd5a18339
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Mon, 6 Feb 2017 20:10:31 +0000 (6 18:10 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2017 14:11:42 +0000 (18 15:11 +0100)
tree6aacbbcf8c9335e3fd433f9ece61ed9b344cb69f
parent4400acce6881bc40380afa4c0559348a9feb7329
sctp: avoid BUG_ON on sctp_wait_for_sndbuf

[ Upstream commit 2dcab598484185dea7ec22219c76dcdd59e3cb90 ]

Alexander Popov reported that an application may trigger a BUG_ON in
sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is
waiting on it to queue more data and meanwhile another thread peels off
the association being used by the first thread.

This patch replaces the BUG_ON call with a proper error handling. It
will return -EPIPE to the original sendmsg call, similarly to what would
have been done if the association wasn't found in the first place.

Acked-by: Alexander Popov <alex.popov@linux.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sctp/socket.c