| commit | 0373130d5bc783751c1fbad948886916a21d4559 | |
| author | Eric Sandeen <sandeen@redhat.com> | |
| Tue, 18 Aug 2009 03:51:29 +0000 (17 23:51 -0400) | ||
| committer | Theodore Ts'o <tytso@mit.edu> | |
| Tue, 18 Aug 2009 03:51:29 +0000 (17 23:51 -0400) | ||
| tree | a5b4d21b84345354ff965714bd6a6c473bae4b0f | treesnapshot (tar.gz zip) |
| parent | bf43d84b185e2ff54598f8c58a5a8e63148b6e90 | commitdiff |
ext4: open-code ext4_mb_update_group_info
ext4_mb_update_group_info is only called in one place, and it's
extremely simple. There's no reason to have it in a separate function
in a separate file as far as I can tell, it just obfuscates what's
really going on.
Perhaps it was intended to keep the grp->bb_* manipulation local to
mballoc.c but we're already accessing other grp-> fields in balloc.c
directly so this seems ok.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
ext4_mb_update_group_info is only called in one place, and it's
extremely simple. There's no reason to have it in a separate function
in a separate file as far as I can tell, it just obfuscates what's
really going on.
Perhaps it was intended to keep the grp->bb_* manipulation local to
mballoc.c but we're already accessing other grp-> fields in balloc.c
directly so this seems ok.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| fs/ext4/balloc.c | diffblobblamehistory | |
| fs/ext4/ext4.h | diffblobblamehistory | |
| fs/ext4/mballoc.c | diffblobblamehistory |