| commit | 0976a03e5ce8ec346e985f21046d7a75bb7fdffd | |
| author | Oleg Nesterov <oleg@redhat.com> | |
| Wed, 22 Jun 2011 21:09:39 +0000 (22 23:09 +0200) | ||
| committer | Oleg Nesterov <oleg@redhat.com> | |
| Mon, 27 Jun 2011 18:30:09 +0000 (27 20:30 +0200) | ||
| tree | 347ab2fa51689226d734b288f330b5ad16997d8e | treesnapshot (tar.gz zip) |
| parent | 8677347378044ab564470bced2275520efb3670d | commitdiff |
reparent_leader: check EXIT_DEAD instead of task_detached()
Change reparent_leader() to check ->exit_state instead of ->exit_signal,
this matches the similar EXIT_DEAD check in wait_consider_task() and
allows us to cleanup the do_notify_parent/task_detached logic.
task_detached() was really needed during reparenting before 9cd80bbb
"do_wait() optimization: do not place sub-threads on ->children list"
to filter out the sub-threads. After this change task_detached(p) can
only be true if p is the dead group_leader and its parent ignores
SIGCHLD, in this case the caller of do_notify_parent() is going to
reap this task and it should set EXIT_DEAD.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Tejun Heo <tj@kernel.org>
Change reparent_leader() to check ->exit_state instead of ->exit_signal,
this matches the similar EXIT_DEAD check in wait_consider_task() and
allows us to cleanup the do_notify_parent/task_detached logic.
task_detached() was really needed during reparenting before 9cd80bbb
"do_wait() optimization: do not place sub-threads on ->children list"
to filter out the sub-threads. After this change task_detached(p) can
only be true if p is the dead group_leader and its parent ignores
SIGCHLD, in this case the caller of do_notify_parent() is going to
reap this task and it should set EXIT_DEAD.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Tejun Heo <tj@kernel.org>
| kernel/exit.c | diffblobblamehistory |