| commit | 0dc1362562a2e8b82a6be8d3ae307a234f28f9bc | |
| author | Thomas Graf <tgraf@suug.ch> | |
| Fri, 1 Aug 2014 15:25:38 +0000 (1 17:25 +0200) | ||
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | |
| Fri, 1 Aug 2014 16:14:49 +0000 (1 18:14 +0200) | ||
| tree | a08ecdf611c6900b521b3b15ff6e8c9222c7f9d5 | treesnapshot (tar.gz zip) |
| parent | 8452e6ff3efce76335eba9d29d2a5b3b524b9f1f | commitdiff |
netfilter: nf_tables: Avoid duplicate call to nft_data_uninit() for same key
nft_del_setelem() currently calls nft_data_uninit() twice on the same
key. Once to release the key which is guaranteed to be NFT_DATA_VALUE
and a second time in the error path to which it falls through.
The second call has been harmless so far though because the type
passed is always NFT_DATA_VALUE which is currently a no-op.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
nft_del_setelem() currently calls nft_data_uninit() twice on the same
key. Once to release the key which is guaranteed to be NFT_DATA_VALUE
and a second time in the error path to which it falls through.
The second call has been harmless so far though because the type
passed is always NFT_DATA_VALUE which is currently a no-op.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| net/netfilter/nf_tables_api.c | diffblobblamehistory |