| commit | 0e4e3fb4901d19f49e5c0a582f383b10dda8d1c5 | |
| author | Samuel Holland <samuel@sholland.org> | |
| Tue, 11 Feb 2020 07:28:56 +0000 (11 01:28 -0600) | ||
| committer | Maxime Ripard <maxime@cerno.tech> | |
| Fri, 14 Feb 2020 15:20:24 +0000 (14 16:20 +0100) | ||
| tree | e5baccd30c6151b7428c58f4ccf2bcb07013c166 | treesnapshot (tar.gz zip) |
| parent | dc84f0915128218f96a0c9c1628e078c95ae36f6 | commitdiff |
drm/sun4i: dsi: Use NULL to signify "no panel"
The continued use of an ERR_PTR to signify "no panel" outside of
sun6i_dsi_attach is confusing because it is a double negative. Because
the connector always reports itself as connected, there is also the
possibility of sending an ERR_PTR to drm_panel_get_modes(), which would
crash.
Solve both of these by only storing the panel pointer if it is valid.
Fixes: 133add5b5ad4 ("drm/sun4i: Add Allwinner A31 MIPI-DSI controller support")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20200211072858.30784-2-samuel@sholland.org
The continued use of an ERR_PTR to signify "no panel" outside of
sun6i_dsi_attach is confusing because it is a double negative. Because
the connector always reports itself as connected, there is also the
possibility of sending an ERR_PTR to drm_panel_get_modes(), which would
crash.
Solve both of these by only storing the panel pointer if it is valid.
Fixes: 133add5b5ad4 ("drm/sun4i: Add Allwinner A31 MIPI-DSI controller support")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20200211072858.30784-2-samuel@sholland.org
| drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | diffblobblamehistory |