USB: fix out-of-bounds in usb_set_configuration
commit13713e63bdb306f9a58d359b15edd60f34eac5ee
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2017 13:07:17 +0000 (19 15:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Oct 2017 09:27:33 +0000 (12 11:27 +0200)
tree07861c5b88cf553d92b16b0acf23e6b8912222fa
parentddcbaf853dc5e3242b8423cdeae4a180a34432cb
USB: fix out-of-bounds in usb_set_configuration

commit bd7a3fe770ebd8391d1c7d072ff88e9e76d063eb upstream.

Andrey Konovalov reported a possible out-of-bounds problem for a USB interface
association descriptor.  He writes:
It seems there's no proper size check of a USB_DT_INTERFACE_ASSOCIATION
descriptor. It's only checked that the size is >= 2 in
usb_parse_configuration(), so find_iad() might do out-of-bounds access
to intf_assoc->bInterfaceCount.

And he's right, we don't check for crazy descriptors of this type very well, so
resolve this problem.  Yet another issue found by syzkaller...

Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/config.c
include/uapi/linux/usb/ch9.h