iwlwifi: don't mess up the SCD when removing a key
commit1757efa77a3f9e114667b3a3a7f7f222fcb3a280
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Wed, 6 Jun 2012 07:13:36 +0000 (6 09:13 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Jun 2012 22:18:07 +0000 (19 23:18 +0100)
tree4315b7f6487069deef8dbaddcb09c3c13db1c5b0
parentdcbf047fc060c9cfea0c4bb16ac322e4e6a08500
iwlwifi: don't mess up the SCD when removing a key

commit d6ee27eb13beab94056e0de52d81220058ca2297 upstream.

When we remove a key, we put a key index which was supposed
to tell the fw that we are actually removing the key. But
instead the fw took that index as a valid index and messed
up the SRAM of the device.

This memory corruption on the device mangled the data of
the SCD. The impact on the user is that SCD queue 2 got
stuck after having removed keys.
The message is the log that was printed is:

Queue 2 stuck for 10000ms

This doesn't seem to fix the higher queues that get stuck
from time to time.

Reviewed-by: Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/iwlwifi/iwl-agn-sta.c