| commit | 2269848386c4b8395bc67eaaf7d08011da7c07ef | |
| author | Varun Prakash <varun@chelsio.com> | |
| Wed, 11 Oct 2017 14:03:21 +0000 (11 19:33 +0530) | ||
| committer | Martin K. Petersen <martin.petersen@oracle.com> | |
| Wed, 11 Oct 2017 18:26:49 +0000 (11 14:26 -0400) | ||
| tree | 5bfdb300156c62f189890dc004f2b19a62461a26 | treesnapshot (tar.gz zip) |
| parent | 9b3a081fb62158b50bcc90522ca2423017544367 | commitdiff |
scsi: libcxgbi: simplify task->hdr allocation for mgmt cmds
In case of mgmt cmds, task->hdr is dereferenced after transmitting the
pdu in iscsi_tcp_task_xmit(). To handle this case current code
increments the Tx skb reference count and frees the skb in
cxgbi_cleanup_task(). In some error cases this results in skb leak.
To fix this in case of mgmt cmds, allocate a separate buffer for iSCSI
hdr and free this buffer in cxgbi_cleanup_task().
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
In case of mgmt cmds, task->hdr is dereferenced after transmitting the
pdu in iscsi_tcp_task_xmit(). To handle this case current code
increments the Tx skb reference count and frees the skb in
cxgbi_cleanup_task(). In some error cases this results in skb leak.
To fix this in case of mgmt cmds, allocate a separate buffer for iSCSI
hdr and free this buffer in cxgbi_cleanup_task().
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| drivers/scsi/cxgbi/libcxgbi.c | diffblobblamehistory | |
| drivers/scsi/cxgbi/libcxgbi.h | diffblobblamehistory |