| commit | 22c2b77f419bdc9317f00b395283abd33157368e | |
| author | Matt Fleming <matt@codeblueprint.co.uk> | |
| Mon, 15 Aug 2016 14:29:20 +0000 (15 15:29 +0100) | ||
| committer | Matt Fleming <matt@codeblueprint.co.uk> | |
| Fri, 9 Sep 2016 15:08:48 +0000 (9 16:08 +0100) | ||
| tree | 379db94c904ad0916c7cbc9d11c0f0d2fc77f6e1 | treesnapshot (tar.gz zip) |
| parent | 0513fe1d28e45deb39159dbeedf0660c3f0effd2 | commitdiff |
fs/efivarfs: Fix double kfree() in error path
Julia reported that we may double free 'name' in efivarfs_callback(),
and that this bug was introduced by commit 0d22f33bc37c ("efi: Don't
use spinlocks for efi vars").
Move one of the kfree()s until after the point at which we know we are
definitely on the success path.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Sylvain Chouleur <sylvain.chouleur@gmail.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Julia reported that we may double free 'name' in efivarfs_callback(),
and that this bug was introduced by commit 0d22f33bc37c ("efi: Don't
use spinlocks for efi vars").
Move one of the kfree()s until after the point at which we know we are
definitely on the success path.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Sylvain Chouleur <sylvain.chouleur@gmail.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
| fs/efivarfs/super.c | diffblobblamehistory |