| commit | 24c0e6838cb4888366008bd36e0a77a995b18bb7 | |
| author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | |
| Mon, 23 Mar 2015 19:23:12 +0000 (23 16:23 -0300) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 23 Mar 2015 21:01:58 +0000 (23 17:01 -0400) | ||
| tree | bec8de4cb748cbfd545b27c45c0280a64979da15 | treesnapshot (tar.gz zip) |
| parent | b6f15f828d4b624a2e4306dabbbb20a581bece37 | commitdiff |
vxlan: simplify if clause in dev_close
Dan Carpenter's static checker warned that in vxlan_stop we are checking
if 'vs' can be NULL while later we simply derreference it.
As after commit 56ef9c909b40 ("vxlan: Move socket initialization to
within rtnl scope") 'vs' just cannot be NULL in vxlan_stop() anymore, as
the interface won't go up if the socket initialization fails. So we are
good to just remove the check and make it consistent.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter's static checker warned that in vxlan_stop we are checking
if 'vs' can be NULL while later we simply derreference it.
As after commit 56ef9c909b40 ("vxlan: Move socket initialization to
within rtnl scope") 'vs' just cannot be NULL in vxlan_stop() anymore, as
the interface won't go up if the socket initialization fails. So we are
good to just remove the check and make it consistent.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/vxlan.c | diffblobblamehistory |