| commit | 257117862634d89de33fec74858b1a0ba5ab444b | |
| author | Eric Dumazet <edumazet@google.com> | |
| Thu, 18 Sep 2014 15:02:05 +0000 (18 08:02 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 22 Sep 2014 18:21:47 +0000 (22 14:21 -0400) | ||
| tree | 799321753c9f5ac9358c708bced556df7e309772 | treesnapshot (tar.gz zip) |
| parent | 476c18850c6cbaa3f2bb661ae9710645081563b9 | commitdiff |
net: sched: shrink struct qdisc_skb_cb to 28 bytes
We cannot make struct qdisc_skb_cb bigger without impacting IPoIB,
or increasing skb->cb[] size.
Commit e0f31d849867 ("flow_keys: Record IP layer protocol in
skb_flow_dissect()") broke IPoIB.
Only current offender is sch_choke, and this one do not need an
absolutely precise flow key.
If we store 17 bytes of flow key, its more than enough. (Its the actual
size of flow_keys if it was a packed structure, but we might add new
fields at the end of it later)
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: e0f31d849867 ("flow_keys: Record IP layer protocol in skb_flow_dissect()")
Signed-off-by: David S. Miller <davem@davemloft.net>
We cannot make struct qdisc_skb_cb bigger without impacting IPoIB,
or increasing skb->cb[] size.
Commit e0f31d849867 ("flow_keys: Record IP layer protocol in
skb_flow_dissect()") broke IPoIB.
Only current offender is sch_choke, and this one do not need an
absolutely precise flow key.
If we store 17 bytes of flow key, its more than enough. (Its the actual
size of flow_keys if it was a packed structure, but we might add new
fields at the end of it later)
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: e0f31d849867 ("flow_keys: Record IP layer protocol in skb_flow_dissect()")
Signed-off-by: David S. Miller <davem@davemloft.net>
| include/net/sch_generic.h | diffblobblamehistory | |
| net/sched/sch_choke.c | diffblobblamehistory |