usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()
commit277882f94e1d2e82285eb3dc91944634174a9b18
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 4 Apr 2016 11:40:20 +0000 (4 20:40 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2016 06:42:11 +0000 (20 15:42 +0900)
tree62e7977afaab6f06cf1fd0f8f69ea3202b0da0a3
parent46e081b3015dd0d97e443babf0a7ec2058637d83
usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()

commit 4fccb0767fdbdb781a9c5b5c15ee7b219443c89d upstream.

This patch fixes an issue that usbhsg_queue_done() may cause kernel
panic when dma callback is running and usb_ep_disable() is called
by interrupt handler. (Especially, we can reproduce this issue using
g_audio with usb-dmac driver.)

For example of a flow:
 usbhsf_dma_complete (on tasklet)
  --> usbhsf_pkt_handler (on tasklet)
   --> usbhsg_queue_done (on tasklet)
    *** interrupt happened and usb_ep_disable() is called ***
    --> usbhsg_queue_pop (on tasklet)
     Then, oops happened.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/renesas_usbhs/mod_gadget.c